Grouping generic #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR fixes elastic#150738 by adding support for negative denominators for TSVB's filter ratios. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Stratoula Kalafateli <[email protected]>
…52228) ## 📓 Summary Closes elastic#150741 - Add infra alerts mock file - Add initial functional tests for the Alerts Tab - Remove duplicated tests by the role as they are inclusive of the same privileges - Restructure existing tests to **cut execution time by ~50%** Before | After :-------------------------:|:-------------------------: <img width="164" alt="before" src="https://user-images.githubusercontent.com/34506779/221805295-9de8c467-e212-4cb7-b270-bd8d10063e0f.png"> | <img width="161" alt="after" src="https://user-images.githubusercontent.com/34506779/221805315-a4a105df-6b5b-4cb4-bdeb-8384f0459f91.png"> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]>
…p3/dashboard_state·ts (elastic#152245) Fixes elastic#139762 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1965 2 changes where required to get functional tests running * Switch application state updating from string replace to rison decode/encode. `_a` is not longer provided in the URL unless there are unsaved changes to simple string replace did not work in some cases. Using rison decode/encode was easier then handling a lot of if statements around whether `_a` exists before attempting string replace, plus rison decode/encode is a lot more maintainable and robust. * Fix bug where appending `&_a=(panels:())` to URL would not remove panels. Updated logic in sync_dashboard_url_state to handle case where panels has no length. --------- Co-authored-by: kibanamachine <[email protected]>
Fixes elastic#152121 Removes data view telemetry collection --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Introduces a new page introduction component to be used in various places. This way we ensure spacing are correct and consistent in between configuration tabs. https://user-images.githubusercontent.com/1410658/221848745-989687b4-1826-48b2-b9c8-fe5750d57c6e.mov ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
…lastic#152306) Co-authored-by: Kibana Machine <[email protected]>
## Summary Bring back update api key test ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…ent (elastic#150928) ## Summary This shows an error for broken crawlers, where a connector document has been deleted. It offers users the choice to recreate the connector or delete their index. https://user-images.githubusercontent.com/94373878/221916920-f75299b4-f88d-4cba-89a2-92fe62366050.mov https://user-images.githubusercontent.com/94373878/221916935-b416a782-92b4-4795-a1af-73e97fa523c8.mov
## Summary Resolves elastic#150725 Adds `Integrations: All` permissions requirement for interacting with Private locations A user without permissions <img width="1500" alt="Screen Shot 2023-02-23 at 3 26 15 PM" src="https://user-images.githubusercontent.com/11356435/221023579-adc41aa9-2a57-4d97-89ef-048b757a3442.png"> <img width="354" alt="Screen Shot 2023-02-23 at 3 26 06 PM" src="https://user-images.githubusercontent.com/11356435/221023582-7025f9f7-068d-4d86-af2b-4699f51322d8.png"> <img width="359" alt="Screen Shot 2023-02-23 at 3 26 01 PM" src="https://user-images.githubusercontent.com/11356435/221023585-fb53b3fb-39e6-4340-b2dc-709168e66fc5.png"> <img width="1510" alt="Screen Shot 2023-02-23 at 2 36 02 PM" src="https://user-images.githubusercontent.com/11356435/221023588-582aa339-f14b-405c-86e8-8e22df5b9527.png"> <img width="1521" alt="Screen Shot 2023-02-23 at 1 16 38 PM" src="https://user-images.githubusercontent.com/11356435/221023590-2634a673-90a9-4e52-9725-4a2a50fa400e.png"> <img width="1509" alt="Screen Shot 2023-02-23 at 12 28 08 PM" src="https://user-images.githubusercontent.com/11356435/221023592-7acd7bcc-8dd7-40ba-a563-e84e0a0f1e92.png"> A user with permissions <img width="1520" alt="Screen Shot 2023-02-23 at 1 22 11 PM" src="https://user-images.githubusercontent.com/11356435/221023589-1cca1bf4-c9b5-4776-887d-73eb07b73862.png"> ### Testing 1. Create a user with the following permissions ``` Index: synthetics-*: read Kibana: Uptime/Synthetics: All. Integrations: All ``` 2. Log in as that user 3. Navigate to Private locations in Synthetics settings. Confirm the add agent button is disabled and the need permission notice appears 4. Log in as a super user, create a private location 5. Log out, log in as the regular Uptime user 6. Navigate to Private locations in Synthetics settings. Confirm the create location button is disabled and the need permission notice appears --------- Co-authored-by: florent-leborgne <[email protected]>
…51533) ## Summary This PR aims to create a footprint in the "security_solution" manage page for the new cloud_defend integration (and kibana plugin). Most of the changes are taken from the cloud_security_posture plugin architecture. The following additions have been made: - "Cloud security posture" category in manage page now includes a link to a new "Defend for containers" policies page (I originally created a new category for cloud_defend, but having two full categories with a single link is kind of a waste of real estate). - Cloud defend page wrapper to handle empty states, and the flows for when the integration is not yet installed, or user doesn't have cloud enterprise subscription. - Basic policies page to serve as a baseline for future detail around each cloud_defend integration (e.g selector / response / alert counts). - Application router and sub plugin tie'ins to security_solution. *Apologies in advance for the large PR :)* ### Screenshots Manage link  Policies page  ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
…ed or enabled when they actually are (elastic#152055) ## Summary Resolves: elastic#142081 elastic#149970 elastic#150968 By adding an initial query for installed integrations and augments the existing `InstalledIntegrationArray` constructed using `PackagePolicy`'s. Also removes `version` from the `packageKey` when calculating installed integrations as there can be mis-matches between different policy versions and the integration itself, and I believe the intended behavior here is to not have multiple `relatedIntegrations` returned for different versions. We may want to expand the response here to include all the different policy versions that exist (and perhaps # of agents assigned the policy). Lastly, updates `getIntegrationsInfoFromPolicy()` to also pull the base `package` details in addition to the policy_template details, as this is what ensure base packages show as `Installed: enabled` if they have an integration policy assigned (vs just showing as `Installed` like when there isn't an integration policy). Note: This PR also adds the `getPackages()` method to the `PackageClient` as it didn't currently exist, and was only available via the fleet API via the `/api/fleet/epm/packages` route. ### Before: <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/221066781-be7aa1c6-1728-4200-98b2-d40946e48bbe.png" /> </p> ### After <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/221323469-e24081f9-0741-41fd-8227-9e319c98b0d3.png" /> </p> --------- Co-authored-by: Georgii Gorbachev <[email protected]>
…stic#151799) Fixes elastic#151223 and elastic#151128 PR does the following 1) creates `shouldFetch$` method that centralizes logic for checking when an embeddable should fetch. 2) updates Lens and Maps embeddable to use `shouldFetch$` 3) Adds unit tests for Maps embeddable to capture behavior of unique edge cases --------- Co-authored-by: kibanamachine <[email protected]>
…151996) Co-authored-by: Dominique Clarke <[email protected]>
…52075) **Relates to:** elastic#151244 ## Summary Re-enable `Do not clears kql when navigating to a new page` url state e2e test. ## Details Investigation has shown that elastic#150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.
…ex (elastic#149326) Fixes [elastic#147237](elastic#147237) Based on the same principle as [elastic#147371](elastic#147371), the goal of this PR is to **avoid reindexing if possible**. This time, the idea is to check whether the new mappings are still compatible with the ones stored in ES. To to so, we attempt to update the mappings in place in the existing index, introducing a new `CHECK_COMPATIBLE_MAPPINGS` step: * If the update operation fails, we assume the mappings are NOT compatible, and we continue with the normal reindexing flow. * If the update operation succeeds, we assume the mappings ARE compatible, and we skip reindexing, just like [elastic#147371](elastic#147371) does.  --------- Co-authored-by: kibanamachine <[email protected]>
…stic#150677) ## Summary - addresses feedback from elastic#149208 - typings for `getSignalsQueryMapFromThreatIndex` - fixes interface name for `getSignalsQueryMapFromThreatIndex` - small code refactorings More details in comments of the initial PR --------- Co-authored-by: kibanamachine <[email protected]>
…lastic#152387) Co-authored-by: Kibana Machine <[email protected]>
…on Engine on Alerts creation (elastic#151004) ## Summary - fixes elastic#147389 - `mergeMissingFieldsWithSource` and `mergeAllFieldsWithSource` method will not be merging anymore multi field values into source. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marshall Main <[email protected]>
…2386) ## Summary Ref elastic/observability-docs#2715 Adds relevant `tags` to all operations in order to help group them more effectively in the generated docs. --------- Co-authored-by: Kibana Machine <[email protected]>
## Summary In this PR we ensure that we are adhering to the goals of versioned HTTP APIs to: 1. Not send SO attributes directly over the wire 2. Have a separate set of interfaces that can be referenced by public and maintained by server
…tion (elastic#152333) ## Summary Closes [elastic#152328](elastic#152328) This PR fixes the average calculation in the Snapshot API, filtering out buckets with null values from it, which are more likely to appear with queries that use small data ranges. The results after this change are equal to what Elasticsearch would calculate in the avg aggregation ### How to test - Make sure you have metrics data (either through enabling the system module in metricbeat or connecting your local kibana to an oblt-cli cluster) - Navigate to `Infrastructure` > `Hosts` - Filter the results to see a single host - Change the data range filter and compare the KPIs against the table. - Validate other pages that use the Snapshot API (Inventory UI and Metrics UI to see if the results there are still correct --------- Co-authored-by: Kibana Machine <[email protected]>
…` for test run details (elastic#152373) Co-authored-by: Shahzad <[email protected]>
…cludeElasticMapsService not set to false (elastic#152396) Fixes elastic#152389 PR adds check to ensure client has access to EMS before using EMS fonts. If the client does not have access to EMS fonts then a warning is logged and map falls back to open sans fonts served from Kibana server.
## Summary Fix elastic#148660 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
)" This reverts commit 54d6321.
elastic#152138) ## Summary This PR adds some UX improvements to how an index pattern can be entered: - [x] Help text under the input was updated to mention that commas can be used - [x] Added in-product docs popover to Index pattern input - [x] Automatically show all sources again if a comma was entered - [x] It's possible to switch between all available sources and only matching ones via new tabs - [x] Index name will be fully highlighted if ES returns that it was an exact match for a wildcard - [x] Persist the selected "Rows per page" value in localStorage <img width="400" alt="Screenshot 2023-03-01 at 12 02 40" src="https://user-images.githubusercontent.com/1415710/222121556-b0288fdc-8095-4a66-b781-d3d389c7f54a.png"> <img width="400" alt="Screenshot 2023-03-01 at 12 02 46" src="https://user-images.githubusercontent.com/1415710/222121559-ede0ec65-e49f-4253-afaa-7c7980f714c8.png"> <img width="400" alt="Screenshot 2023-03-01 at 11 56 59" src="https://user-images.githubusercontent.com/1415710/222120704-a0b2c974-ca03-450a-9beb-6fe72b03c929.png"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Notify appex-qa for changes to FTR Also, cleanup...keeps qa related items in one area in the file. Drop vars directory declaration...no longer needed.
Addresses elastic#152653 Fixes a merge conflict that somehow made its way into main between these two PRs ([1](elastic#152301), [2](elastic#151952))
) Closes elastic#152477 Closes elastic#152478 Closes elastic#152479 150x (alert tests) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1978 100x (context tests) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1979
…n on the toast message (elastic#152313) ## Summary - Addresses elastic#151988 Before the fix, the number of missing connectors was always 1, even if the message says the invalid connectors are more  After,  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>
This PR fixes the API integration test suite report names for ML and Transform tests.
…lastic#151192) ## Summary - partially addresses elastic#145406 by adding dataGenerator - once dataGenerator API agreed, we can proceed with tests refactoring if needed - added README how to use data generating tools - https://github.com/vitaliidm/kibana/blob/alerts/functional-tests-data-generator/x-pack/test/detection_engine_api_integration/utils/data_generator/README.md - partially migrated a few `new terms` tests, to give an example how to use the created tool
## Summary Adds a new feature flag called `agentTamperProtectionEnabled` to Fleet.
## 📓 Summary Closes elastic#152544 The issue was caused by a wrong import, where we were directly importing the hook implementation instead of the context hook exposed by `constate`. This PR also improves a bit the alerts status filtering switching from `match_phrase` to a `term` query. ## 🧪 Testing - Navigate to the Hosts View - Open dev tools - Refresh the page or trigger a new search - Verify the `/snapshot` API is called once to retrieve the table metrics --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> Co-authored-by: kibanamachine <[email protected]>
## Summary Fixes elastic#151563 There is a combination of the folds in the editor (collapsed lines) and the text that can cause the editor to fail. This PR adds a try/catch clause to the editor, so that the UI can still be used. ### How to use 1. Open Kibana and in your browser's Dev Tools, delete everything from local storage. 2. Add following 2 items back to the local storage: ``` sense:folds [{"start":{"row":1,"column":1},"end":{"row":82,"column":4}}] sense:console_local_text-object_e69f508c-3342-45cf-ae7c-2753548ce8e7 {"id":"e69f508c-3342-45cf-ae7c-2753548ce8e7","createdAt":1675332935410,"updatedAt":1676630754720,"text":"GET _cat/indices"} ``` 3. Navigate to Console in Kibana, make sure the editor works. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
Co-authored-by: kibanamachine <[email protected]>
## Summary Fixes: elastic#148469, elastic#148468 Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1981 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <[email protected]>
…elastic#152339) ## 📓 Summary Closes elastic#151150 The issue was caused by a missing rounding up when the same string represented dates. ## 🧪 Testing - Navigates to Hosts View page. - Set date-picker to `Today`. - Verify data are correctly fetched. Repeat the same setting the picker to `This week` https://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov Co-authored-by: Marco Antonio Ghiani <[email protected]>
## Summary Unskip management pages (RBAC access) integrations tests ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary This PR removes the `No matching indices found ` toasts, part of some toast storms . The toasts were triggered when there were no matching indices of a given data view's index pattern. If indication is needed, that there are no available matching indices (it could also be an issue of lack of permissions to the requested indices), it's easy to check following property of an existing data view, if the length of matchedIndices is 0, this equals a 'indices are missing condition`.
stephmilovic
pushed a commit
that referenced
this pull request
Jan 17, 2025
## Summary Extracted from elastic#206411 [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267344#019469ff-7fb9-4c5d-8569-2e445aab27be) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267344/jobs/019469ff-7fb9-4c5d-8569-2e445aab27be/artifacts/01946a1c-62fa-4d30-8863-1b40f8c0b924) Jest Tests #9 / Overview renders correctly when there is no user data view This simplifies overview.tsx by refactoring to rtl and removing the whole snapshot. The snapshot was not useful and the test is still making sure that the intended component is still rendered. By removing enzyme, the test now works properly for both react 17 and 18.
stephmilovic
pushed a commit
that referenced
this pull request
Jan 28, 2025
…lastic#206916) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18] Refactor overview.tsx test to rtl (elastic#206805)](elastic#206805) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T09:57:55Z","message":"[React@18] Refactor overview.tsx test to rtl (elastic#206805)\n\n## Summary\r\n\r\nExtracted from https://github.com/elastic/kibana/pull/206411\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267344#019469ff-7fb9-4c5d-8569-2e445aab27be)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267344/jobs/019469ff-7fb9-4c5d-8569-2e445aab27be/artifacts/01946a1c-62fa-4d30-8863-1b40f8c0b924)\r\nJest Tests #9 / Overview renders correctly when there is no user data\r\nview\r\nThis simplifies overview.tsx by refactoring to rtl and removing the\r\nwhole snapshot. The snapshot was not useful and the test is still making\r\nsure that the intended component is still rendered. By removing enzyme,\r\nthe test now works properly for both react 17 and 18.","sha":"bdcad52cd8d1569590107a43e3bea7cf25164af9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","React@18"],"title":"[React@18] Refactor overview.tsx test to rtl","number":206805,"url":"https://github.com/elastic/kibana/pull/206805","mergeCommit":{"message":"[React@18] Refactor overview.tsx test to rtl (elastic#206805)\n\n## Summary\r\n\r\nExtracted from https://github.com/elastic/kibana/pull/206411\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267344#019469ff-7fb9-4c5d-8569-2e445aab27be)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267344/jobs/019469ff-7fb9-4c5d-8569-2e445aab27be/artifacts/01946a1c-62fa-4d30-8863-1b40f8c0b924)\r\nJest Tests #9 / Overview renders correctly when there is no user data\r\nview\r\nThis simplifies overview.tsx by refactoring to rtl and removing the\r\nwhole snapshot. The snapshot was not useful and the test is still making\r\nsure that the intended component is still rendered. By removing enzyme,\r\nthe test now works properly for both react 17 and 18.","sha":"bdcad52cd8d1569590107a43e3bea7cf25164af9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206805","number":206805,"mergeCommit":{"message":"[React@18] Refactor overview.tsx test to rtl (elastic#206805)\n\n## Summary\r\n\r\nExtracted from https://github.com/elastic/kibana/pull/206411\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267344#019469ff-7fb9-4c5d-8569-2e445aab27be)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267344/jobs/019469ff-7fb9-4c5d-8569-2e445aab27be/artifacts/01946a1c-62fa-4d30-8863-1b40f8c0b924)\r\nJest Tests #9 / Overview renders correctly when there is no user data\r\nview\r\nThis simplifies overview.tsx by refactoring to rtl and removing the\r\nwhole snapshot. The snapshot was not useful and the test is still making\r\nsure that the intended component is still rendered. By removing enzyme,\r\nthe test now works properly for both react 17 and 18.","sha":"bdcad52cd8d1569590107a43e3bea7cf25164af9"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP