Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Fix flaky test and unskip #152263

Merged
merged 3 commits into from
Mar 6, 2023
Merged

[Security Solution][Endpoint] Fix flaky test and unskip #152263

merged 3 commits into from
Mar 6, 2023

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Feb 27, 2023 •
edited by kibanamachine
Loading

Summary

Unskip management pages (RBAC access) integrations tests

Checklist

@ashokaditya ashokaditya self-assigned this Feb 27, 2023
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.7.0 v8.6.2 labels Feb 27, 2023
@ashokaditya ashokaditya changed the title fix flaky test and unskip [Security Solution][Endpoint] Fix flaky test and unskip Feb 27, 2023
@ashokaditya ashokaditya force-pushed the task/unskip-management-skipped-test-145204 branch from 1c9be74 to 794ce9a Compare February 28, 2023 08:21
@ashokaditya ashokaditya added v8.6.0 and removed v8.6.2 labels Feb 28, 2023
@ashokaditya ashokaditya marked this pull request as ready for review February 28, 2023 08:44
@ashokaditya ashokaditya requested a review from a team as a code owner February 28, 2023 08:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

parkiino
parkiino approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@parkiino parkiino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, but do we need to run the flaky test runner?

@ashokaditya
Copy link
Member Author

Just curious, but do we need to run the flaky test runner?

I believe not. The flaky test runner only runs the FTR tests unfortunately and not the integration tests.

@ashokaditya ashokaditya enabled auto-merge (squash) March 6, 2023 12:33
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 0d462db into elastic:main Mar 6, 2023
@kibanamachine kibanamachine mentioned this pull request Mar 6, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 6, 2023
@ashokaditya
[Security Solution][Endpoint] Fix flaky test and unskip (elastic#152263)
a87ae6b 
## Summary

Unskip management pages (RBAC access) integrations tests

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0d462db)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 6, 2023
@ashokaditya
[Security Solution][Endpoint] Fix flaky test and unskip (elastic#152263)
d593989 
## Summary

Unskip management pages (RBAC access) integrations tests

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0d462db)
@kibanamachine kibanamachine mentioned this pull request Mar 6, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@ashokaditya ashokaditya deleted the task/unskip-management-skipped-test-145204 branch March 6, 2023 14:26
@ashokaditya ashokaditya mentioned this pull request Mar 6, 2023
Closed
kibanamachine added a commit that referenced this pull request Mar 6, 2023
@kibanamachine @ashokaditya
[8.7] [Security Solution][Endpoint] Fix flaky test and unskip (#152263)…
7310b5d 
… (#152718)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Endpoint] Fix flaky test and unskip
(#152263)](#152263)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ashokaditya","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T14:20:06Z","message":"[Security
Solution][Endpoint] Fix flaky test and unskip (#152263)\n\n##
Summary\r\n\r\nUnskip management pages (RBAC access) integrations
tests\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0d462db3366d3ddc0da5fc75c08699ba4e22c29a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","OLM
Sprint","v8.6.0","v8.7.0","v8.8.0"],"number":152263,"url":"https://github.com/elastic/kibana/pull/152263","mergeCommit":{"message":"[Security
Solution][Endpoint] Fix flaky test and unskip (#152263)\n\n##
Summary\r\n\r\nUnskip management pages (RBAC access) integrations
tests\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0d462db3366d3ddc0da5fc75c08699ba4e22c29a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.7"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152263","number":152263,"mergeCommit":{"message":"[Security
Solution][Endpoint] Fix flaky test and unskip (#152263)\n\n##
Summary\r\n\r\nUnskip management pages (RBAC access) integrations
tests\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0d462db3366d3ddc0da5fc75c08699ba4e22c29a"}}]}]
BACKPORT-->

Co-authored-by: Ashokaditya <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 6, 2023
@kibanamachine @ashokaditya
[8.6] [Security Solution][Endpoint] Fix flaky test and unskip (#152263)…
deb7b40 
… (#152717)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution][Endpoint] Fix flaky test and unskip
(#152263)](#152263)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ashokaditya","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T14:20:06Z","message":"[Security
Solution][Endpoint] Fix flaky test and unskip (#152263)\n\n##
Summary\r\n\r\nUnskip management pages (RBAC access) integrations
tests\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0d462db3366d3ddc0da5fc75c08699ba4e22c29a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","OLM
Sprint","v8.6.0","v8.7.0","v8.8.0"],"number":152263,"url":"https://github.com/elastic/kibana/pull/152263","mergeCommit":{"message":"[Security
Solution][Endpoint] Fix flaky test and unskip (#152263)\n\n##
Summary\r\n\r\nUnskip management pages (RBAC access) integrations
tests\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0d462db3366d3ddc0da5fc75c08699ba4e22c29a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.7"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152263","number":152263,"mergeCommit":{"message":"[Security
Solution][Endpoint] Fix flaky test and unskip (#152263)\n\n##
Summary\r\n\r\nUnskip management pages (RBAC access) integrations
tests\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0d462db3366d3ddc0da5fc75c08699ba4e22c29a"}}]}]
BACKPORT-->

Co-authored-by: Ashokaditya <[email protected]>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@ashokaditya @bmorelli25
[Security Solution][Endpoint] Fix flaky test and unskip (elastic#152263)
25e4535 
## Summary

Unskip management pages (RBAC access) integrations tests

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkiino parkiino parkiino approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees

@ashokaditya ashokaditya

Labels
OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.6.0 v8.6.3 v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashokaditya @elasticmachine @kibana-ci @kibanamachine @parkiino @paul-tavares