[Infrastructure UI] Hosts View performs /snapshot request with wrong time range #151150
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Metrics UI
Metrics UI feature
Feature:ObsHosts
Hosts feature within Observability
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v8.6.0
v8.7.0
Comments
tonyghiani
added
bug
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
roshan-elastic
added
Infra (UI)
Feature:Metrics UI
This was referenced Feb 28, 2023
tonyghiani
added a commit
that referenced
this issue
Mar 6, 2023
…#152339) ## 📓 Summary Closes #151150 The issue was caused by a missing rounding up when the same string represented dates. ## 🧪 Testing - Navigates to Hosts View page. - Set date-picker to `Today`. - Verify data are correctly fetched. Repeat the same setting the picker to `This week` https://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov Co-authored-by: Marco Antonio Ghiani <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 6, 2023
…elastic#152339) ## 📓 Summary Closes elastic#151150 The issue was caused by a missing rounding up when the same string represented dates. ## 🧪 Testing - Navigates to Hosts View page. - Set date-picker to `Today`. - Verify data are correctly fetched. Repeat the same setting the picker to `This week` https://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit 671a9d8)
kibanamachine
added a commit
that referenced
this issue
Mar 6, 2023
…values (#152339) (#152713) # Backport This will backport the following commits from `main` to `8.7`: - [[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)](#152339) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T14:02:28Z","message":"[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)\n\n## 📓 Summary\r\n\r\nCloses #151150 \r\n\r\nThe issue was caused by a missing rounding up when the same string\r\nrepresented dates.\r\n\r\n## 🧪 Testing\r\n\r\n- Navigates to Hosts View page.\r\n- Set date-picker to `Today`.\r\n- Verify data are correctly fetched.\r\nRepeat the same setting the picker to `This week`\r\n\r\n\r\nhttps://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"671a9d8a74964fbf2f728103af433e7c45d9b1d8","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.8.0"],"number":152339,"url":"https://github.com/elastic/kibana/pull/152339","mergeCommit":{"message":"[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)\n\n## 📓 Summary\r\n\r\nCloses #151150 \r\n\r\nThe issue was caused by a missing rounding up when the same string\r\nrepresented dates.\r\n\r\n## 🧪 Testing\r\n\r\n- Navigates to Hosts View page.\r\n- Set date-picker to `Today`.\r\n- Verify data are correctly fetched.\r\nRepeat the same setting the picker to `This week`\r\n\r\n\r\nhttps://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"671a9d8a74964fbf2f728103af433e7c45d9b1d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152339","number":152339,"mergeCommit":{"message":"[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)\n\n## 📓 Summary\r\n\r\nCloses #151150 \r\n\r\nThe issue was caused by a missing rounding up when the same string\r\nrepresented dates.\r\n\r\n## 🧪 Testing\r\n\r\n- Navigates to Hosts View page.\r\n- Set date-picker to `Today`.\r\n- Verify data are correctly fetched.\r\nRepeat the same setting the picker to `This week`\r\n\r\n\r\nhttps://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"671a9d8a74964fbf2f728103af433e7c45d9b1d8"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this issue
Mar 10, 2023
…elastic#152339) ## 📓 Summary Closes elastic#151150 The issue was caused by a missing rounding up when the same string represented dates. ## 🧪 Testing - Navigates to Hosts View page. - Set date-picker to `Today`. - Verify data are correctly fetched. Repeat the same setting the picker to `This week` https://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📓 Summary
Kibana version: 8.6
As discovered in #149579 (comment), the Hosts View performing requests to the
/snapshotAPI is not correctly parsing into timestamp the date range for these requests.When setting the date-picker to
TodayandThis week, equalsfromandtoparams are sent to the requests as shown in this request payload:In order to correctly fetch the snapshot data, we should assure any possible date-range selection generates the right timestamp to use for the request filter.
✔️ Acceptance criteria
Todaypreset filter should query the/snapshotAPI with a timestamp range from midnight of the current day, till the end of the current dayThis weekpreset filter should query the/snapshotAPI with a timestamp range from midnight of the first day in the current week, till the end of the current day.The text was updated successfully, but these errors were encountered: