[Infrastructure UI] Fix Hosts View date picker for some preset values #152339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 6, 2023
…elastic#152339) ## 📓 Summary Closes elastic#151150 The issue was caused by a missing rounding up when the same string represented dates. ## 🧪 Testing - Navigates to Hosts View page. - Set date-picker to `Today`. - Verify data are correctly fetched. Repeat the same setting the picker to `This week` https://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit 671a9d8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 6, 2023
…values (#152339) (#152713) # Backport This will backport the following commits from `main` to `8.7`: - [[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)](#152339) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T14:02:28Z","message":"[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)\n\n## 📓 Summary\r\n\r\nCloses #151150 \r\n\r\nThe issue was caused by a missing rounding up when the same string\r\nrepresented dates.\r\n\r\n## 🧪 Testing\r\n\r\n- Navigates to Hosts View page.\r\n- Set date-picker to `Today`.\r\n- Verify data are correctly fetched.\r\nRepeat the same setting the picker to `This week`\r\n\r\n\r\nhttps://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"671a9d8a74964fbf2f728103af433e7c45d9b1d8","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.8.0"],"number":152339,"url":"https://github.com/elastic/kibana/pull/152339","mergeCommit":{"message":"[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)\n\n## 📓 Summary\r\n\r\nCloses #151150 \r\n\r\nThe issue was caused by a missing rounding up when the same string\r\nrepresented dates.\r\n\r\n## 🧪 Testing\r\n\r\n- Navigates to Hosts View page.\r\n- Set date-picker to `Today`.\r\n- Verify data are correctly fetched.\r\nRepeat the same setting the picker to `This week`\r\n\r\n\r\nhttps://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"671a9d8a74964fbf2f728103af433e7c45d9b1d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152339","number":152339,"mergeCommit":{"message":"[Infrastructure UI] Fix Hosts View date picker for some preset values (#152339)\n\n## 📓 Summary\r\n\r\nCloses #151150 \r\n\r\nThe issue was caused by a missing rounding up when the same string\r\nrepresented dates.\r\n\r\n## 🧪 Testing\r\n\r\n- Navigates to Hosts View page.\r\n- Set date-picker to `Today`.\r\n- Verify data are correctly fetched.\r\nRepeat the same setting the picker to `This week`\r\n\r\n\r\nhttps://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"671a9d8a74964fbf2f728103af433e7c45d9b1d8"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…elastic#152339) ## 📓 Summary Closes elastic#151150 The issue was caused by a missing rounding up when the same string represented dates. ## 🧪 Testing - Navigates to Hosts View page. - Set date-picker to `Today`. - Verify data are correctly fetched. Repeat the same setting the picker to `This week` https://user-images.githubusercontent.com/34506779/221857418-dbc53fe6-6eca-4645-93cd-b939231e76b0.mov Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #151150
The issue was caused by a missing rounding up when the same string represented dates.
🧪 Testing
Today.Repeat the same setting the picker to
This weekafter-fix.mov