-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Incorrect number of invalid connectors is shown on the toast message #151988
Comments
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
…n on the toast message (#152313) ## Summary - Addresses #151988 Before the fix, the number of missing connectors was always 1, even if the message says the invalid connectors are more ![image](https://user-images.githubusercontent.com/12671903/221798261-8fb7ba28-3a1a-4269-9e00-a540f7febb1b.png) After, ![image](https://user-images.githubusercontent.com/12671903/221798298-1f3728b2-d7a9-41c9-a0f4-d80892a7c0f1.png) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>
…n on the toast message (elastic#152313) ## Summary - Addresses elastic#151988 Before the fix, the number of missing connectors was always 1, even if the message says the invalid connectors are more ![image](https://user-images.githubusercontent.com/12671903/221798261-8fb7ba28-3a1a-4269-9e00-a540f7febb1b.png) After, ![image](https://user-images.githubusercontent.com/12671903/221798298-1f3728b2-d7a9-41c9-a0f4-d80892a7c0f1.png) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c0d2b0f)
…s shown on the toast message (#152313) (#152661) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution]Fix incorrect number of invalid connectors is shown on the toast message (#152313)](#152313) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Wafaa Nasr","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T08:24:00Z","message":"[Security Solution]Fix incorrect number of invalid connectors is shown on the toast message (#152313)\n\n## Summary\r\n\r\n- Addresses https://github.com/elastic/kibana/issues/151988\r\n\r\nBefore the fix, the number of missing connectors was always 1, even if\r\nthe message says the invalid connectors are more\r\n\r\n![image](https://user-images.githubusercontent.com/12671903/221798261-8fb7ba28-3a1a-4269-9e00-a540f7febb1b.png)\r\n\r\nAfter,\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/12671903/221798298-1f3728b2-d7a9-41c9-a0f4-d80892a7c0f1.png)\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"c0d2b0f5cc7d5915f9f3894cdccfc7513a61cdc6","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Security Solution Platform","backport:prev-minor","ci:cloud-deploy","v8.7.0","v8.8.0"],"number":152313,"url":"https://github.com/elastic/kibana/pull/152313","mergeCommit":{"message":"[Security Solution]Fix incorrect number of invalid connectors is shown on the toast message (#152313)\n\n## Summary\r\n\r\n- Addresses https://github.com/elastic/kibana/issues/151988\r\n\r\nBefore the fix, the number of missing connectors was always 1, even if\r\nthe message says the invalid connectors are more\r\n\r\n![image](https://user-images.githubusercontent.com/12671903/221798261-8fb7ba28-3a1a-4269-9e00-a540f7febb1b.png)\r\n\r\nAfter,\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/12671903/221798298-1f3728b2-d7a9-41c9-a0f4-d80892a7c0f1.png)\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"c0d2b0f5cc7d5915f9f3894cdccfc7513a61cdc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152313","number":152313,"mergeCommit":{"message":"[Security Solution]Fix incorrect number of invalid connectors is shown on the toast message (#152313)\n\n## Summary\r\n\r\n- Addresses https://github.com/elastic/kibana/issues/151988\r\n\r\nBefore the fix, the number of missing connectors was always 1, even if\r\nthe message says the invalid connectors are more\r\n\r\n![image](https://user-images.githubusercontent.com/12671903/221798261-8fb7ba28-3a1a-4269-9e00-a540f7febb1b.png)\r\n\r\nAfter,\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/12671903/221798298-1f3728b2-d7a9-41c9-a0f4-d80892a7c0f1.png)\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"c0d2b0f5cc7d5915f9f3894cdccfc7513a61cdc6"}}]}] BACKPORT--> Co-authored-by: Wafaa Nasr <[email protected]>
…n on the toast message (elastic#152313) ## Summary - Addresses elastic#151988 Before the fix, the number of missing connectors was always 1, even if the message says the invalid connectors are more ![image](https://user-images.githubusercontent.com/12671903/221798261-8fb7ba28-3a1a-4269-9e00-a540f7febb1b.png) After, ![image](https://user-images.githubusercontent.com/12671903/221798298-1f3728b2-d7a9-41c9-a0f4-d80892a7c0f1.png) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>
We are blocked to regress this issue as we are not able to export the rule with added actions and not connectors to import it back. we have reported this issue having ticket id : #153619 Please let us know if anything else is required from our side. |
We have validated this issue on 8.7.0 BC9 build and observed that issue looks like , It is Fixed ✔️ Please find the below Testing Details: Build info
Screen-Recording Rules.-.Kibana.Mozilla.Firefox.2023-03-28.17-08-20.mp4Hence We are closing this issue and marking it as QA Validated. |
Describe the bug:
When importing rule(s) with invalid connectors, the title of the toast message shows an incorrect number of connectors.
Steps to reproduce:
Expected behavior:
The toast title should show the correct number as the message.
Screenshots (if relevant):
![image](https://user-images.githubusercontent.com/12671903/220903587-b63b6d3d-3072-4e4e-92db-c0541a54eb95.png)
The text was updated successfully, but these errors were encountered: