[Synthetics] Remove Monitor Management tour. #151849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awahab07
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
reviewed
Feb 22, 2023
| @@ -19,5 +19,5 @@ export const useSyntheticsServiceAllowed = () => { | |||
|
|
|||
| // return useSelector(syntheticsServiceAllowedSelector); | |||
| // TODO Implement for Synthetics App | |||
| return { isAllowed: true, signupUrl: 'https://example.com', loading: false }; | |||
| return { isAllowed: true, signupUrl: undefined, loading: false }; | |||
There was a problem hiding this comment.
should this be hardcoded?
shahzad31
approved these changes
Feb 22, 2023
awahab07
force-pushed
the
151692-remove-Monitor-Management-tour
branch
from
805ca0a to
82fd949
Compare
…icsManagementTourDismiss"`) in tests.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 6, 2023
(cherry picked from commit 339cb64)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 6, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[Synthetics] Remove Monitor Management tour. (#151849)](#151849) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T14:06:25Z","message":"[Synthetics] Remove Monitor Management tour. (#151849)","sha":"339cb643d5ad2365f19fcb6e4fa7cbc0592001e8","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":151849,"url":"https://github.com/elastic/kibana/pull/151849","mergeCommit":{"message":"[Synthetics] Remove Monitor Management tour. (#151849)","sha":"339cb643d5ad2365f19fcb6e4fa7cbc0592001e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151849","number":151849,"mergeCommit":{"message":"[Synthetics] Remove Monitor Management tour. (#151849)","sha":"339cb643d5ad2365f19fcb6e4fa7cbc0592001e8"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151692
Summary
Removes the Monitor Management tour under Uptime.
It changes the e2e util method
loginToKibanadefined under x-pack/plugins/observability/e2e/utils.ts to exclude dismissing the removed tour. (Hence a review from from actionable-observability code owner is also required)