Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Skips failing cypress tests on main #151244

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[Security Solution] Skips failing cypress tests on main #151244

merged 1 commit into from
Feb 15, 2023

Conversation

spong
Copy link
Member

@spong spong commented Feb 15, 2023 •
edited by kibanamachine
Loading

Summary

Failing Security cypress tests on main. Skipping to unblock and @elastic/security-detections-response-rules will investigate and unskip.

Example failure: https://buildkite.com/elastic/kibana-pull-request/builds/108068#_

@spong spong added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.7.0 v8.8.0 labels Feb 15, 2023
@spong spong self-assigned this Feb 15, 2023
@spong spong marked this pull request as ready for review February 15, 2023 02:18
@spong spong requested review from a team as code owners February 15, 2023 02:18
@spong spong requested a review from banderror February 15, 2023 02:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong spong enabled auto-merge (squash) February 15, 2023 02:22
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@spong spong merged commit 40728e5 into elastic:main Feb 15, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 15, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 15, 2023
@spong
[Security Solution] Skips failing cypress tests on main (elastic#151244)
908f528 
## Summary

Failing Security cypress tests on main. Skipping to unblock and @elastic/security-detections-response-rules will investigate and unskip.

Example failure: https://buildkite.com/elastic/kibana-pull-request/builds/108068

(cherry picked from commit 40728e5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@spong spong deleted the skips-failing-cypress branch February 15, 2023 03:55
kibanamachine added a commit that referenced this pull request Feb 15, 2023
@kibanamachine @spong
[8.7] [Security Solution] Skips failing cypress tests on main (#151244)…
6b0f1ca 
… (#151247)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Skips failing cypress tests on main
(#151244)](#151244)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Garrett
Spong","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-15T03:48:59Z","message":"[Security
Solution] Skips failing cypress tests on main (#151244)\n\n##
Summary\r\n\r\nFailing Security cypress tests on main. Skipping to
unblock and @elastic/security-detections-response-rules will investigate
and unskip.\r\n\r\nExample failure:
https://buildkite.com/elastic/kibana-pull-request/builds/108068","sha":"40728e5c4854492996e8243734732e9d2b738460","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Rules","v8.7.0","v8.8.0"],"number":151244,"url":"https://github.com/elastic/kibana/pull/151244","mergeCommit":{"message":"[Security
Solution] Skips failing cypress tests on main (#151244)\n\n##
Summary\r\n\r\nFailing Security cypress tests on main. Skipping to
unblock and @elastic/security-detections-response-rules will investigate
and unskip.\r\n\r\nExample failure:
https://buildkite.com/elastic/kibana-pull-request/builds/108068","sha":"40728e5c4854492996e8243734732e9d2b738460"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151244","number":151244,"mergeCommit":{"message":"[Security
Solution] Skips failing cypress tests on main (#151244)\n\n##
Summary\r\n\r\nFailing Security cypress tests on main. Skipping to
unblock and @elastic/security-detections-response-rules will investigate
and unskip.\r\n\r\nExample failure:
https://buildkite.com/elastic/kibana-pull-request/builds/108068","sha":"40728e5c4854492996e8243734732e9d2b738460"}}]}]
BACKPORT-->

Co-authored-by: Garrett Spong <[email protected]>
@spong spong mentioned this pull request Feb 15, 2023
Closed
@maximpn maximpn mentioned this pull request Feb 22, 2023
Merged
1 task
justinkambic pushed a commit to justinkambic/kibana that referenced this pull request Feb 23, 2023
@spong @justinkambic
[Security Solution] Skips failing cypress tests on main (elastic#151244)
4a5fc33 
## Summary

Failing Security cypress tests on main. Skipping to unblock and @elastic/security-detections-response-rules will investigate and unskip.

Example failure: https://buildkite.com/elastic/kibana-pull-request/builds/108068
This was referenced Feb 24, 2023
Merged
Closed
maximpn added a commit that referenced this pull request Mar 1, 2023
@maximpn
[Security Solution] Re-enable a skipped url state e2e test (#152075)
5514f93 
**Relates to:** #151244

## Summary

Re-enable `Do not clears kql when navigating to a new page` url state e2e test.

## Details

Investigation has shown that #150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2023
@maximpn
[Security Solution] Re-enable a skipped url state e2e test (elastic#1…
09e7bd9 
…52075)

**Relates to:** elastic#151244

## Summary

Re-enable `Do not clears kql when navigating to a new page` url state e2e test.

## Details

Investigation has shown that elastic#150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.

(cherry picked from commit 5514f93)
@maximpn maximpn mentioned this pull request Mar 1, 2023
Closed
kibanamachine referenced this pull request Mar 1, 2023
@kibanamachine @maximpn
[8.7] [Security Solution] Re-enable a skipped url state e2e test (#15…
bf5e11f 
…2075) (#152423)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Re-enable a skipped url state e2e test
(#152075)](#152075)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-01T09:04:31Z","message":"[Security
Solution] Re-enable a skipped url state e2e test (#152075)\n\n**Relates
to:** https://github.com/elastic/kibana/pull/151244\r\n\r\n##
Summary\r\n\r\nRe-enable `Do not clears kql when navigating to a new
page` url state e2e test.\r\n\r\n## Details\r\n\r\nInvestigation has
shown that #150787 lead to
breaking this test. While it's not clear from the EUI upgrade PR itself
the cause lays under the hood. It fixes retrieving the state (current
KQL) from the url. As the test visits the page with the saved KQL which
is properly restored the next `kqlSearch()` command types the same KQL
in the query bar leading to invalid KQL and broken test eventually. For
some reason the KQL wasn't able to restore on this page while it's not
an issue anymore I removed `kqlSearch()` command and fixed the test this
way.","sha":"5514f93fc8ecccc007d1e25c9413df1c739feae9","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Rules","backport:prev-minor","v8.7.0","v8.8.0"],"number":152075,"url":"https://github.com/elastic/kibana/pull/152075","mergeCommit":{"message":"[Security
Solution] Re-enable a skipped url state e2e test (#152075)\n\n**Relates
to:** https://github.com/elastic/kibana/pull/151244\r\n\r\n##
Summary\r\n\r\nRe-enable `Do not clears kql when navigating to a new
page` url state e2e test.\r\n\r\n## Details\r\n\r\nInvestigation has
shown that #150787 lead to
breaking this test. While it's not clear from the EUI upgrade PR itself
the cause lays under the hood. It fixes retrieving the state (current
KQL) from the url. As the test visits the page with the saved KQL which
is properly restored the next `kqlSearch()` command types the same KQL
in the query bar leading to invalid KQL and broken test eventually. For
some reason the KQL wasn't able to restore on this page while it's not
an issue anymore I removed `kqlSearch()` command and fixed the test this
way.","sha":"5514f93fc8ecccc007d1e25c9413df1c739feae9"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152075","number":152075,"mergeCommit":{"message":"[Security
Solution] Re-enable a skipped url state e2e test (#152075)\n\n**Relates
to:** https://github.com/elastic/kibana/pull/151244\r\n\r\n##
Summary\r\n\r\nRe-enable `Do not clears kql when navigating to a new
page` url state e2e test.\r\n\r\n## Details\r\n\r\nInvestigation has
shown that #150787 lead to
breaking this test. While it's not clear from the EUI upgrade PR itself
the cause lays under the hood. It fixes retrieving the state (current
KQL) from the url. As the test visits the page with the saved KQL which
is properly restored the next `kqlSearch()` command types the same KQL
in the query bar leading to invalid KQL and broken test eventually. For
some reason the KQL wasn't able to restore on this page while it's not
an issue anymore I removed `kqlSearch()` command and fixed the test this
way.","sha":"5514f93fc8ecccc007d1e25c9413df1c739feae9"}}]}] BACKPORT-->

Co-authored-by: Maxim Palenov <[email protected]>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@maximpn @bmorelli25
[Security Solution] Re-enable a skipped url state e2e test (elastic#1…
18d0f78 
…52075)

**Relates to:** elastic#151244

## Summary

Re-enable `Do not clears kql when navigating to a new page` url state e2e test.

## Details

Investigation has shown that elastic#150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@dplumlee dplumlee dplumlee approved these changes

@banderror banderror Awaiting requested review from banderror banderror was automatically assigned from elastic/security-detection-rule-management

Assignees

@spong spong

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spong @elasticmachine @kibana-ci @kibanamachine @dplumlee @kqualters-elastic