Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7] [Security Solution] Re-enable a skipped url state e2e test (#152075) #152423

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

…52075)

**Relates to:** elastic#151244

## Summary

Re-enable `Do not clears kql when navigating to a new page` url state e2e test.

## Details

Investigation has shown that elastic#150787 lead to breaking this test. While it's not clear from the EUI upgrade PR itself the cause lays under the hood. It fixes retrieving the state (current KQL) from the url. As the test visits the page with the saved KQL which is properly restored the next `kqlSearch()` command types the same KQL in the query bar leading to invalid KQL and broken test eventually. For some reason the KQL wasn't able to restore on this page while it's not an issue anymore I removed `kqlSearch()` command and fixed the test this way.

(cherry picked from commit 5514f93)
@maximpn
Copy link
Contributor

maximpn commented Mar 1, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #4 / Add exception using data views from rule details Creates an exception item from alert actions overflow menu

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@kibanamachine kibanamachine merged commit bf5e11f into elastic:8.7 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants