Update Feature/dropdown add to body PR branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecate collapse module Consider removing it after transition module is deprecated as well. Fixes angular-ui#2871 Fixes angular-ui#3141 Closes angular-ui#1675
Allow use in conjunction with an ngModelController that has custom formatters and parsers to translate between $modelValue and $viewValue
Accept a number of milliseconds since 01.01.1970 as a valid value for `ng-model`: - change parseDate() to handle timestamp values - add the test to `datepicker.spec.js` Closes angular-ui#2345
index parameter is added to the slide directive. It is used to order the slides. Fixes angular-ui#488
Makes the datepicker respect dateFormat inside ng-if.
element with autofocus attribute when the modal is reopened Fixes angular-ui#2802
With this commit, the validity of a typeahead model is set to true if the model is set manually and the typehead directive is set to be non-editable. add test for setting model manually Fixes angular-ui#3318
- Fix scope.$apply call not working previously because scope was already destroyed. Use $rootScope instead. - Move $destroy call nearer to the dom removal. - Remove fallback timer (emulateTime param) Fixes angular-ui#2585 Fixes angular-ui#2674 Fixes angular-ui#2536 Fixes angular-ui#2790 Fixes angular-ui#3182 Closes angular-ui#2724
Add ability to use arrow keys to control time selection
Fix of the init-date attribute for the datepicker-popup. The init-date attribute, when set in a datepicker-popup element, is now added to the datepicker element and in the datepicker-popup scope, so the datepicker element can retrieve the attribute value.
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
- resolves property length of undefined error by checking value first angular-ui#2999 Fixes angular-ui#2999 Closes angular-ui#3178
Add support for ng-disabled for timepicker
In some cases, the increment function becomes invalid because the minutes are invalid. This change ensures that the value returned is a string
When typeahead-editable="false" and we select a perfect match from the results list, the $parsers aren't called, which results in the 'parse' error key not being reset. As with the 'editable' key, we should reset this once an item is selected because we know we have a valid model matching the view value. Closes angular-ui#3166
- Moved rounding logic into a formatter - Checking for number instead of checking if undefined - Using angular.isNumber for rounding logic - Using bitwise instead of modulo to check for decimel Fixes angular-ui#3413 Closes angular-ui#3415
Optimized opening of modals by causing one digest loop less: The modalBackdrop directive now schedules switching its animate flag using a $timeout which does not cause a digest loop. If we assume modalBackdrop is always followed by a modalWindow directive, then we are guaranteed a digest loop by modalWindow's $timeout, which will happen after modalBackdrop's $timeout.
This reverts commit 7940fd0. Breaks a test.
This documentation was missing ng-change event.
Add details that ng-change can be used alongside ng-model
After I upgraded from 0.10.0 to 0.11.0 I needed to add the dropdown directive to my button dropdowns. This is not documented in the breakting changes. The bootstrap documentation only mentions the dropdown class only in the [dropdowns section](http://getbootstrap.com/components/#dropdowns), but not in the [btn-dropdowns section](http://getbootstrap.com/components/#btn-dropdowns).
day equal to 0 is not allowed
Fixes use of initDate across datepickerConfig, datepickerOptions, and the initDate attribute
Added optional `shortcut-propagation` attribute for optionally allowing the keydown event to propagate upwards
Useful for retrieving test coverage statistics.
Resolve this TODO since we're requiring 1.3 where the fix for `.one` has been merged.
…ndencies chore(build): upgrade devDependencies
Make $apply first check if $rootScope is in $digest cycle before executing Closes angular-ui#3274
Note: Move backdropClass logic into compile function because otherwise modifying classes in the compile function is broken when using an interpolated class attribute. Fixes angular-ui#1007 Closes angular-ui#2725
Typo was made in 5e661d4
make it useable in xhtml documents
- Avoid maintaining / copying AngularJS source code on our repo. - Ensures that Travis checks out the latest Angular version and tests against it.
Restructured README, added references to new Wiki pages and updated content Closes angular-ui#3453
Conflicts: src/dropdown/docs/readme.md
andyperlitch
force-pushed
the
feature/dropdown-add-to-body
branch
2 times, most recently
from
00ed4e8 to
6247783
Compare
|
The only issue I could not fix is removing the commit created from me merging master: 9a5bd0e. Other than that it should be good to go. |
|
So logistically, I guess if I were to update my branch before merging this then I would have to deal with the same merge conflict, but it makes it harder to see your actual changes. I suppose I'll just merge this and then the pull request with angular-ui should be more clear. |
rysilva
added a commit
that referenced
this pull request
Apr 1, 2015
Update Feature/dropdown add to body PR branch
|
It looks like @wesleycho wants these commits to be squashed into a single commit... |
|
I should be able to do it later. On Wed, Apr 1, 2015 at 12:41 PM, Andy Perlitch [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
64 of the commits in this PR are just from merging the current master (there was a conflict in the dropdown README because another feature was added).
The last one is what I did: fixed the tests so that they properly clean up the element in the test launcher and prove that "garbage collection" is in fact occurring.