Modal's close animation's duration is hardcoded (!)

[OnkelTem]

Closing modals now laggy, as 300 and 150 more ms are hardcoded. I'm not sure why this is done so, as from the one hand, someone like doesn't need any lags when closing modals, and from the other hand - someone may want some animation which lasts for more then 300 + 150 ms. As CSS animation and JS are not correlated directly, this should be configurable. So I vote for moving this into options.

[OnkelTem]

Here is a patch which adds such configuration:

diff --git a/src/modal/modal.js b/src/modal/modal.js
index c753b5f..dd5cb83 100644
--- a/src/modal/modal.js
+++ b/src/modal/modal.js
@@ -144,18 +144,18 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])
         openedWindows.remove(modalInstance);

         //remove window DOM element
-        removeAfterAnimate(modalWindow.modalDomEl, modalWindow.modalScope, 300, function() {
+        removeAfterAnimate(modalWindow.modalDomEl, modalWindow.modalScope, modalWindow.windowCloseDuration, function() {
           modalWindow.modalScope.$destroy();
           body.toggleClass(OPENED_MODAL_CLASS, openedWindows.length() > 0);
-          checkRemoveBackdrop();
+          checkRemoveBackdrop(modalWindow.backdropCloseDuration);
         });
       }

-      function checkRemoveBackdrop() {
+      function checkRemoveBackdrop(closeDuration) {
           //remove backdrop if no longer needed
           if (backdropDomEl && backdropIndex() == -1) {
             var backdropScopeRef = backdropScope;
-            removeAfterAnimate(backdropDomEl, backdropScope, 150, function () {
+            removeAfterAnimate(backdropDomEl, backdropScope, closeDuration, function () {
               backdropScopeRef.$destroy();
               backdropScopeRef = null;
             });
@@ -216,6 +216,8 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])
           deferred: modal.deferred,
           modalScope: modal.scope,
           backdrop: modal.backdrop,
+          backdropCloseDuration: modal.backdropCloseDuration,
+          windowCloseDuration: modal.windowCloseDuration,
           keyboard: modal.keyboard
         });

@@ -280,7 +282,9 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])
     var $modalProvider = {
       options: {
         backdrop: true, //can be also false or 'static'
-        keyboard: true
+        keyboard: true,
+        backdropCloseDuration: 150,
+        windowCloseDuration: 300
       },
       $get: ['$injector', '$rootScope', '$q', '$http', '$templateCache', '$controller', '$modalStack',
         function ($injector, $rootScope, $q, $http, $templateCache, $controller, $modalStack) {
@@ -359,6 +363,8 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])
                 deferred: modalResultDeferred,
                 content: tplAndVars[0],
                 backdrop: modalOptions.backdrop,
+                backdropCloseDuration: modalOptions.backdropCloseDuration,
+                windowCloseDuration: modalOptions.windowCloseDuration,
                 keyboard: modalOptions.keyboard,
                 windowClass: modalOptions.windowClass,
                 windowTemplateUrl: modalOptions.windowTemplateUrl,

[chrisirhc]

This will be resolved via #2724 .