Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Modal backdrop doesn't animate out #2790

Closed
doranen opened this issue Oct 6, 2014 · 3 comments
Closed

Modal backdrop doesn't animate out #2790

doranen opened this issue Oct 6, 2014 · 3 comments
Labels
component: modal type: bug
Milestone
0.13.0 (AngularJS...

Comments

@doranen
Copy link

doranen commented Oct 6, 2014

angular-ui-bootstrap v0.11.2
angular v1.2.24
bootstrap v3.1.1

UA: Chrome 37.0.2062.124

When closing a modal and in response, the backdrop, the backdrop doesn't fade out like it's supposed to, instead just gets removed at the end of the animation timeout. The modal itself does fade out.

You can see this in the examples on the main GitHub page as well.

Looks like in the checkRemoveBackdrop() -> removeAfterAnimate() call, the scope.animate=false; statement is executed outside of the scope digest phase, for the backdrop ONLY.
@doranen doranen mentioned this issue Oct 6, 2014
Closed
@pisaacs
Copy link

pisaacs commented Oct 12, 2014

Have exactly the same issue!

@pisaacs
Copy link

pisaacs commented Oct 12, 2014

Could this be the related issue: twbs/bootstrap#14782

@chrisirhc
Copy link
Contributor

Might be resolved via #2724 .

chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Oct 20, 2014
@chrisirhc
refactor(modal): use ngAnimate for animation
cd30758 
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Mar 19, 2015
@chrisirhc
refactor(modal): use ngAnimate for animation
5d85752 
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Mar 23, 2015
@chrisirhc
refactor(modal): use ngAnimate for animation
833fffa 
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
Closes angular-ui#2724
@karianna karianna added this to the 0.13.0 milestone Mar 23, 2015
ayakovlevgh pushed a commit to ayakovlevgh/bootstrap that referenced this issue Mar 24, 2015
@chrisirhc @ayakovlevgh
refactor(modal): use ngAnimate for animation
17b526b 
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
Closes angular-ui#2724
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: modal type: bug
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

No branches or pull requests
5 participants
@chrisirhc @karianna @pkozlowski-opensource @pisaacs @doranen