Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Modal backdrop does not fade out on close #3182

Closed
ezzatron opened this issue Jan 13, 2015 · 9 comments
Closed

Modal backdrop does not fade out on close #3182

ezzatron opened this issue Jan 13, 2015 · 9 comments

Comments

@ezzatron
Copy link

See http://getbootstrap.com/javascript/#modals for expected close animation. Whereas with http://angular-ui.github.io/bootstrap/#/modal, the modal itself animates on close, but the backdrop simply disappears suddenly.

@karianna
Copy link
Contributor

Hi @ezzatron - Are you able to provide a plunkr and the version(s) of Angular/Bootstrap and UI you are using?

@ezzatron
Copy link
Author

I don't have it in front of me right now, but both bootstrap and angular-ui/bootstrap are the latest stable versions available on bower.

I can put together a plunkr tomorrow if it's required, but the two links I pasted exhibit the behaviors I'm referring to.

To demonstrate the expected behavior:

To demonstrate the actual behavior:

It probably sounds like a minor thing, but since the angular-ui backdrop does fade in, it's quite jarring when doesn't fade out.

Does that help, or do you still need a plunkr?

@karianna
Copy link
Contributor

That should be enough, thanks!

@jackrk
Copy link

jackrk commented Mar 11, 2015

+1

AlicanC added a commit to AlicanC/bootstrap that referenced this issue Mar 17, 2015
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Mar 19, 2015
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Mar 23, 2015
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
Closes angular-ui#2724
@karianna karianna removed the PRs plz! label Mar 23, 2015
@karianna karianna added this to the 0.13.0 milestone Mar 23, 2015
ayakovlevgh pushed a commit to ayakovlevgh/bootstrap that referenced this issue Mar 24, 2015
- Fix scope.$apply call not working previously because scope was already
  destroyed. Use $rootScope instead.
- Move $destroy call nearer to the dom removal.
- Remove fallback timer (emulateTime param)

Fixes angular-ui#2585
Fixes angular-ui#2674
Fixes angular-ui#2536
Fixes angular-ui#2790
Fixes angular-ui#3182
Closes angular-ui#2724
@dyatchenko
Copy link

I found out that the problem is in 0.13.0 version. 0.12.0 works fine even with AngularJS 1.4.1.

@telminov
Copy link

dyatchenko, +1

2 similar comments
@olavocneto
Copy link

dyatchenko, +1

@vicky-gonsalves
Copy link

dyatchenko, +1

@SuNiLThAkUr360
Copy link

Modal backdrop does not fade out on close help me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants