This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Collapse fails to update its height when toggling collapse model #2836
Comments
I have the same issue. Thank you |
Will be fixed via #1444 |
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 23, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 23, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 23, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
ayakovlevgh
pushed a commit
to ayakovlevgh/bootstrap
that referenced
this issue
Mar 24, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have a simple collapse.
Here is the controller:
Plunker: http://plnkr.co/edit/ZYE3A4gt2I3JZgOEXxhf?p=preview
When I toggle the isCollapsed from true to false and add more items to the list, the collapse height is not updated.
The problem is when toggling isCollapsed from true to false, if the list has no item (height: 0px), the collapse will not set the height attribute to auto. Thus, it will make the collapse fail to update its height.
It does not happen when isCollapsed is initialized with false value (still with empty list), since the height attribute is auto in this case.
The text was updated successfully, but these errors were encountered: