This repository was archived by the owner on May 29, 2019. It is now read-only.
refactor(collapse): use ngAnimate #1274
Comments
|
This is turning out to be extremely difficult to do with ngAnimate, and might actually warrant some patches to change how ngAnimate works .v. |
|
@caitp those were mine findings as well. The code I've ended up was the very similar to the one we've got inside the collapse directive so when I was playing with it, $animate wasn't helping much. It was even worse than with $transition as I had to detect transition end "by hand". What I'm trying to focus on right now is to get BS3 support out of the doors, I think that most of the issues are opened and labeled here: https://github.com/angular-ui/bootstrap/issues?labels=Bootstrap+3.0&page=1&state=open So my plan was to release BS3 with AngularJS 1.0.8 and as soon as this is done work on AngularJS 1.2 support. But before this can happen there are still few animation-related issues that need to be fixed on the AngularJS side. |
|
Yeah that's what I'm thinking, maybe in a few weeks or months |
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Dec 21, 2013
- Animations are not opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Dec 21, 2013
- Animations are not opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Dec 21, 2013
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Jan 14, 2014
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Feb 19, 2014
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Feb 19, 2014
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
May 29, 2014
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Closes angular-ui#1274 Conflicts: src/collapse/test/collapse.spec.js
|
Any movement on this? |
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 23, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
chrisirhc
added a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this issue
Mar 23, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
ayakovlevgh
pushed a commit
to ayakovlevgh/bootstrap
that referenced
this issue
Mar 24, 2015
- Animations are now opt-in, include ngAnimate to see collapse animations - ngAnimate handles initial state and doesn't animate if first reflow hasn't occurred. angular/angular.js@cc58460 - Tests may need more work. Right now they test for 'in' class. Fixes angular-ui#1774 Fixes angular-ui#2821 Fixes angular-ui#2836 Closes angular-ui#1274 Closes angular-ui#1444
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
My patch is a WIP, I'll try and push it here tomorrow.
There are some advantages to ngAnimate, such as not needing the
emulateEndTransition()or whatever it was called, for transition-less browsers.So yeah, I think it will work out nicely (once it's working at all, I mean).
The text was updated successfully, but these errors were encountered: