This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(dropdown): apend-to-body option for dropdown menu #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/dropdown/docs/readme.md
|
Just noticed this, I updated my PR with your code, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some testing concerns and merge conflicts in PR #3411.
I am opening this in the interest of convenience for @wesleycho and @rysilva. The latter authored this feature and opened #3411, quoted here:
If @rysilva can update his pull request with these fixes before this PR gets reviewed, I'll close it. I have opened a pull request for him to easily do so.
I am not trying to take credit for @rysilva 's great work, I just want to see this merged!