Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-iac-334) Remove code specific to unsupported OSs #1024

Merged
merged 1 commit into from
Mar 24, 2022
Merged

(GH-iac-334) Remove code specific to unsupported OSs #1024

merged 1 commit into from
Mar 24, 2022

Conversation

david22swan
Copy link
Member

Code removed includes ubuntu 16.04 + 14.04 and Debian 7 + 8

@david22swan david22swan requested a review from a team as a code owner March 24, 2022 14:32
@david22swan
Copy link
Member Author

Unsure as to whether this should be backwards incompatible as while functional code has been removed, the amount removed is rather small.

@david22swan david22swan reopened this Mar 24, 2022
@puppet-community-rangefinder
Copy link

apt::params is a class

that may have no external impact to Forge modules.

apt::source is a type

Breaking changes to this file WILL impact these 338 modules (exact match):
Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan reopened this Mar 24, 2022
@puppet-community-rangefinder
Copy link

apt::params is a class

that may have no external impact to Forge modules.

apt::source is a type

Breaking changes to this file WILL impact these 338 modules (exact match):
Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan reopened this Mar 24, 2022
@puppet-community-rangefinder
Copy link

apt::params is a class

that may have no external impact to Forge modules.

apt::source is a type

Breaking changes to this file WILL impact these 338 modules (exact match):
Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan
(GH-iac-334) Remove code specific to unsupported OSs
1192618 
Code removed includes ubuntu 16.04 + 14.04 and Debian 7 + 8
@david22swan david22swan force-pushed the GH-iac-334/main/remove_compatible_code branch from e61c066 to 1192618 Compare March 24, 2022 16:35
@david22swan david22swan reopened this Mar 24, 2022
@puppet-community-rangefinder
Copy link

apt::params is a class

that may have no external impact to Forge modules.

apt::source is a type

Breaking changes to this file WILL impact these 338 modules (exact match):
Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan david22swan reopened this Mar 24, 2022
@puppet-community-rangefinder
Copy link

apt::params is a class

that may have no external impact to Forge modules.

apt::source is a type

Breaking changes to this file WILL impact these 338 modules (exact match):
Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan
Copy link
Member Author

@bastelfreak Here's the compatibility removal I promised if you want to give it a review :)

@david22swan david22swan mentioned this pull request Mar 24, 2022
Merged
@LukasAud LukasAud merged commit 32eec3b into puppetlabs:main Mar 24, 2022
@david22swan david22swan deleted the GH-iac-334/main/remove_compatible_code branch March 24, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david22swan @bastelfreak @LukasAud