[feature/sandboxing branch]Add initial doc for plugin sandboxing #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1404) This commit adds a method that can be used to provide a custom TranslogDeletionPolicy from within plugins that implement the EnginePlugin interface. This enables plugins to provide a custom deletion policy with the current limitation that only one plugin can override the policy. An exception will be thrown if more than one plugin overrides the policy. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Kyle Davis <[email protected]>
Signed-off-by: Vacha <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
When creating the second instance of an InternalEngine using the same translog config of the default InternalEngine instance, the second instance will attempt to delete all the existing translog files. I found a deterministic test failure when running with the seed `E3E6AAD95ABD299B`. As opposed to creating a second engine instance with a different translog location, just close the first one before creating the second. Signed-off-by: Andrew Ross <[email protected]>
This commit upgrades to the latest release of lucene 8.10 Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: CEHENKLE <[email protected]>
…n lease. (#1416) The settings and the corresponding logic for translog pruning by retention lease which were added as part of #1100 have been deprecated. This commit removes those deprecated code in favor of an extension point for providing a custom TranslogDeletionPolicy. Signed-off-by: Rabi Panda <[email protected]>
This commit upgrades the BWC 1.2 lucene dependency to version 8.10.1 Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
As part of the commit 2ebd0e0, we added a new method to the EnginePlugin to provide a custom TranslogDeletionPolicy. This commit makes minTranslogGenRequired method abstract in this class for implementation by child classes. The default implementation is provided by DefaultTranslogDeletionPolicy. Signed-off-by: Rabi Panda <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
This change updates the logic in RunTask to use deterministic port values for all nodes rather than just the first node in a cluster. The local address of the first node is also used as the seed_hosts value to allow the cluster to form correctly. The seed_hosts setting is also allow-listed as an overrideable value. Signed-off-by: Kartik Ganesh <[email protected]>
Signed-off-by: Vacha <[email protected]>
* Enabling spotless, disabling checkstyle on below modules :plugins:mapper-annotated-text :plugins:mapper-murmur3 :plugins:mapper-size :plugins:repository-azure :plugins:repository-gcs :plugins:repository-hdfs :plugins:repository-s3 :plugins:store-smb :plugins:transport-nio :qa:die-with-dignity Signed-off-by: Himanshu Setia <[email protected]> * Enabling spotless for more plugins Signed-off-by: Himanshu Setia <[email protected]> * Fixing error in merge conflict Signed-off-by: Himanshu Setia <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Vacha <[email protected]>
… assignment (#1403) Signed-off-by: Xue Zhou <[email protected]>
* Added logic to allow {dot} files on startup
Signed-off-by: Ryan Bogan <[email protected]>
* Ensures that only plugin directories are returned by findPluginDirs()
Signed-off-by: Ryan Bogan <[email protected]>
* Prevents . files from being returned as plugins
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
I observed a [test failure][1] that I believe was caused by the fact that an OpenSearch server happened to be running at localhost:9200 when these unit tests were executed. The code under test has logic to try to connect to localhost:9200 and then fall back to defaults if that port is not open. The tests expect these defaults and will fail if different data is returned. The change here is to use a non-default port to make it very unlikely that a real instance will be running at the non-default port. I don't know why an OpenSearch service happened to be running during the linked test failure, but I think making these unit tests more independent and isolated is helpful no matter the underlying cause in this case. [1]: https://fork-jenkins.searchservices.aws.dev/job/OpenSearch_CI/job/PR_Checks/job/Gradle_Check/975/artifact/gradle_check_975.log/*view*/ Signed-off-by: Andrew Ross <[email protected]>
* Made changes. Signed-off-by: Megha Sai Kavikondala <[email protected]> * Signed-off-by: Megha Sai Kavikondala <[email protected]> Changes made by deleting the TestSettingsIT file and adding new lines in FullClusterRestartSettingsUpgradeIT.java
|
start gradle check |
|
Looks like its because of changes missing in feature branch vs main. |
I observed a test failure with the message 'Attempted to append to non-started appender mock' from an assertion in `OpenSearchTestCase::after`. I believe this indicates that a MockLogAppender (which is named "mock") was added as an appender to the static logging context and some other test in the same JVM happened to cause a logging statement to hit that appender and cause an error, which then caused an unrelated test to fail (because they share static state with the logger). Almost all usages of MockLogAppender start it immediately after creation. I found a few that did not and fixed those. I also made a static helper in MockLogAppender to start it upon creation. Signed-off-by: Andrew Ross <[email protected]>
The 1.1 release notes are missing a set of commits. This updates the release notes to the commit specified in our relase 15e9f13. Signed-off-by: Marc Handalian <[email protected]>
…ndex and reindex requests (#1533) Signed-off-by: Jan Baudisch <[email protected]> Co-authored-by: Jan Baudisch <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
…#1568) * Signed-off-by: Megha Sai Kavikondala <[email protected]> Changes related to Informative error messages. * Signed-off-by: Megha Sai Kavikondala <[email protected]> Spotless changes * Signed-off-by: Megha Sai Kavikondala <[email protected]> naming and message changes. Signed-off-by: Megha Sai Kavikondala <[email protected]> * Signed-off-by: Megha Sai Kavikondala <[email protected]> Deleting the log message.
…in repository-hdfs (#1603) Signed-off-by: Vacha <[email protected]>
* Adding Github action for auto backport PR creation Signed-off-by: Vacha <[email protected]> * Adding details to DEVELOPER_GUIDE Signed-off-by: Vacha <[email protected]>
* Rename field_masking_span to span_field_masking Signed-off-by: Xue Zhou <[email protected]> * Update SearchModuleTests.java Signed-off-by: Xue Zhou <[email protected]> * Rename field_masking_span to span_field_masking Signed-off-by: Xue Zhou <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
…publishing (#1630) Signed-off-by: Andriy Redko <[email protected]>
… into feature/sandboxing Signed-off-by: Sarat Vemulapalli <[email protected]>
|
❌ Gradle Wrapper Validation failure d5de152d6cfd0911deb7ae18c2bd23165de32bc0 :alert: Gradle Wrapper integrity has been altered |
|
✅ Gradle Wrapper Validation success 4749793 |
|
start gradle check |
|
✅ Gradle Precommit success d5de152d6cfd0911deb7ae18c2bd23165de32bc0 |
|
✅ Gradle Precommit success 4749793 |
|
❌ Gradle Check failure d5de152d6cfd0911deb7ae18c2bd23165de32bc0 |
|
start gradle check |
|
@owaiskazi19 DCO is failing because the number of commits is high and out of bounds for the check. |
|
Cancelling this and creating a new feature branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding initial doc for plugin sandboxing.
Issues Resolved
Part of #1422
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.