Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spotless and exclude checkstyle on rest-api-spec module #1462

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Oct 28, 2021

Signed-off-by: Owais Kazi [email protected]

Description

Applied Spotless to rest-api-spec module and excluded it from CheckStyle.

Issues Resolved

Part of #1362 and #974

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 5e7303e97da4f4c717eebcebabd087e70209c0e6

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5e7303e97da4f4c717eebcebabd087e70209c0e6
Log 863

Reports 863

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 5e7303e97da4f4c717eebcebabd087e70209c0e6

@tlfeng
Copy link
Collaborator

tlfeng commented Oct 28, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5e7303e97da4f4c717eebcebabd087e70209c0e6
Log 870

Reports 870

@owaiskazi19 owaiskazi19 force-pushed the run-spotless-rest-api-spec branch from 5e7303e to 80a0c19 Compare October 29, 2021 18:01
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 80a0c19

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 80a0c19

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 80a0c19
Log 890

Reports 890

@saratvemulapalli saratvemulapalli merged commit f4bdb94 into opensearch-project:main Oct 29, 2021
@saratvemulapalli saratvemulapalli added the pending backport Identifies an issue or PR that still needs to be backported label Oct 29, 2021
owaiskazi19 added a commit to owaiskazi19/OpenSearch that referenced this pull request Oct 29, 2021
@owaiskazi19 owaiskazi19 removed the pending backport Identifies an issue or PR that still needs to be backported label Nov 1, 2021
@owaiskazi19 owaiskazi19 added the v1.2.0 Issues related to version 1.2.0 label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.2.0 Issues related to version 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants