Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle 7. More reliable tasks dependencies for Maven plugins publishing #1630

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 30, 2021

Signed-off-by: Andriy Redko [email protected]

Description

More reliable fix for #1624 to cover all plugin-related tasks.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner November 30, 2021 15:26
dependsOn("generatePomFileForNebulaPublication")
}
tasks.named("publishPluginMavenPublicationToMavenLocal").configure {
tasks.matching { it.name.contains("PluginMaven") }*.configure {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock more robust fix comparing to #1624 to cover all plugin publishing tasks

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success d86bbf473be9c37bf099abcb45bc55bc043fd0a0

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure d86bbf473be9c37bf099abcb45bc55bc043fd0a0
Log 1666

@reta reta force-pushed the update.plugin.publish branch from d86bbf4 to 81166c5 Compare November 30, 2021 15:31
@reta reta changed the title More reliable tasks dependencies for Maven plugins publishing Support Gradle 7. More reliable tasks dependencies for Maven plugins publishing Nov 30, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 81166c5

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 81166c5

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d86bbf473be9c37bf099abcb45bc55bc043fd0a0
Log 1272

Reports 1272

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 81166c5
Log 1273

Reports 1273

@dblock dblock merged commit 30c31f9 into opensearch-project:main Nov 30, 2021
@dblock dblock added backport PRs or issues specific to backporting features or enhancments backport 1.x labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backport 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants