Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle 7. Fixing publishing to Maven Local for plugins #1624

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 30, 2021

Signed-off-by: Andriy Redko [email protected]

Description

Fixing publishing to Maven Local for plugins

> Task :build-tools:publishPluginMavenPublicationToMavenLocal
Execution optimizations have been disabled for task ':build-tools:publishPluginMavenPublicationToMavenLocal' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/tmp/tmptny3_u2s/OpenSearch/buildSrc/build/distributions/build-tools-2.0.0-SNAPSHOT.pom'. Reason: Task ':build-tools:publishPluginMavenPublicationToMavenLocal' uses this output of task ':build-tools:generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Gradle detected a problem with the following location: '/tmp/tmptny3_u2s/OpenSearch/buildSrc/build/distributions/build-tools-2.0.0-SNAPSHOT.pom'. Reason: Task ':build-tools:publishPluginMavenPublicationToMavenLocal' uses this output of task ':build-tools:generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency for more details about this problem. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Multiple publications with coordinates 'org.opensearch.gradle:build-tools:2.0.0-SNAPSHOT' are published to repository 'mavenLocal'. The publications will overwrite each other!

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner November 30, 2021 02:11
@reta
Copy link
Collaborator Author

reta commented Nov 30, 2021

@dblock should fix it, sorry for that

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 8b17ae627cd5b4fb6203fd188e8c09180885b8b9

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 8b17ae627cd5b4fb6203fd188e8c09180885b8b9

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8b17ae627cd5b4fb6203fd188e8c09180885b8b9
Log 1264

Reports 1264

@reta reta force-pushed the fix.plugin.publish branch from 8b17ae6 to 1c5e961 Compare November 30, 2021 02:39
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 1c5e961

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 1c5e961

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 1c5e961
Log 1266

Reports 1266

@dblock dblock added backport PRs or issues specific to backporting features or enhancments backport 1.x labels Nov 30, 2021
@dblock dblock merged commit 231c29f into opensearch-project:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backport 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants