Fixing support for a multi-node cluster via "gradle run" #1455
Conversation
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 100adf67d067e06420721b8523425be7ba359e5e |
|
✅ DCO Check Passed 100adf67d067e06420721b8523425be7ba359e5e |
|
✅ Gradle Precommit success 100adf67d067e06420721b8523425be7ba359e5e |
|
start gradle check |
|
❌ Gradle Check failure 100adf67d067e06420721b8523425be7ba359e5e |
|
start gradle check |
|
❌ Gradle Check failure 100adf67d067e06420721b8523425be7ba359e5e |
|
✅ Gradle Wrapper Validation success 6906f42a942eff549550fadf16117d4bd90c5a9d |
|
✅ Gradle Wrapper Validation success 14bb5cdbb7f2f7aadcabff67a906f512076ea49e |
|
✅ Gradle Precommit success 6906f42a942eff549550fadf16117d4bd90c5a9d |
|
✅ Gradle Wrapper Validation success d21b1dafc3725684662d77efc1da74f60eb202a0 |
kartg
changed the title
|
✅ Gradle Precommit success 14bb5cdbb7f2f7aadcabff67a906f512076ea49e |
|
✅ Gradle Precommit success d21b1dafc3725684662d77efc1da74f60eb202a0 |
|
❌ Gradle Check failure 6906f42a942eff549550fadf16117d4bd90c5a9d |
|
❌ Gradle Check failure 14bb5cdbb7f2f7aadcabff67a906f512076ea49e |
|
❌ Gradle Check failure d21b1dafc3725684662d77efc1da74f60eb202a0 |
kartg
force-pushed
the
localMultiNode
branch
2 times, most recently
from
996982e to
c45eb38
Compare
|
❌ Gradle Wrapper Validation failure 996982e83e5f9c6b168718b0a490f1120eb96bff :alert: Gradle Wrapper integrity has been altered |
|
❌ Gradle Check failure 996982e83e5f9c6b168718b0a490f1120eb96bff |
|
❌ Gradle Precommit failure 996982e83e5f9c6b168718b0a490f1120eb96bff |
|
✅ Gradle Wrapper Validation success c45eb387091ce97f3303acb6a320cf9c6f35d7ff |
|
✅ Gradle Precommit success c45eb387091ce97f3303acb6a320cf9c6f35d7ff |
|
❌ Gradle Check failure c45eb387091ce97f3303acb6a320cf9c6f35d7ff |
|
✅ Gradle Wrapper Validation success 6b6d46e9ca34f1f0dea9000fb530f0e040a9dcd3 |
|
Seems like the Gradle check failure is unrelated to this code change. The BWC tests are failing for v1.2 and this is tied to the Lucene 8.10.1 upgrade. The fix is tracked in this PR - #1460 |
|
✅ Gradle Precommit success 6b6d46e9ca34f1f0dea9000fb530f0e040a9dcd3 |
|
❌ Gradle Check failure 6b6d46e9ca34f1f0dea9000fb530f0e040a9dcd3 |
This change updates the logic in RunTask to use deterministic port values for all nodes rather than just the first node in a cluster. The local address of the first node is also used as the seed_hosts value to allow the cluster to form correctly. The seed_hosts setting is also allow-listed as an overrideable value. Signed-off-by: Kartik Ganesh <[email protected]>
|
✅ Gradle Wrapper Validation success 73ce7bb |
|
✅ Gradle Precommit success 73ce7bb |
|
start gradle check |
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchCluster.java
Show resolved
Hide resolved
Description
This change updates the logic in RunTask to use deterministic port values for all nodes rather than just the first node in a cluster. The local address of the first node is also used as the seed_hosts value to allow the cluster to form correctly.
Signed-off-by: Kartik Ganesh [email protected]
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.