Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding spotless support for subprojects under :test #1464

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Adding spotless support for subprojects under :test #1464

merged 5 commits into from
Oct 29, 2021

Conversation

saratvemulapalli
Copy link
Member

Signed-off-by: Sarat Vemulapalli [email protected]

Description

Adding support for spotless and removing checkstyle for :test

Issues Resolved

Part of #974

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f1a2948

@saratvemulapalli
Copy link
Member Author

start gradle check

owaiskazi19
owaiskazi19 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes

@peterzhuamazon
Copy link
Member

Seems stuck in Jenkins not due to Jenkins workflow, but the EC2 instance is very slow and unresponse.
If not working we will consider running again.

@peterzhuamazon
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f1a2948
Log 862

Reports 862

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f1a2948

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 1a1a8664e96de9ad837c6065c11a8e736dea5830

@saratvemulapalli
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success a94d066

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f1a2948
Log 869

Reports 869

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 1a1a8664e96de9ad837c6065c11a8e736dea5830

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success a94d066

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1a1a8664e96de9ad837c6065c11a8e736dea5830
Log 871

Reports 871

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a94d066
Log 872

Reports 872

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure d3d93befb58fe6d4131c87de647520ef6a670183

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 89ca3cf

@saratvemulapalli
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 89ca3cf

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 89ca3cf
Log 885

Reports 885

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 89ca3cf
Log 886

Reports 886

@saratvemulapalli
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 85d1c22

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 85d1c22

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4a3de572fbb362082e60a1592ddf920686512fa3
Log 894

Reports 894

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 85d1c22
Log 895

Reports 895

@saratvemulapalli
Merge branch 'main' into main
67f3abd 
Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 67f3abd

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 67f3abd

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 54056c0e4cf5ad42106d80ff1aedeade0c937649
Log 899

Reports 899

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 67f3abd
Log 900

Reports 900

@saratvemulapalli saratvemulapalli merged commit f6115ae into opensearch-project:main Oct 29, 2021
@saratvemulapalli saratvemulapalli added the pending backport Identifies an issue or PR that still needs to be backported label Oct 29, 2021
@saratvemulapalli saratvemulapalli mentioned this pull request Nov 1, 2021
Merged
5 tasks
@saratvemulapalli saratvemulapalli added v1.2.0 Issues related to version 1.2.0 and removed pending backport Identifies an issue or PR that still needs to be backported labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@setiah setiah setiah approved these changes

Assignees
No one assigned
Labels
v1.2.0 Issues related to version 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saratvemulapalli @opensearch-ci-bot @peterzhuamazon @owaiskazi19 @setiah