Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gradle 7 #1609

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Support Gradle 7 #1609

merged 1 commit into from
Nov 29, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 24, 2021

Signed-off-by: Andriy Redko [email protected]

Description

Support Gradle 7

Issues Resolved

Closes #1246

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 0eafe098436eba7feadce908516cb830a2acf270

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0eafe098436eba7feadce908516cb830a2acf270
Log 1207

Reports 1207

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 0eafe098436eba7feadce908516cb830a2acf270
Log 1627

@dblock dblock mentioned this pull request Nov 24, 2021
Closed
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d6fefcb0959494b7d2e23bb65a6e2e958f2375b0
Log 1210

Reports 1210

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure d6fefcb0959494b7d2e23bb65a6e2e958f2375b0

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure d6fefcb0959494b7d2e23bb65a6e2e958f2375b0
Log 1629

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 22e3596b6adfafbbf6f2bbc6b299da3a4fa3db95

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 22e3596b6adfafbbf6f2bbc6b299da3a4fa3db95
Log 1630

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 22e3596b6adfafbbf6f2bbc6b299da3a4fa3db95
Log 1211

Reports 1211

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 265a0e8e3f36069bb96d7f67aa6fc0483c15ea6c

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 265a0e8e3f36069bb96d7f67aa6fc0483c15ea6c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 265a0e8e3f36069bb96d7f67aa6fc0483c15ea6c
Log 1216

Reports 1216

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 797de5f2000144d0b09ba9c8b61d6727d9a74392

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 797de5f2000144d0b09ba9c8b61d6727d9a74392
Log 1632

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 797de5f2000144d0b09ba9c8b61d6727d9a74392
Log 1217

Reports 1217

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure ff11f776dcf0e242e13b9f6c05ccda488aebbee2

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure ff11f776dcf0e242e13b9f6c05ccda488aebbee2
Log 1633

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ff11f776dcf0e242e13b9f6c05ccda488aebbee2
Log 1218

Reports 1218

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure 393e1ed1862726b4dd783096315464edc319d532

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 393e1ed1862726b4dd783096315464edc319d532

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 393e1ed1862726b4dd783096315464edc319d532
Log 1219

Reports 1219

@dblock
Copy link
Member

dblock commented Nov 29, 2021 •
edited
Loading

@dblock Thanks a lot for the hint, updated Gradle Wrapper bits as well

FYI I opened an issue in that private repo to move the Gradle_Wrapper_Validation workflow into OSS

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 7c257d8
Log 1256

Reports 1256

@dblock dblock merged commit 8bf6fa6 into opensearch-project:main Nov 29, 2021
@dblock
Copy link
Member

dblock commented Nov 29, 2021

I've merged this. @dlvenable need your eyes on this to help with helping other plugins on opensearch-project/opensearch-plugins#107 - maybe instructions, etc.

@dblock dblock added backport PRs or issues specific to backporting features or enhancments backport 1.x labels Nov 29, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 7c257d8
Log 1257

Reports 1257

@VachaShah
Copy link
Collaborator

@reta We have an auto-backport mechanism that allows to create backport PRs based on the labels. But since the backport workflow didn't run on this PR with the other checks, this PR would have to backported manually to 1.x.

@reta
Copy link
Collaborator Author

reta commented Nov 29, 2021

@VachaShah thanks, on it :)

@reta reta mentioned this pull request Nov 29, 2021
Merged
5 tasks
@dblock
Copy link
Member

dblock commented Nov 30, 2021

@reta care to take a look at https://github.com/opensearch-project/opensearch-build/runs/4361547117?check_suite_focus=true please?

Please consult deprecation warnings for more details.
* What went wrong:
795 actionable tasks: 795 executed
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0

@reta
Copy link
Collaborator Author

reta commented Nov 30, 2021

@dblock ah ... I know what is the issue, will send the PR in a sec (old plugin):

> Task :build-tools:publishPluginMavenPublicationToMavenLocal
Execution optimizations have been disabled for task ':build-tools:publishPluginMavenPublicationToMavenLocal' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/tmp/tmptny3_u2s/OpenSearch/buildSrc/build/distributions/build-tools-2.0.0-SNAPSHOT.pom'. Reason: Task ':build-tools:publishPluginMavenPublicationToMavenLocal' uses this output of task ':build-tools:generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Gradle detected a problem with the following location: '/tmp/tmptny3_u2s/OpenSearch/buildSrc/build/distributions/build-tools-2.0.0-SNAPSHOT.pom'. Reason: Task ':build-tools:publishPluginMavenPublicationToMavenLocal' uses this output of task ':build-tools:generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency for more details about this problem. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Multiple publications with coordinates 'org.opensearch.gradle:build-tools:2.0.0-SNAPSHOT' are published to repository 'mavenLocal'. The publications will overwrite each other!

reta added a commit to reta/OpenSearch that referenced this pull request Dec 3, 2021
@reta
Support Gradle 7 (opensearch-project#1609)
9154f86 
Signed-off-by: Andriy Redko <[email protected]>
dblock pushed a commit that referenced this pull request Dec 3, 2021
@reta
Support Gradle 7 (#1609) (#1622)
93bd32b 
Signed-off-by: Andriy Redko <[email protected]>
@dblock dblock mentioned this pull request Dec 3, 2021
Closed
reta added a commit to reta/OpenSearch that referenced this pull request Dec 6, 2021
@reta
Revert "Support Gradle 7 (opensearch-project#1609) (opensearch-projec…
3781516 
…t#1622)"

This reverts commit 93bd32b.

Signed-off-by: Andriy Redko <[email protected]>
dblock pushed a commit that referenced this pull request Dec 6, 2021
@reta
Revert "Support Gradle 7 (#1609) (#1622)" (#1657)
a80a254 
This reverts commit 93bd32b.

Signed-off-by: Andriy Redko <[email protected]>
@dblock dblock mentioned this pull request Dec 9, 2021
Closed
18 tasks
@VachaShah VachaShah mentioned this pull request Feb 28, 2022
Merged
@VachaShah VachaShah mentioned this pull request Mar 7, 2022
Merged
@dblock dblock mentioned this pull request Apr 14, 2022
Merged
1 task
@owaiskazi19 owaiskazi19 mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments backport 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Gradle 7 in plugins
4 participants
@reta @opensearch-ci-bot @dblock @VachaShah