Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryTraceContext benchmarks #840

Closed
wants to merge 24 commits into from

Conversation

DotSpy
Copy link
Member

@DotSpy DotSpy commented Feb 8, 2020

binary trace context benchmarks #792

@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #840 into master will increase coverage by 3.74%.
The diff coverage is 88.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #840      +/-   ##
============================================
+ Coverage     79.24%   82.99%   +3.74%     
- Complexity      788      837      +49     
============================================
  Files           105      108       +3     
  Lines          2848     2869      +21     
  Branches        273      253      -20     
============================================
+ Hits           2257     2381     +124     
+ Misses          487      375     -112     
- Partials        104      113       +9
Impacted Files Coverage Δ Complexity Δ
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 91.51% <ø> (ø) 45 <0> (ø) ⬇️
...o/opentelemetry/sdk/trace/export/SpanExporter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...lemetry/sdk/trace/export/SimpleSpansProcessor.java 87.5% <ø> (ø) 7 <0> (ø) ⬇️
...metry/exporters/jaeger/JaegerGrpcSpanExporter.java 67.79% <ø> (ø) 4 <0> (ø) ⬇️
...elemetry/sdk/trace/export/BatchSpansProcessor.java 89.65% <ø> (ø) 7 <0> (ø) ⬇️
...ntelemetry/sdk/trace/export/MultiSpanExporter.java 100% <ø> (ø) 12 <0> (ø) ⬇️
...ava/io/opentelemetry/exporters/jaeger/Adapter.java 96.2% <ø> (ø) 16 <0> (ø) ⬇️
...java/io/opentelemetry/sdk/trace/data/SpanData.java 100% <ø> (ø) 2 <0> (?)
...ntelemetry/exporters/inmemory/InMemoryTracing.java 85.71% <ø> (ø) 5 <0> (ø) ⬇️
...ava/io/opentelemetry/sdk/trace/SpanBuilderSdk.java 93.87% <ø> (ø) 36 <0> (ø) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a0d03...e051831. Read the comment docs.

@DotSpy
Copy link
Member Author

DotSpy commented Feb 19, 2020

Screenshot_2020-02-20 JMH Visualizer
if we will do error prone way i'll rewrite it #887

bogdandrutu and others added 17 commits February 21, 2020 18:27
…telemetry#831)

* Bound registry work in progress

Signed-off-by: Bogdan Cristian Drutu <[email protected]>

* Add comment about protecting a collection cycle by a lock

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
* Fix Javadoc in EnvVarResource.java

* Update package-info.java
* Rename TracerRegistry -> Tracer Provider

* Add comment to address the provider name

* gradlew goJF

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
… dropped spans (open-telemetry#889)

* Add instrumentation to the BatchSpansProcessor to count the number of dropped spans.
* Change Sampler interface

* Fix sampler interface

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
bogdandrutu and others added 3 commits February 21, 2020 18:27

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
* Introduce an abstract super class for aggregators.
This is to hold the boilerplate logic and get it out of the specific implementations.

* tighten up the access modifiers and flip the assignable logic to be correct
@DotSpy DotSpy closed this Feb 21, 2020
@DotSpy DotSpy deleted the binary_benchmark branch February 21, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants