-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinaryTraceContext benchmarks #840
Closed
Closed
+1,994
−976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DotSpy
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
songy23 and
tylerbenson
as code owners
February 8, 2020 18:00
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
============================================
+ Coverage 79.24% 82.99% +3.74%
- Complexity 788 837 +49
============================================
Files 105 108 +3
Lines 2848 2869 +21
Branches 273 253 -20
============================================
+ Hits 2257 2381 +124
+ Misses 487 375 -112
- Partials 104 113 +9
Continue to review full report at Codecov.
|
|
…lemetry#884) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
…#875) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
…y#887) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
…telemetry#873) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
…metry#865) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
…telemetry#831) * Bound registry work in progress Signed-off-by: Bogdan Cristian Drutu <[email protected]> * Add comment about protecting a collection cycle by a lock Signed-off-by: Bogdan Cristian Drutu <[email protected]>
* Fix Javadoc in EnvVarResource.java * Update package-info.java
* Rename TracerRegistry -> Tracer Provider * Add comment to address the provider name * gradlew goJF
… dropped spans (open-telemetry#889) * Add instrumentation to the BatchSpansProcessor to count the number of dropped spans.
* Change Sampler interface * Fix sampler interface
…-telemetry#897) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
…Info (open-telemetry#901) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
* Introduce an abstract super class for aggregators. This is to hold the boilerplate logic and get it out of the specific implementations. * tighten up the access modifiers and flip the assignable logic to be correct
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary trace context benchmarks #792