Add a MeterSharedState class that includes the InstrumentationLibraryinfo #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Info Signed-off-by: Bogdan Cristian Drutu <[email protected]>
bogdandrutu
requested review from
arminru,
carlosalberto,
jkwatson,
pavolloffay,
songy23 and
tylerbenson
as code owners
|
What will be added to the |
|
As mentioned in the description I want to share the registry and later a config for the aggregations. |
|
ah, i see. I read what you wrote differently. Got it now. |
jkwatson
approved these changes
Feb 20, 2020
DotSpy
pushed a commit
to DotSpy/opentelemetry-java
that referenced
this pull request
Feb 21, 2020
…Info (open-telemetry#901) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to pass the entire Meter shared state to the instruments, next PR will add a registry for the Instruments that is passed to the Builders to register the created instruments when build is called.