Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark usage of the SpanContext #792

Closed
jkwatson opened this issue Jan 24, 2020 · 9 comments
Closed

Benchmark usage of the SpanContext #792

jkwatson opened this issue Jan 24, 2020 · 9 comments
Assignees
Milestone

Comments

@jkwatson
Copy link
Contributor

No description provided.

@DotSpy
Copy link
Member

DotSpy commented Jan 30, 2020

@jkwatson can u provide more details about it? I would like to help with it

@jkwatson
Copy link
Contributor Author

@DotSpy I think part of this issue is to dig into the SpanContext and figure out what might need some benchmarking. I haven't had time to dig into it myself. Are you up for doing some of that digging and making some benchmark recommendations that could be built?

@DotSpy
Copy link
Member

DotSpy commented Jan 30, 2020

Yeap, i will dig and ask questions during investigation, if all go right i will be able to switch to another tasks with benchmarks. Do we have restrictions for frameworks that i can use for it?

@DotSpy
Copy link
Member

DotSpy commented Jan 30, 2020

Also i saw some benchmarks in opentelemetry-js project, i will ask guys there

@jkwatson
Copy link
Contributor Author

There's a pending PR to use JMH for the benchmarking (#678). I think we should stick with that.

@DotSpy
Copy link
Member

DotSpy commented Jan 31, 2020

@jkwatson Assign me to this one please

@DotSpy
Copy link
Member

DotSpy commented Feb 8, 2020

I did main PR benchmarks for context, for beta i think it's okay and we need to find some hardware on which we can run it to make measurements stick to it. So after we will be able to improve performance and write more specific benchmarks for context. @jkwatson what do u think is it possible to find such hardware?

@jkwatson
Copy link
Contributor Author

I think we'd need to lean on our friends in the CNCF to see if we can get a benchmarking platform. Not sure who can drive this. @bogdandrutu maybe?

@bogdandrutu bogdandrutu added this to the Beta release milestone Feb 14, 2020
@jkwatson
Copy link
Contributor Author

Is there anything further we'd like to benchmark around the SpanContext itself, @carlosalberto ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants