Introduce an abstract super class for aggregators. #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to hold the boilerplate logic and get it out of the specific implementations.
jkwatson
requested review from
arminru,
bogdandrutu,
carlosalberto,
pavolloffay,
songy23 and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
============================================
+ Coverage 82.64% 82.71% +0.07%
- Complexity 834 836 +2
============================================
Files 111 112 +1
Lines 2938 2939 +1
Branches 251 251
============================================
+ Hits 2428 2431 +3
+ Misses 397 396 -1
+ Partials 113 112 -1
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Feb 20, 2020
sdk/src/main/java/io/opentelemetry/sdk/metrics/aggregator/AbstractAggregator.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/opentelemetry/sdk/metrics/aggregator/AbstractAggregator.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/opentelemetry/sdk/metrics/aggregator/AbstractAggregator.java
Outdated
Show resolved
Hide resolved
bogdandrutu
approved these changes
Feb 21, 2020
DotSpy
pushed a commit
to DotSpy/opentelemetry-java
that referenced
this pull request
Feb 21, 2020
* Introduce an abstract super class for aggregators. This is to hold the boilerplate logic and get it out of the specific implementations. * tighten up the access modifiers and flip the assignable logic to be correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to hold the boilerplate logic and get it out of the specific implementations.