Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract descriptor fields for Instrument and use autovalue #865

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 15, 2020

Codecov Report

Merging #865 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #865      +/-   ##
============================================
- Coverage     82.29%   82.23%   -0.06%     
  Complexity      839      839              
============================================
  Files           110      111       +1     
  Lines          2920     2882      -38     
  Branches        258      253       -5     
============================================
- Hits           2403     2370      -33     
  Misses          401      401              
+ Partials        116      111       -5
Impacted Files Coverage Δ Complexity Δ
.../io/opentelemetry/sdk/metrics/AbstractCounter.java 91.66% <100%> (ø) 9 <0> (ø) ⬇️
...try/sdk/metrics/AbstractInstrumentWithBinding.java 68% <100%> (ø) 5 <1> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 75% <100%> (-3.58%) 5 <0> (ø)
.../io/opentelemetry/sdk/metrics/AbstractMeasure.java 91.66% <100%> (ø) 9 <0> (ø) ⬇️
.../io/opentelemetry/sdk/metrics/LongObserverSdk.java 91.66% <100%> (-2.09%) 2 <0> (ø)
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 75% <100%> (-3.58%) 5 <0> (ø)
...o/opentelemetry/sdk/metrics/DoubleObserverSdk.java 91.66% <100%> (-2.09%) 2 <0> (ø)
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 75% <100%> (-3.58%) 5 <0> (ø)
...pentelemetry/sdk/metrics/InstrumentDescriptor.java 100% <100%> (ø) 2 <2> (?)
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 75% <100%> (-3.58%) 5 <0> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b727e4...faafe3b. Read the comment docs.

@bogdandrutu
Copy link
Member Author

@jkwatson PTAL :)

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bogdandrutu bogdandrutu merged commit b84bf39 into open-telemetry:master Feb 19, 2020
@bogdandrutu bogdandrutu deleted the desc branch February 19, 2020 21:57
DotSpy pushed a commit to DotSpy/opentelemetry-java that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants