Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TracerRegistry -> Tracer Provider #879

Conversation

thisthat
Copy link
Member

This addresses #794

Specification: link

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #879 into master will increase coverage by 0.06%.
The diff coverage is 95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #879      +/-   ##
============================================
+ Coverage     82.89%   82.96%   +0.06%     
- Complexity      834      835       +1     
============================================
  Files           108      108              
  Lines          2865     2865              
  Branches        253      253              
============================================
+ Hits           2375     2377       +2     
+ Misses          376      375       -1     
+ Partials        114      113       -1
Impacted Files Coverage Δ Complexity Δ
...lemetry/sdk/common/InstrumentationLibraryInfo.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...o/opentelemetry/sdk/trace/export/SpanExporter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
.../io/opentelemetry/sdk/trace/TracerSharedState.java 93.33% <ø> (ø) 10 <0> (ø) ⬇️
...ain/java/io/opentelemetry/sdk/trace/TracerSdk.java 100% <ø> (ø) 9 <0> (ø) ⬇️
.../opentelemetry/sdk/trace/spi/TraceProviderSdk.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...in/java/io/opentelemetry/sdk/OpenTelemetrySdk.java 100% <100%> (ø) 3 <1> (ø) ⬇️
.../io/opentelemetry/sdk/trace/TracerSdkProvider.java 100% <100%> (ø) 10 <2> (?)
.../io/opentelemetry/trace/DefaultTracerProvider.java 100% <100%> (ø) 5 <2> (?)
.../src/main/java/io/opentelemetry/OpenTelemetry.java 97.43% <100%> (ø) 15 <1> (ø) ⬇️
...va/io/opentelemetry/opentracingshim/TraceShim.java 100% <100%> (ø) 3 <2> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5caea7...c0814b1. Read the comment docs.

@bogdandrutu bogdandrutu merged commit b0d42dd into open-telemetry:master Feb 20, 2020
DotSpy pushed a commit to DotSpy/opentelemetry-java that referenced this pull request Feb 21, 2020
* Rename TracerRegistry -> Tracer Provider

* Add comment to address the provider name

* gradlew goJF
@thisthat thisthat deleted the tracer-registry-to-provider branch April 30, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants