Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a static method to access EMPTY InstrumentationLibraryInfo. #897

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #897 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #897     +/-   ##
===========================================
+ Coverage     82.64%   82.74%   +0.1%     
- Complexity      834      836      +2     
===========================================
  Files           111      111             
  Lines          2938     2939      +1     
  Branches        251      251             
===========================================
+ Hits           2428     2432      +4     
+ Misses          397      396      -1     
+ Partials        113      111      -2
Impacted Files Coverage Δ Complexity Δ
...lemetry/sdk/common/InstrumentationLibraryInfo.java 100% <100%> (ø) 4 <2> (+1) ⬆️
...java/io/opentelemetry/sdk/trace/data/SpanData.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...elemetry/sdk/trace/export/BatchSpansProcessor.java 90.55% <0%> (+0.78%) 7% <0%> (ø) ⬇️
...elemetry/opentracingshim/SpanContextShimTable.java 96.42% <0%> (+7.14%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31441a...54c3e2d. Read the comment docs.

@bogdandrutu bogdandrutu merged commit aadea3d into open-telemetry:master Feb 20, 2020
@bogdandrutu bogdandrutu deleted the emptyili branch February 20, 2020 17:47
@Oberon00
Copy link
Member

Oberon00 commented Feb 21, 2020

Since I'm not a Java expert, honest question: What's the advantage of this?

DotSpy pushed a commit to DotSpy/opentelemetry-java that referenced this pull request Feb 21, 2020
@jkwatson
Copy link
Contributor

As far as I can see, it's just a style choice. It could allow you to later not have the method simply return a static member, but I'm not sure why we would want to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants