-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v18.19.0 release proposal #50953
v18.19.0 release proposal #50953
Commits on Nov 23, 2023
-
esm: handle more error types thrown from the loader thread
PR-URL: #48247 Backport-PR-URL: #50669 Refs: #48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9938a8b - Browse repository at this point
Copy the full SHA 9938a8bView commit details -
esm: handle
globalPreload
hook returning a nullish valuePR-URL: #48249 Backport-PR-URL: #50669 Fixes: #48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 655111f - Browse repository at this point
Copy the full SHA 655111fView commit details -
esm: remove support for arrays in
import
internal methodThis avoids initializing arrays that we never use, and simplifies the implementation overall. PR-URL: #48296 Backport-PR-URL: #50669 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c7be60 - Browse repository at this point
Copy the full SHA 1c7be60View commit details -
typings: fix JSDoc in ESM loader modules
PR-URL: #48424 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2ef80f1 - Browse repository at this point
Copy the full SHA 2ef80f1View commit details -
module: implement
register
utilityPR-URL: #46826 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65dfe85 - Browse repository at this point
Copy the full SHA 65dfe85View commit details -
esm: add back
globalPreload
tests and fix failing onesPR-URL: #48779 Backport-PR-URL: #50669 Fixes: #48778 Fixes: #48516 Refs: #46402 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 63aa5d7 - Browse repository at this point
Copy the full SHA 63aa5d7View commit details -
esm: unflag
Module.register
and allow nested loaderimport()
Major functional changes: - Allow `import()` to work within loaders that require other loaders, - Unflag the use of `Module.register`. A new interface `Customizations` has been created in order to unify `ModuleLoader` (previously `DefaultModuleLoader`), `Hooks` and `CustomizedModuleLoader` all of which now implement it: ```ts interface LoadResult { format: ModuleFormat; source: ModuleSource; } interface ResolveResult { format: string; url: URL['href']; } interface Customizations { allowImportMetaResolve: boolean; load(url: string, context: object): Promise<LoadResult> resolve( originalSpecifier: string, parentURL: string, importAssertions: Record<string, string> ): Promise<ResolveResult> resolveSync( originalSpecifier: string, parentURL: string, importAssertions: Record<string, string> ) ResolveResult; register(specifier: string, parentUrl: string): any; forceLoadHooks(): void; importMetaInitialize(meta, context, loader): void; } ``` The `ModuleLoader` class now has `setCustomizations` which takes an object of this shape and delegates its responsibilities to this object if present. Note that two properties `allowImportMetaResolve` and `resolveSync` exist now as a mechanism for `import.meta.resolve` – since `Hooks` does not implement `resolveSync` other loaders cannot use `import.meta.resolve`; `allowImportMetaResolve` is a way of checking for that case instead of invoking `resolveSync` and erroring. Fixes #48515 Closes #48439 PR-URL: #48559 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 03c1b5e - Browse repository at this point
Copy the full SHA 03c1b5eView commit details -
module: ensure successful import returns the same result
PR-URL: #46662 Backport-PR-URL: #50669 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 14e148e - Browse repository at this point
Copy the full SHA 14e148eView commit details -
test: fix
es-module/test-esm-initialization
PR-URL: #48880 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f02637e - Browse repository at this point
Copy the full SHA f02637eView commit details -
fs: make
mkdtemp
accept buffers and URLPR-URL: #48828 Backport-PR-URL: #50669 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 48c25b1 - Browse repository at this point
Copy the full SHA 48c25b1View commit details -
test: fix some assumptions in tests
Some tests are assuming they will be run from a directory that do not contain any quote or special character in its path. That assumption is not necessary, using `JSON.stringify` or `pathToFileURL` ensures the test can be run whatever the path looks like. PR-URL: #48958 Backport-PR-URL: #50669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for adb9280 - Browse repository at this point
Copy the full SHA adb9280View commit details -
test: order
common.mjs
in ASCII orderPR-URL: #48960 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a9347a4 - Browse repository at this point
Copy the full SHA a9347a4View commit details -
test: fix snapshot tests when cwd contains spaces or backslashes
Both are valid characters for file names on non-Windows systems. PR-URL: #48959 Backport-PR-URL: #50669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3424793 - Browse repository at this point
Copy the full SHA 3424793View commit details -
esm: fix typo
parentUrl
->parentURL
PR-URL: #48999 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f96b610 - Browse repository at this point
Copy the full SHA f96b610View commit details -
esm: add
initialize
hook, integrate withregister
Follows @giltayar's proposed API: > `register` can pass any data it wants to the loader, which will be passed to the exported `initialize` function of the loader. Additionally, if the user of `register` wants to communicate with the loader, it can just create a `MessageChannel` and pass the port to the loader as data. The `register` API is now: ```ts interface Options { parentUrl?: string; data?: any; transferList?: any[]; } function register(loader: string, parentUrl?: string): any; function register(loader: string, options?: Options): any; ``` This API is backwards compatible with the old one (new arguments are optional and at the end) and allows for passing data into the new `initialize` hook. If this hook returns data it is passed back to `register`: ```ts function initialize(data: any): Promise<any>; ``` **NOTE**: Currently there is no mechanism for a loader to exchange ownership of something back to the caller. Refs: nodejs/loaders#147 PR-URL: #48842 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 10e7c3a - Browse repository at this point
Copy the full SHA 10e7c3aView commit details -
test: use
fixtures.fileURL
when appropriatePR-URL: #48990 Backport-PR-URL: #50669 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5a1153 - Browse repository at this point
Copy the full SHA d5a1153View commit details -
esm: protect
ERR_UNSUPPORTED_DIR_IMPORT
against prototype pollutionPR-URL: #49060 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 385f24c - Browse repository at this point
Copy the full SHA 385f24cView commit details -
test: reduce flakiness of
test-esm-loader-hooks
PR-URL: #49105 Backport-PR-URL: #50669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 26f0166 - Browse repository at this point
Copy the full SHA 26f0166View commit details -
esm: import.meta.resolve exact module not found errors should return
PR-URL: #49038 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef43f08 - Browse repository at this point
Copy the full SHA ef43f08View commit details -
esm: unflag import.meta.resolve
PR-URL: #49028 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1a8439 - Browse repository at this point
Copy the full SHA c1a8439View commit details -
esm: fix
globalPreload
warningPR-URL: #49069 Backport-PR-URL: #50669 Fixes: #49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01ca6d2 - Browse repository at this point
Copy the full SHA 01ca6d2View commit details -
doc: fix name of the flag in
initialize()
docsPR-URL: #49158 Backport-PR-URL: #50669 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2fef28b - Browse repository at this point
Copy the full SHA 2fef28bView commit details -
test: refactor
test-esm-loader-hooks
for easier debugging- Always check stderr before stdout as the former would contain error information. - Always match the full stdout to avoid surprises. - Use `deepStrictEqual` when appropriate to get more informative test failures. - Remove leading slashes from relative paths/URLs to not confuse them with absolute paths. - Remove unnecessary `--no-warnings` flag. PR-URL: #49131 Backport-PR-URL: #50669 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8d475f - Browse repository at this point
Copy the full SHA e8d475fView commit details -
doc: caveat unavailability of
import.meta.resolve
in custom loadersPR-URL: #49242 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58eaf3f - Browse repository at this point
Copy the full SHA 58eaf3fView commit details -
test: reduce flakiness of
test-esm-loader-hooks
PR-URL: #49248 Backport-PR-URL: #50669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1c6f46 - Browse repository at this point
Copy the full SHA e1c6f46View commit details -
doc: add signature for
module.register
PR-URL: #49251 Backport-PR-URL: #50669 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 258df0e - Browse repository at this point
Copy the full SHA 258df0eView commit details -
PR-URL: #49465 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d1f5514 - Browse repository at this point
Copy the full SHA d1f5514View commit details -
doc: move and rename loaders section
PR-URL: #49261 Backport-PR-URL: #50669 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ed2d46f - Browse repository at this point
Copy the full SHA ed2d46fView commit details -
PR-URL: #49265 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ac389e - Browse repository at this point
Copy the full SHA 1ac389eView commit details -
doc: edit
import.meta.resolve
documentationPR-URL: #49247 Backport-PR-URL: #50669 Refs: #49028 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c20fdb4 - Browse repository at this point
Copy the full SHA c20fdb4View commit details -
PR-URL: #49040 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65058d9 - Browse repository at this point
Copy the full SHA 65058d9View commit details -
esm: refactor test-esm-named-exports
PR-URL: #49493 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b7c9d9 - Browse repository at this point
Copy the full SHA 9b7c9d9View commit details -
esm: refactor test-esm-loader-resolve-type
PR-URL: #49493 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0875867 - Browse repository at this point
Copy the full SHA 0875867View commit details -
esm: remove return value for
Module.register
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: #49529 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4be5612 - Browse repository at this point
Copy the full SHA 4be5612View commit details -
typings: fix missing property in
ExportedHooks
PR-URL: #49567 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9456094 - Browse repository at this point
Copy the full SHA 9456094View commit details -
test: isolate
globalPreload
testsPR-URL: #49545 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65201ab - Browse repository at this point
Copy the full SHA 65201abView commit details -
test: increase coverage of
Module.register
andinitialize
hookPR-URL: #49532 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 866d646 - Browse repository at this point
Copy the full SHA 866d646View commit details -
esm: clarify ERR_REQUIRE_ESM errors
In #39175, better ESM errors were introduced. This commit tweaks the language in the error slightly to make it clear that there are three different options to resolve the error. Refs: #39175 PR-URL: #49521 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51ced0f - Browse repository at this point
Copy the full SHA 51ced0fView commit details -
esm: fix support for
URL
instances inregister
PR-URL: #49655 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 47193a3 - Browse repository at this point
Copy the full SHA 47193a3View commit details -
PR-URL: #49633 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 12cb700 - Browse repository at this point
Copy the full SHA 12cb700View commit details -
esm: fix return type of
import.meta.resolve
PR-URL: #49698 Backport-PR-URL: #50669 Fixes: #49695 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46d730a - Browse repository at this point
Copy the full SHA 46d730aView commit details -
doc: add missing history info for
import.meta.resolve
PR-URL: #49700 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 73a7e00 - Browse repository at this point
Copy the full SHA 73a7e00View commit details -
esm: identify parent importing a url with invalid host
PR-URL: #49736 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ed8dd33 - Browse repository at this point
Copy the full SHA ed8dd33View commit details -
esm: fix cache collision on JSON files using file: URL
PR-URL: #49887 Backport-PR-URL: #50669 Fixes: #49724 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c12685f - Browse repository at this point
Copy the full SHA c12685fView commit details -
lib: merge cjs and esm package json reader caches
PR-URL: #48477 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fe26f8a - Browse repository at this point
Copy the full SHA fe26f8aView commit details -
esm: require braces for modules code
PR-URL: #49657 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 957725f - Browse repository at this point
Copy the full SHA 957725fView commit details -
module, esm: jsdoc for modules files
PR-URL: #49523 Backport-PR-URL: #50669 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9757989 - Browse repository at this point
Copy the full SHA 9757989View commit details -
module: move helpers out of cjs loader
PR-URL: #49912 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c55f31 - Browse repository at this point
Copy the full SHA 8c55f31View commit details -
esm: improve JSDoc annotation of internal functions
Co-authored-by: Geoffrey Booth <[email protected]> PR-URL: #49959 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 72644d6 - Browse repository at this point
Copy the full SHA 72644d6View commit details -
esm: --experimental-default-type flag to flip module defaults
PR-URL: #49869 Backport-PR-URL: #50669 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 56bd9a8 - Browse repository at this point
Copy the full SHA 56bd9a8View commit details -
esm: unflag extensionless javascript and wasm in module scope
PR-URL: #49974 Backport-PR-URL: #50669 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fe69198 - Browse repository at this point
Copy the full SHA fe69198View commit details -
util: add
getCwdSafe
internal util fnThis function was first implemented in #46826, but at some point of the PR implementation this fn was no longer related to the PR. Refs: #46826 (comment) PR-URL: #48434 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a67fa2a - Browse repository at this point
Copy the full SHA a67fa2aView commit details -
esm: bypass CommonJS loader under --default-type
PR-URL: #49986 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c3c945e - Browse repository at this point
Copy the full SHA c3c945eView commit details -
tools: update eslint to 8.45.0
PR-URL: #48793 Backport-PR-URL: #50669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e963245 - Browse repository at this point
Copy the full SHA e963245View commit details -
tools: update eslint to 8.46.0
PR-URL: #48966 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4880a05 - Browse repository at this point
Copy the full SHA 4880a05View commit details -
tools: update eslint to 8.47.0
PR-URL: #49124 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0940de3 - Browse repository at this point
Copy the full SHA 0940de3View commit details -
tools: update eslint to 8.48.0
PR-URL: #49343 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92d2186 - Browse repository at this point
Copy the full SHA 92d2186View commit details -
tools: update eslint to 8.49.0
PR-URL: #49586 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c1cbf0 - Browse repository at this point
Copy the full SHA 1c1cbf0View commit details -
tools: update eslint to 8.50.0
PR-URL: #49989 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b8d2a29 - Browse repository at this point
Copy the full SHA b8d2a29View commit details -
tools: update eslint to 8.51.0
PR-URL: #50084 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6cf8dd9 - Browse repository at this point
Copy the full SHA 6cf8dd9View commit details -
esm: use import attributes instead of import assertions
The old import assertions proposal has been renamed to "import attributes" with the follwing major changes: 1. The keyword is now `with` instead of `assert`. 2. Unknown assertions cause an error rather than being ignored, This commit updates the documentation to encourage folks to use the new syntax, and add aliases for module customization hooks. PR-URL: #50140 Backport-PR-URL: #50669 Fixes: #50134 Refs: v8/v8@159c82c Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92734d4 - Browse repository at this point
Copy the full SHA 92734d4View commit details -
test: deflake
test-esm-loader-resolve-type
PR-URL: #50273 Backport-PR-URL: #50669 Fixes: #50040 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5cc5d7 - Browse repository at this point
Copy the full SHA d5cc5d7View commit details -
test: deflake
test-loaders-workers-spawned
PR-URL: #50251 Backport-PR-URL: #50669 Fixes: #50247 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1a8ae3 - Browse repository at this point
Copy the full SHA c1a8ae3View commit details -
vm: use import attributes instead of import assertions
The old import assertions proposal has been renamed to "import attributes" with the following major changes: 1. The keyword is now `with` instead of `assert`. 2. Unknown assertions cause an error rather than being ignored. This PR updates the documentation to encourage folks to use the new syntax, and add aliases to preserve backward compatibility. PR-URL: #50141 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e96f7ef - Browse repository at this point
Copy the full SHA e96f7efView commit details -
test: refactor
test-node-output-errors
The main reason is to not have the test fail if the CWD contains some special URL chars. PR-URL: #48992 Backport-PR-URL: #50669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 48f6d9a - Browse repository at this point
Copy the full SHA 48f6d9aView commit details -
test: fix edge snapshot stack traces
PR-URL: #49659 Backport-PR-URL: #50669 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 00c0853 - Browse repository at this point
Copy the full SHA 00c0853View commit details -
tools: skip ruff on tools/node_modules
PR-URL: #49838 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a98addb - Browse repository at this point
Copy the full SHA a98addbView commit details
Commits on Nov 26, 2023
-
deps: V8: cherry-pick 1a782f6543ae
Original commit message: [base] add build flag to use MADV_DONTFORK Embedders like Node.js and Electron expose fork(2)/execve(2) to their users. Unfortunately when the V8 heap is very large, these APIs become rather slow on Linux, due to the kernel needing to do all the bookkeeping for the forked process (in clone's dup_mmap and execve's exec_mmap). Of course, this is useless because the forked child thread will never actually need to access the V8 heap. Add a new build flag v8_enable_private_mapping_fork_optimization which marks all pages allocated by OS::Allocate as MADV_DONTFORK. This improves the performance of Node.js's fork/execve combination by 10x on a 600 MB heap. Fixed: v8:7381 Change-Id: Ib649f774d4a932b41886313ce89acc369923699d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4602858 Commit-Queue: Michael Lippautz <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/main@{#88447} Refs: v8/v8@1a782f6 PR-URL: #48523 Backport-PR-URL: #50098 Fixes: #25382 Fixes: #14917 Refs: nodejs/performance#93 Refs: nodejs/performance#89 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 747fbb4 - Browse repository at this point
Copy the full SHA 747fbb4View commit details -
child_process: improve spawn performance on Linux
Speed up child_process.spawn by enabling the new V8 build flag which makes fork/exec faster. Here are the results of running the existing benchmark. Note that this optimization helps more for applications with larger heaps, so this is somewhat of an underestimate of the real world performance benefits. ```console $ ./node benchmark/compare.js --runs 15 \ --new ./node \ --old ~/node-v20/out/Release/node \ --filter params child_process > cpr $ node-benchmark-compare cpr confidence improvement (***) methodName='exec' n=1000 *** 60.84 % ±5.43% methodName='execFile' n=1000 *** 53.72 % ±3.33% methodName='execFileSync' n=1000 *** 9.10 % ±0.84% methodName='execSync' n=1000 *** 10.44 % ±0.97% methodName='spawn' n=1000 *** 53.10 % ±2.90% methodName='spawnSync' n=1000 *** 8.64 % ±1.22% 0.01 false positives, when considering a 0.1% risk acceptance (***) ``` Fixes: #25382 Fixes: #14917 Refs: nodejs/performance#93 Refs: nodejs/performance#89 PR-URL: #48523 Backport-PR-URL: #50098 Refs: v8/v8@1a782f6 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f68e14 - Browse repository at this point
Copy the full SHA 7f68e14View commit details -
test: add Symbol.dispose support to mock timers
PR-URL: #48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67925bb - Browse repository at this point
Copy the full SHA 67925bbView commit details -
bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose}
Followup to #48518; fixes #48699 PR-URL: #48703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e08fd98 - Browse repository at this point
Copy the full SHA e08fd98View commit details -
deps: update googletest to cc36671
PR-URL: #48789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e455dd4 - Browse repository at this point
Copy the full SHA e455dd4View commit details -
src: remove OnScopeLeaveImpl's move assignment overload
... as it's not valid implementation and also has not been used PR-URL: #48732 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 358273d - Browse repository at this point
Copy the full SHA 358273dView commit details -
doc: nodejs-social over nodejs/tweet
PR-URL: #48769 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 74d8f96 - Browse repository at this point
Copy the full SHA 74d8f96View commit details -
url: reduce
pathToFileURL
cpp callsPR-URL: #48709 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2441415 - Browse repository at this point
Copy the full SHA 2441415View commit details -
doc: remove the . in the end to reduce confusing
PR-URL: #48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dfd368a - Browse repository at this point
Copy the full SHA dfd368aView commit details -
meta: add mailmap entry for atlowChemi
PR-URL: #48810 Refs: #48806 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f62b242 - Browse repository at this point
Copy the full SHA f62b242View commit details -
tools: update lint-md-dependencies to @rollup/[email protected]
PR-URL: #48791 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f7d6e9b - Browse repository at this point
Copy the full SHA f7d6e9bView commit details -
doc: declare
path
on example ofasync_hooks.executionAsyncId()
Example is not runnable because `path` is used, but it's not declared. PR-URL: #48556 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 629132d - Browse repository at this point
Copy the full SHA 629132dView commit details -
src: fix nullptr access on realm
Adding the per-realm binding data tracking introduced a call to a realm method when realm was potentially null. This is triggered whenever the function is called from `ContextifyContext::New` which passes `nullptr` as the `realm`. PR-URL: #48802 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5384c3 - Browse repository at this point
Copy the full SHA f5384c3View commit details -
doc: refactor node-api support matrix
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: #48277 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48774 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4fe00d - Browse repository at this point
Copy the full SHA d4fe00dView commit details -
Refs: nodejs/TSC#1411 Refs: nodejs/TSC#1410 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48841 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e6d8735 - Browse repository at this point
Copy the full SHA e6d8735View commit details -
src: remove unnecessary temporary creation
PR-URL: #48734 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 97d8749 - Browse repository at this point
Copy the full SHA 97d8749View commit details -
fs: remove redundant
nullCheck
PR-URL: #48826 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae8bb16 - Browse repository at this point
Copy the full SHA ae8bb16View commit details -
deps: update zlib to 1.2.13.1-motley-61dc0bd
PR-URL: #48788 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6059b59 - Browse repository at this point
Copy the full SHA 6059b59View commit details -
doc: include experimental features assessment
PR-URL: #48824 Refs: nodejs-private/node-private#420 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a8d5c16 - Browse repository at this point
Copy the full SHA a8d5c16View commit details -
typings: sync JSDoc with the actual implementation
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: #46933 PR-URL: #48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d70a2c - Browse repository at this point
Copy the full SHA 4d70a2cView commit details -
src: use ARES_SUCCESS instead of 0
Since error messages are also using defined values, it is more clear to use the defined value even when the operation succeeds. PR-URL: #48834 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67dba57 - Browse repository at this point
Copy the full SHA 67dba57View commit details -
node-api: avoid macro redefinition
Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition. Refs: #28237 Refs: #30006 PR-URL: #48879 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5796631 - Browse repository at this point
Copy the full SHA 5796631View commit details -
test_runner: fix global before not called when no global test exists
PR-URL: #48877 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 66ea9bd - Browse repository at this point
Copy the full SHA 66ea9bdView commit details -
doc: add ver of 18.x where Node-api 9 is supported
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48876 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cb43717 - Browse repository at this point
Copy the full SHA cb43717View commit details -
http: start connections checking interval on listen
Co-authored-by: Luigi Pinca <[email protected]> PR-URL: #48611 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8874b2e - Browse repository at this point
Copy the full SHA 8874b2eView commit details -
tools: update lint-md-dependencies to [email protected]
PR-URL: #48888 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1cbb186 - Browse repository at this point
Copy the full SHA 1cbb186View commit details -
PR-URL: #48898 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 833c643 - Browse repository at this point
Copy the full SHA 833c643View commit details -
deps: update googletest to c875c4e
PR-URL: #48964 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 588bd5e - Browse repository at this point
Copy the full SHA 588bd5eView commit details -
tools: update lint-md-dependencies to [email protected]
PR-URL: #48965 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9cc3b20 - Browse repository at this point
Copy the full SHA 9cc3b20View commit details -
deps: update zlib to 1.2.13.1-motley-526382e
PR-URL: #49033 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c15dd66 - Browse repository at this point
Copy the full SHA c15dd66View commit details -
deps: update googletest to 7e33b6a
PR-URL: #49034 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 374ec3d - Browse repository at this point
Copy the full SHA 374ec3dView commit details -
deps: update zlib to 1.2.13.1-motley-f5fd0ad
PR-URL: #49252 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c33857 - Browse repository at this point
Copy the full SHA 5c33857View commit details -
deps: update googletest to 8a6feab
PR-URL: #49463 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd99ee1 - Browse repository at this point
Copy the full SHA cd99ee1View commit details -
deps: update googletest to d1467f5
PR-URL: #49676 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 736c869 - Browse repository at this point
Copy the full SHA 736c869View commit details -
deps: update googletest to e47544a
PR-URL: #49982 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1b103cc - Browse repository at this point
Copy the full SHA 1b103ccView commit details -
deps: update googletest to 2dd1c13
PR-URL: #50081 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e0fd52b - Browse repository at this point
Copy the full SHA e0fd52bView commit details -
deps: update zlib to 1.2.13.1-motley-fef5869
PR-URL: #50085 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 49c5495 - Browse repository at this point
Copy the full SHA 49c5495View commit details -
tools: limit the number of auto start CIs
PR-URL: #49067 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42846a0 - Browse repository at this point
Copy the full SHA 42846a0View commit details -
tools: update lint-md-dependencies to [email protected]
PR-URL: #49035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for caa7ecc - Browse repository at this point
Copy the full SHA caa7eccView commit details -
test: add expectSyncExitWithoutError() and expectSyncExit() utils
These can be used to check the state and the output of a child process launched with `spawnSync()`. They log additional information about the child process when the check fails to facilitate debugging test failures. PR-URL: #49020 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 52d5dd8 - Browse repository at this point
Copy the full SHA 52d5dd8View commit details -
build: fix typo
libray
->library
(configure.py)Signed-off-by: Michal Biesek <[email protected]> PR-URL: #49106 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a781d24 - Browse repository at this point
Copy the full SHA a781d24View commit details -
test_runner: add
__proto__
nullPR-URL: #48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a74316 - Browse repository at this point
Copy the full SHA 3a74316View commit details -
benchmark: add benchmarks for the test_runner
PR-URL: #48931 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d0eb47 - Browse repository at this point
Copy the full SHA 0d0eb47View commit details -
test_runner: unwrap error message in TAP reporter
The TAP reporter unwraps errors that come from user code. It was not properly unwrapping the error message when the failure originated from a test hook. This lead to difficult to debug errors when TAP output was used. This commit updates the TAP reporter to properly unwrap the error message. Fixes: #48941 PR-URL: #48942 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f122be - Browse repository at this point
Copy the full SHA 9f122beView commit details -
test_runner: fix todo and only in spec reporter
PR-URL: #48929 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d217435 - Browse repository at this point
Copy the full SHA d217435View commit details -
test_runner: cleanup test timeout abort listener
fix #48475 PR-URL: #48915 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67d7fad - Browse repository at this point
Copy the full SHA 67d7fadView commit details -
test_runner: fix timeout in *Each hook failing further tests
PR-URL: #48925 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb64d41 - Browse repository at this point
Copy the full SHA fb64d41View commit details -
meta: bump actions/setup-python from 4.6.1 to 4.7.0
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@bd6b4b6...61a6322) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #48983 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0d769f - Browse repository at this point
Copy the full SHA b0d769fView commit details -
meta: bump actions/setup-node from 3.6.0 to 3.7.0
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@64ed1c7...e33196f) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #48984 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42ac5a6 - Browse repository at this point
Copy the full SHA 42ac5a6View commit details -
meta: bump step-security/harden-runner from 2.4.1 to 2.5.0
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.1 to 2.5.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@55d479f...cba0d00) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #48985 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c352ee - Browse repository at this point
Copy the full SHA 5c352eeView commit details -
meta: bump github/codeql-action from 2.20.1 to 2.21.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.1 to 2.21.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f6e388e...0ba4244) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #48986 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6e68a0 - Browse repository at this point
Copy the full SHA f6e68a0View commit details -
PR-URL: #49005 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4047947 - Browse repository at this point
Copy the full SHA 4047947View commit details -
doc: clarify use of process.env in worker threads on Windows
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #49008 Fixes: #48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ead654f - Browse repository at this point
Copy the full SHA ead654fView commit details -
typings: update JSDoc for
cwd
inchild_process
PR-URL: #49029 Refs: #38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71c386a - Browse repository at this point
Copy the full SHA 71c386aView commit details -
doc: detailed description of keystrokes Ctrl-Y and Meta-Y
PR-URL: #43529 Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 12b83e8 - Browse repository at this point
Copy the full SHA 12b83e8View commit details -
doc: add ESM examples in http.md
PR-URL: #47763 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6daa9ec - Browse repository at this point
Copy the full SHA 6daa9ecView commit details -
PR-URL: #49094 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 633b8cd - Browse repository at this point
Copy the full SHA 633b8cdView commit details -
doc: add description for
--port
flag ofnode inspect
PR-URL: #48785 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ce7396 - Browse repository at this point
Copy the full SHA 9ce7396View commit details -
doc: update with latest security release
PR-URL: #49085 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ee26fb - Browse repository at this point
Copy the full SHA 7ee26fbView commit details -
readline: add paste bracket mode
The paste bracket mode allows REPL to have auto-indentation that is handled differently when the user copy-pastes the code from the clipboard and the code already has an indentation. PR-URL: #47150 Fixes: #45213 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Kohei Ueno <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a625f22 - Browse repository at this point
Copy the full SHA a625f22View commit details -
events: remove weak listener for event target
Fixes: #48951 PR-URL: #48952 Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for acd9872 - Browse repository at this point
Copy the full SHA acd9872View commit details -
stream: improve WebStreams performance
PR-URL: #49089 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d585d13 - Browse repository at this point
Copy the full SHA d585d13View commit details -
lib: fix MIME overmatch in data URLs
This commit adds the delimiters ^ and $ to the regex that matches the MIME types for `data:` URLs. PR-URL: #49104 Fixes: #48957 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 981aa78 - Browse repository at this point
Copy the full SHA 981aa78View commit details -
doc: make the NODE_VERSION_IS_RELEASE revert clear
PR-URL: #49114 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79c0497 - Browse repository at this point
Copy the full SHA 79c0497View commit details -
doc: fix
Type
notation in webstreamsReplace `type` with `Type: {Promise}`. Plus, fix incorrect verb(`creates` -> `returns`) in description. PR-URL: #49121 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55171d8 - Browse repository at this point
Copy the full SHA 55171d8View commit details -
tools: update lint-md-dependencies
- @rollup/[email protected] - [email protected] PR-URL: #49122 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0cb42cc - Browse repository at this point
Copy the full SHA 0cb42ccView commit details -
doc: fix wording in napi_async_init
Refs: #32930 PR-URL: #49180 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3b82e9a - Browse repository at this point
Copy the full SHA 3b82e9aView commit details -
doc: add h1 summary to security release process
PR-URL: #49112 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2247e52 - Browse repository at this point
Copy the full SHA 2247e52View commit details -
doc: add notable-change label mention to PR template
PR-URL: #49188 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 72bd527 - Browse repository at this point
Copy the full SHA 72bd527View commit details -
meta: mention nodejs/tsc when changing GH templates
PR-URL: #49189 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bd17f0b - Browse repository at this point
Copy the full SHA bd17f0bView commit details -
test: use gcUntil() in test-v8-serialize-leak
Previously this can be flaky because the there could be a delay of the deallocation after gc() is invoked. Use gcUntil() to run the GC multiple times to make the test more robust. PR-URL: #49168 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e18de80 - Browse repository at this point
Copy the full SHA e18de80View commit details -
test: make test-perf-hooks more robust and work with workers
Previously the test makes several assumptions about the absolute values of the nodeTiming fields, which can make the test flaky on slow machines. This patch rewrites the test to check the relative values instead. It also updates the test to make it work with workers instead of directly skipping in workers. PR-URL: #49197 Refs: nodejs/reliability#638 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0261c5d - Browse repository at this point
Copy the full SHA 0261c5dView commit details -
doc: use same name in the doc as in the code
Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy PR-URL: #49216 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bf22a5f - Browse repository at this point
Copy the full SHA bf22a5fView commit details -
build: expand when we run internet tests
Refs: #49203 Changes slipped into v18.x regressed test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #49218 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9e1c531 - Browse repository at this point
Copy the full SHA 9e1c531View commit details -
src: add a condition if the argument of
DomainToUnicode
is emptyPR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c33731 - Browse repository at this point
Copy the full SHA 8c33731View commit details -
src: use ARES_SUCCESS instead of 0
PR-URL: #49048 Refs: #48834 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 158c91a - Browse repository at this point
Copy the full SHA 158c91aView commit details -
test,benchmark: use
tmpdir.fileURL()
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b011a49 - Browse repository at this point
Copy the full SHA b011a49View commit details -
src: remove unused function
GetName()
in node_perfPR-URL: #49244 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 066d9d4 - Browse repository at this point
Copy the full SHA 066d9d4View commit details -
doc: clarify use of Uint8Array for n-api
`napi_get_buffer_info` always supported receiving `Uint8Array` as a `value` argument because `node::Buffer` is a subclass of `Uint8Array` and the underlying V8 APIs don't distinguish between two. With this change we mark both types as supported by the API so that the user code doesn't have to unknowingly use oficially unsupported type of the `value` argument. PR-URL: #48742 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9c2a3f - Browse repository at this point
Copy the full SHA f9c2a3fView commit details -
doc: update description for
percent_encode
sets inWHATWG API
PR-URL: #49258 Refs: https://url.spec.whatwg.org/#percent-encoded-bytes Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c70945d - Browse repository at this point
Copy the full SHA c70945dView commit details -
meta: move one or more collaborators to emeritus
PR-URL: #49264 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 155a275 - Browse repository at this point
Copy the full SHA 155a275View commit details -
worker: protect against user mutating well-known prototypes
PR-URL: #49270 Fixes: #49259 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 879b958 - Browse repository at this point
Copy the full SHA 879b958View commit details -
doc: fix typo in
stream.finished
documentationPR-URL: #49271 Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f181c37 - Browse repository at this point
Copy the full SHA f181c37View commit details -
doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc
The code was changed in #48501 but the doc was missed. PR-URL: #49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f771ca - Browse repository at this point
Copy the full SHA 3f771caView commit details -
stream: add
highWaterMark
for the map operatorthis is done so we don't wait for the first items to finish before starting new ones Fixes: #46132 Co-authored-by: Robert Nagy <[email protected]> PR-URL: #49249 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 651e450 - Browse repository at this point
Copy the full SHA 651e450View commit details -
build: add symlink to
compile_commands.json
file if neededUsually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #49260 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 075c57e - Browse repository at this point
Copy the full SHA 075c57eView commit details -
doc: modify param description for end(),write() in
StringDecoder
PR-URL: #49285 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ca85b5 - Browse repository at this point
Copy the full SHA 9ca85b5View commit details -
test: fix compiler warning in NodeCryptoEnv
This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: #47160 PR-URL: #49206 Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ddebd29 - Browse repository at this point
Copy the full SHA ddebd29View commit details -
fs: remove redundant code in readableWebStream()
Remove redundant code by moving it to outside of `if/else`. Plus, make `options` optional in doc. PR-URL: #49298 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69b7f91 - Browse repository at this point
Copy the full SHA 69b7f91View commit details -
doc: avoid "not currently recommended"
Compromised algorithms will never again be recommended, so remove the qualifier "currently". PR-URL: #49300 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4ba11e3 - Browse repository at this point
Copy the full SHA 4ba11e3View commit details -
policy: fix path to URL conversion
PR-URL: #49133 Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4f26f4 - Browse repository at this point
Copy the full SHA d4f26f4View commit details -
doc: update
options.filter
description forfs.cp
PR-URL: #49289 Fixes: #49092 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0dda724 - Browse repository at this point
Copy the full SHA 0dda724View commit details -
tools: update lint-md-dependencies
- @rollup/[email protected] - [email protected] - [email protected] PR-URL: #49253 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01b2588 - Browse repository at this point
Copy the full SHA 01b2588View commit details -
stream: use Buffer.from when constructor is a Buffer
When using BYOB streams, it's possible for the constructor in readableByteStreamControllerConvertPullIntoDescriptor to be a node Buffer. If it is, use `Buffer.from` over `new ctor`. Fixes #49245 PR-URL: #49250 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee4fc7d - Browse repository at this point
Copy the full SHA ee4fc7dView commit details -
doc: use
cjs
as block code's type inMockTimers
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists. PR-URL: #49309 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 62f823d - Browse repository at this point
Copy the full SHA 62f823dView commit details -
doc: update outdated reference to NIST SP 800-131A
NIST SP 800-131A Rev. 1 has been withdrawn. Replace the reference with a link to NIST SP 800-131A Rev. 2. PR-URL: #49316 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 45caad8 - Browse repository at this point
Copy the full SHA 45caad8View commit details -
doc: add print results for examples in
StringDecoder
PR-URL: #49326 Refs: #49143 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f1a237 - Browse repository at this point
Copy the full SHA 3f1a237View commit details -
tools: update lint-md-dependencies
PR-URL: #49342 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6522a2 - Browse repository at this point
Copy the full SHA b6522a2View commit details
Commits on Nov 27, 2023
-
test: migrate message source map tests from Python to JS
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: #47707 test: migrate message source map tests from Python to JS PR-URL: #49238 Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 107015b - Browse repository at this point
Copy the full SHA 107015bView commit details -
test: rename test-crypto-modp1-error
This test is not specific to modp1 at all, it might as well use any of the other groups. Refs: #40451 PR-URL: #49348 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f1a1ae - Browse repository at this point
Copy the full SHA 5f1a1aeView commit details -
doc: add news issue for Diagnostics WG
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #49306 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4c93905 - Browse repository at this point
Copy the full SHA 4c93905View commit details -
node-api: fix compiler warning in node_api.h
Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build. PR-URL: #49103 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 48a1b93 - Browse repository at this point
Copy the full SHA 48a1b93View commit details -
test_runner: add support for setImmediate
PR-URL: #49397 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11fbd92 - Browse repository at this point
Copy the full SHA 11fbd92View commit details -
test: split test-crypto-keygen.js
To avoid timing out on ARM machines in the CI. PR-URL: #49221 Refs: #49202 Refs: #41206 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 344592d - Browse repository at this point
Copy the full SHA 344592dView commit details -
test: split JWK async elliptic curve keygen tests
PR-URL: #49221 Refs: #49202 Refs: #41206 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 958e114 - Browse repository at this point
Copy the full SHA 958e114View commit details -
test: reduce length in crypto keygen tests
PR-URL: #49221 Refs: #49202 Refs: #41206 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67cb6f9 - Browse repository at this point
Copy the full SHA 67cb6f9View commit details -
url: handle unicode hostname if empty
PR-URL: #49396 Fixes: #48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f256b16 - Browse repository at this point
Copy the full SHA f256b16View commit details -
net: fix crash due to simultaneous close/shutdown on JS Stream Sockets
A JS stream socket wraps a stream, exposing it as a socket for something on top which needs a socket specifically (e.g. an HTTP server). If the internal stream is closed in the same tick as the layer on top attempts to close this stream, the race between doShutdown and doClose results in an uncatchable exception. A similar race can happen with doClose and doWrite. It seems legitimate these can happen in parallel, so this resolves that by explicitly detecting and handling that situation: if a close is in progress, both doShutdown & doWrite allow doClose to run finishShutdown/Write for them, cancelling the operation, without trying to use this._handle (which will be null) in the meantime. PR-URL: #49400 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 03063bd - Browse repository at this point
Copy the full SHA 03063bdView commit details -
net: use asserts in JS Socket Stream to catch races in future
PR-URL: #49400 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for daca87b - Browse repository at this point
Copy the full SHA daca87bView commit details -
url: validate
pathToFileURL(path)
argument as stringPR-URL: #49161 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ac27431 - Browse repository at this point
Copy the full SHA ac27431View commit details -
doc: fix node-api call example
The `return` statement should not be enclosed in a nested conditional branch. PR-URL: #49395 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e26b89e - Browse repository at this point
Copy the full SHA e26b89eView commit details -
test: avoid copying test source files
Converting the helper functions to be inlined and making the helper file header only. PR-URL: #49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c5857bd - Browse repository at this point
Copy the full SHA c5857bdView commit details -
node-api: enable uncaught exceptions policy by default
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: #49313 Refs: #36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for edef4fa - Browse repository at this point
Copy the full SHA edef4faView commit details -
node-api: run finalizers directly from GC
PR-URL: #42651 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5148f03 - Browse repository at this point
Copy the full SHA 5148f03View commit details -
node-api: update headers for better wasm support
PR-URL: #49037 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f449b22 - Browse repository at this point
Copy the full SHA f449b22View commit details -
tools: update lint-md-dependencies to [email protected] [email protected]
PR-URL: #49584 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3511b13 - Browse repository at this point
Copy the full SHA 3511b13View commit details -
tools: update lint-md-dependencies to [email protected]
PR-URL: #49679 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ad6e7a6 - Browse repository at this point
Copy the full SHA ad6e7a6View commit details -
tools: update lint-md-dependencies
- [email protected] - [email protected] - [email protected] - [email protected] PR-URL: #49983 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 07941a3 - Browse repository at this point
Copy the full SHA 07941a3View commit details -
tools: update lint-md-dependencies
- @rollup/[email protected] - @rollup/[email protected] - [email protected] PR-URL: #50083 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3b65c61 - Browse repository at this point
Copy the full SHA 3b65c61View commit details -
test: reorder test files fixtures for better understanding
PR-URL: #48787 Backport-PR-URL: #49225 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fea550 - Browse repository at this point
Copy the full SHA 0fea550View commit details -
test_runner: fix global after not failing the tests
PR-URL: #48913 Backport-PR-URL: #49225 Fixes: #48867 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71f7ed7 - Browse repository at this point
Copy the full SHA 71f7ed7View commit details -
test: remove --no-warnings flag in test_runner fixtures
no longer needed after #48915 fix PR-URL: #48989 Backport-PR-URL: #49225 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e714e6 - Browse repository at this point
Copy the full SHA 7e714e6View commit details -
test_runner: dont set exit code on todo tests
PR-URL: #48929 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 00c70e1 - Browse repository at this point
Copy the full SHA 00c70e1View commit details -
test_runner: expose location of tests
This commit adds each test's line and column number to the reporter output. This will aid in debugging test suite failures when error stacks are not helpful, test suites are large, or tests have the same name. This data is also exposed on the spec reporter. This commit also replaces the filename that was previously being reported, with the filename where the test actually exists. These are normally correct, but could be wrong if tests were run from a file other than the user's entrypoint. PR-URL: #48975 Fixes: #48457 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d61a505 - Browse repository at this point
Copy the full SHA d61a505View commit details -
test_runner: reland run global after() hook earlier
This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (#49059 (comment)) and an additional common.mustCall() in the added test. Refs: #49059 Refs: #49110 PR-URL: #49116 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d839640 - Browse repository at this point
Copy the full SHA d839640View commit details -
test_runner: expose spec reporter as newable function
Fixes: #48112 Ref: #48208 PR-URL: #49184 Refs: #48208 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95cc98e - Browse repository at this point
Copy the full SHA 95cc98eView commit details -
test_runner: preserve original property descriptor
PR-URL: #49433 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 760c982 - Browse repository at this point
Copy the full SHA 760c982View commit details -
meta: bump actions/setup-node from 3.7.0 to 3.8.1
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@e33196f...5e21ff4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #49434 Refs: actions/setup-node@5e21ff4 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dad5785 - Browse repository at this point
Copy the full SHA dad5785View commit details -
meta: bump step-security/harden-runner from 2.5.0 to 2.5.1
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@cba0d00...8ca2b8b) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #49435 Refs: step-security/harden-runner@8ca2b8b Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fc0b88 - Browse repository at this point
Copy the full SHA 0fc0b88View commit details -
test_runner: fix typescript coverage
PR-URL: #49406 Fixes: #49398 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 429846f - Browse repository at this point
Copy the full SHA 429846fView commit details -
test_runner: add jsdocs to MockTimers
Signed-off-by: Erick Wendel <[email protected]> PR-URL: #49476 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5949ae0 - Browse repository at this point
Copy the full SHA 5949ae0View commit details -
test_runner: fix invalid timer call
Signed-off-by: Erick Wendel <[email protected]> PR-URL: #49477 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ba57c24 - Browse repository at this point
Copy the full SHA ba57c24View commit details -
test_runner: add jsdocs to mock.js
PR-URL: #49555 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 76a3563 - Browse repository at this point
Copy the full SHA 76a3563View commit details -
test_runner: add junit reporter
PR-URL: #49614 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 059b194 - Browse repository at this point
Copy the full SHA 059b194View commit details -
test_runner: fix test runner watch mode when no positional arguments
PR-URL: #49578 Fixes: #49617 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e459598 - Browse repository at this point
Copy the full SHA e459598View commit details -
test: mark test-runner-watch-mode as flaky
PR-URL: #49627 Refs: #49605 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5df2352 - Browse repository at this point
Copy the full SHA 5df2352View commit details -
doc: remove
@anonrig
from performance initiativePR-URL: #49641 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 07c3b88 - Browse repository at this point
Copy the full SHA 07c3b88View commit details -
test_runner: catch reporter errors
PR-URL: #49646 Fixes: #48937 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 103c4a0 - Browse repository at this point
Copy the full SHA 103c4a0View commit details -
test_runner: accept
testOnly
inrun
PR-URL: #49753 Fixes: #49733 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b283ae4 - Browse repository at this point
Copy the full SHA b283ae4View commit details -
test_runner: replace spurious if with else
There is an `if` statement that likely should have been an `else` in the original PR. Refs: #48915 PR-URL: #49943 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d9c371 - Browse repository at this point
Copy the full SHA 1d9c371View commit details -
test_runner: add test location for FileTests
This commit adds the previously missing test location for FileTest tests. Fixes: #49926 Fixes: #49927 PR-URL: #49999 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54168b7 - Browse repository at this point
Copy the full SHA 54168b7View commit details -
test_runner, cli: add --test-concurrency flag
This commit adds a new --test-concurrency CLI flag that controls the parallelism of the test runner CLI. PR-URL: #49996 Fixes: #49487 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 428301a - Browse repository at this point
Copy the full SHA 428301aView commit details -
test_runner,test: fix flaky test-runner-cli-concurrency.js
This test was flaky on Windows when trying to clean up the tmp directory, probably because it relied on child processes timing out and being killed. This commit updates the test to check for debug output from the test runner. This should be adequate because the original change was effectively: let concurrency = getOptionValue('--test-concurrency') || true; The test runner now logs the value of the concurrency variable. Fixes: #50101 PR-URL: #50108 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4b2e258 - Browse repository at this point
Copy the full SHA 4b2e258View commit details -
Revert "test: mark test-http-regr-gh-2928 as flaky"
This reverts commit 48fcb20. Refs: 18e00a577d74 PR-URL: #49708 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d75da4 - Browse repository at this point
Copy the full SHA 1d75da4View commit details -
test: deflake test-runner-output
PR-URL: #49878 Fixes: #49853 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5820d7e - Browse repository at this point
Copy the full SHA 5820d7eView commit details -
test: set
test-runner-watch-mode
as flakyPR-URL: #50221 Refs: #49985 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5953a25 - Browse repository at this point
Copy the full SHA 5953a25View commit details -
test: set test-worker-nearheaplimit-deadlock flaky
The test is only flaky on x86 Windows. Fixes: #50220 PR-URL: #50238 Refs: #49962 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 54f3d87 - Browse repository at this point
Copy the full SHA 54f3d87View commit details -
test: set parallel http server test as flaky
Ref: #43465 PR-URL: #50227 Refs: #43465 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cb0bd21 - Browse repository at this point
Copy the full SHA cb0bd21View commit details -
test: set inspector async hook test as flaky
Ref: #50222 PR-URL: #50252 Refs: #50222 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 866a399 - Browse repository at this point
Copy the full SHA 866a399View commit details -
test: set
test-structuredclone-*
as flakyPR-URL: #50261 Refs: #50260 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 83e339d - Browse repository at this point
Copy the full SHA 83e339dView commit details -
test: set crypto-timing test as flaky
PR-URL: #50232 Refs: #38226 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c05c25 - Browse repository at this point
Copy the full SHA 0c05c25View commit details -
test: set
test-cli-node-options
as flakyPR-URL: #50296 Refs: #50295 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e81b066 - Browse repository at this point
Copy the full SHA e81b066View commit details -
test: set test-worker-nearheaplimit-deadlock flaky
PR-URL: #50277 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b41aa7b - Browse repository at this point
Copy the full SHA b41aa7bView commit details -
test: set inspector async stack test as flaky
#50243 PR-URL: #50244 Refs: #50243 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 91a3b57 - Browse repository at this point
Copy the full SHA 91a3b57View commit details -
test: set
test-emit-after-on-destroyed
as flakyRef: #50245 PR-URL: #50246 Refs: #50245 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1047d95 - Browse repository at this point
Copy the full SHA 1047d95View commit details -
test: set
test-watch-mode-inspect
as flakyPR-URL: #50259 Refs: #49933 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0bb30c - Browse repository at this point
Copy the full SHA a0bb30cView commit details -
stream: use bitmap in readable state
PR-URL: #49745 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fae60c5 - Browse repository at this point
Copy the full SHA fae60c5View commit details -
meta: bump actions/checkout from 3.5.3 to 3.6.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #49436 Refs: actions/checkout@f43a0e5 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 26c5c3c - Browse repository at this point
Copy the full SHA 26c5c3cView commit details -
meta: bump actions/checkout from 3.6.0 to 4.1.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #50001 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a107f8 - Browse repository at this point
Copy the full SHA 3a107f8View commit details -
meta: bump github/codeql-action from 2.21.2 to 2.21.5
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.2 to 2.21.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0ba4244...00e563e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #49438 Refs: github/codeql-action@00e563e Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6591a03 - Browse repository at this point
Copy the full SHA 6591a03View commit details -
meta: bump github/codeql-action from 2.21.5 to 2.21.9
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.5 to 2.21.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@00e563e...ddccb87) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #50002 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7927032 - Browse repository at this point
Copy the full SHA 7927032View commit details -
meta: bump actions/cache from 3.3.1 to 3.3.2
Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@88522ab...704facf) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #50003 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 98294fd - Browse repository at this point
Copy the full SHA 98294fdView commit details -
meta: bump actions/upload-artifact from 3.1.2 to 3.1.3
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b7f8ab...a8a3f3a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #50000 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dee7dc5 - Browse repository at this point
Copy the full SHA dee7dc5View commit details -
meta: add test/reporters to codeowners
PR-URL: #49186 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d6daf0 - Browse repository at this point
Copy the full SHA 5d6daf0View commit details -
meta: remove modules team from CODEOWNERS
Currently the modules team is inactive and the loaders team functions as the team in charge of these files/areas. cc @nodejs/modules in case anyone wants to join the @nodejs/loaders team since the modules may be removed. PR-URL: #49412 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2827779 - Browse repository at this point
Copy the full SHA 2827779View commit details -
meta: bump rtCamp/action-slack-notify from 2.2.0 to 2.2.1
Bumps [rtCamp/action-slack-notify](https://github.com/rtcamp/action-slack-notify) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rtcamp/action-slack-notify/releases) - [Commits](rtCamp/action-slack-notify@12e36fc...b24d75f) --- updated-dependencies: - dependency-name: rtCamp/action-slack-notify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #49437 Refs: rtCamp/action-slack-notify@b24d75f Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 213a9f8 - Browse repository at this point
Copy the full SHA 213a9f8View commit details -
meta: add primordials strategic initiative
PR-URL: #49706 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dc70c44 - Browse repository at this point
Copy the full SHA dc70c44View commit details -
PR-URL: #49755 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 332d2ae - Browse repository at this point
Copy the full SHA 332d2aeView commit details -
meta: update website team with new name
Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: #49883 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d24c3a0 - Browse repository at this point
Copy the full SHA d24c3a0View commit details -
meta: ping TSC for offboarding
Refs: #49264 PR-URL: #50147 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5b9575d - Browse repository at this point
Copy the full SHA 5b9575dView commit details -
meta: move Trott to TSC regular member
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: #50297 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7778e19 - Browse repository at this point
Copy the full SHA 7778e19View commit details -
test: print instruction for creating missing snapshot in assertSnapshot
PR-URL: #48914 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a2ca1a6 - Browse repository at this point
Copy the full SHA a2ca1a6View commit details -
test: replace forEach with for..of in test-http2-client-destroy.js
PR-URL: #49820 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 128ca3e - Browse repository at this point
Copy the full SHA 128ca3eView commit details -
test: replace forEach with for..of in test-http2-server
PR-URL: #49819 Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bbd302b - Browse repository at this point
Copy the full SHA bbd302bView commit details -
test: replace forEach with for..of in test-net-isipv4.js
PR-URL: #49822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2f0ffde - Browse repository at this point
Copy the full SHA 2f0ffdeView commit details -
test: replace forEach with for..of in test-http-perf_hooks.js
PR-URL: #49818 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f39f8e - Browse repository at this point
Copy the full SHA 7f39f8eView commit details -
doc: drop github actions check in sec release process
PR-URL: #48978 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1096837 - Browse repository at this point
Copy the full SHA 1096837View commit details -
PR-URL: #47886 Backport-PR-URL: #50105 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 916a63b - Browse repository at this point
Copy the full SHA 916a63bView commit details -
url: fix
isURL
detection by checkingpath
Fixes: #48921 PR-URL: #48928 Backport-PR-URL: #50105 Fixes: getsentry/sentry-javascript#8552 Fixes: request/request#3458 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fc15b6 - Browse repository at this point
Copy the full SHA 7fc15b6View commit details -
https: fix connection checking interval not clearing on server close
The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. Fixes: #48373 PR-URL: #48383 Backport-PR-URL: #50194 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2969722 - Browse repository at this point
Copy the full SHA 2969722View commit details -
deps: V8: cherry-pick 70caf337c3f6
Original commit message: [riscv64] Fix the StaticStackFrameSize Update the size to kTierupBudgetOffset. Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492 Reviewed-by: ji qiu <[email protected]> Commit-Queue: Yahan Lu <[email protected]> Auto-Submit: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/main@{#79978} Refs: v8/v8@70caf33 PR-URL: #50506 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7af5427 - Browse repository at this point
Copy the full SHA 7af5427View commit details -
tools: fix --v8-non-optimized-debug for v18.x
Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches. PR-URL: #50612 Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a1c9403 - Browse repository at this point
Copy the full SHA a1c9403View commit details
Commits on Nov 28, 2023
-
2023-11-29, Version 18.19.0 'Hydrogen' (LTS)
Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) #50531 doc: * move and rename loaders section (Geoffrey Booth) #49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * unflag import.meta.resolve (Guy Bedford) #49028 * move hook execution to separate thread (Jacob Smith) #44710 * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) #44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) #49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 PR-URL: #50953
Configuration menu - View commit details
-
Copy full SHA for 9e0c715 - Browse repository at this point
Copy the full SHA 9e0c715View commit details