Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.19.0 release proposal #50953

Merged
merged 364 commits into from
Nov 29, 2023
Merged

v18.19.0 release proposal #50953

merged 364 commits into from
Nov 29, 2023
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Nov 23, 2023

  1. esm: handle more error types thrown from the loader thread

    PR-URL: #48247
    Backport-PR-URL: #50669
    Refs: #48240
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9938a8b View commit details
    Browse the repository at this point in the history
  2. esm: handle globalPreload hook returning a nullish value

    PR-URL: #48249
    Backport-PR-URL: #50669
    Fixes: #48240
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    655111f View commit details
    Browse the repository at this point in the history
  3. esm: remove support for arrays in import internal method

    This avoids initializing arrays that we never use, and simplifies the
    implementation overall.
    
    PR-URL: #48296
    Backport-PR-URL: #50669
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1c7be60 View commit details
    Browse the repository at this point in the history
  4. typings: fix JSDoc in ESM loader modules

    PR-URL: #48424
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Mestery <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2ef80f1 View commit details
    Browse the repository at this point in the history
  5. module: implement register utility

    PR-URL: #46826
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    jlenon7 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    65dfe85 View commit details
    Browse the repository at this point in the history
  6. esm: add back globalPreload tests and fix failing ones

    PR-URL: #48779
    Backport-PR-URL: #50669
    Fixes: #48778
    Fixes: #48516
    Refs: #46402
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    63aa5d7 View commit details
    Browse the repository at this point in the history
  7. esm: unflag Module.register and allow nested loader import()

    Major functional changes:
    
    - Allow `import()` to work within loaders that require other loaders,
    - Unflag the use of `Module.register`.
    
    A new interface `Customizations` has been created in order to unify
    `ModuleLoader` (previously `DefaultModuleLoader`), `Hooks` and
    `CustomizedModuleLoader` all of which now implement it:
    
    ```ts
    interface LoadResult {
      format: ModuleFormat;
      source: ModuleSource;
    }
    
    interface ResolveResult {
      format: string;
      url: URL['href'];
    }
    
    interface Customizations {
      allowImportMetaResolve: boolean;
      load(url: string, context: object): Promise<LoadResult>
      resolve(
        originalSpecifier:
        string, parentURL: string,
        importAssertions: Record<string, string>
      ): Promise<ResolveResult>
      resolveSync(
        originalSpecifier:
        string, parentURL: string,
        importAssertions: Record<string, string>
      ) ResolveResult;
      register(specifier: string, parentUrl: string): any;
      forceLoadHooks(): void;
      importMetaInitialize(meta, context, loader): void;
    }
    ```
    
    The `ModuleLoader` class now has `setCustomizations` which takes an
    object of this shape and delegates its responsibilities to this object
    if present.
    
    Note that two properties `allowImportMetaResolve` and `resolveSync`
    exist now as a mechanism for `import.meta.resolve` – since `Hooks`
    does not implement `resolveSync` other loaders cannot use
    `import.meta.resolve`; `allowImportMetaResolve` is a way of checking
    for that case instead of invoking `resolveSync` and erroring.
    
    Fixes #48515
    Closes #48439
    
    PR-URL: #48559
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    izaakschroeder authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    03c1b5e View commit details
    Browse the repository at this point in the history
  8. module: ensure successful import returns the same result

    PR-URL: #46662
    Backport-PR-URL: #50669
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    14e148e View commit details
    Browse the repository at this point in the history
  9. test: fix es-module/test-esm-initialization

    PR-URL: #48880
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f02637e View commit details
    Browse the repository at this point in the history
  10. fs: make mkdtemp accept buffers and URL

    PR-URL: #48828
    Backport-PR-URL: #50669
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    LiviaMedeiros authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    48c25b1 View commit details
    Browse the repository at this point in the history
  11. test: fix some assumptions in tests

    Some tests are assuming they will be run from a directory that do not
    contain any quote or special character in its path. That assumption is
    not necessary, using `JSON.stringify` or `pathToFileURL` ensures the
    test can be run whatever the path looks like.
    
    PR-URL: #48958
    Backport-PR-URL: #50669
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    adb9280 View commit details
    Browse the repository at this point in the history
  12. test: order common.mjs in ASCII order

    PR-URL: #48960
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a9347a4 View commit details
    Browse the repository at this point in the history
  13. test: fix snapshot tests when cwd contains spaces or backslashes

    Both are valid characters for file names on non-Windows systems.
    
    PR-URL: #48959
    Backport-PR-URL: #50669
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3424793 View commit details
    Browse the repository at this point in the history
  14. esm: fix typo parentUrl -> parentURL

    PR-URL: #48999
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f96b610 View commit details
    Browse the repository at this point in the history
  15. esm: add initialize hook, integrate with register

    Follows @giltayar's proposed API:
    
    > `register` can pass any data it wants to the loader, which will be
    passed to the exported `initialize` function of the loader.
    Additionally, if the user of `register` wants to communicate with the
    loader, it can just create a `MessageChannel` and pass the port to the
    loader as data.
    
    The `register` API is now:
    
    ```ts
    interface Options {
      parentUrl?: string;
      data?: any;
      transferList?: any[];
    }
    
    function register(loader: string, parentUrl?: string): any;
    function register(loader: string, options?: Options): any;
    ```
    
    This API is backwards compatible with the old one (new arguments are
    optional and at the end) and allows for passing data into the new
    `initialize` hook. If this hook returns data it is passed back to
    `register`:
    
    ```ts
    function initialize(data: any): Promise<any>;
    ```
    
    **NOTE**: Currently there is no mechanism for a loader to exchange
    ownership of something back to the caller.
    
    Refs: nodejs/loaders#147
    PR-URL: #48842
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    izaakschroeder authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    10e7c3a View commit details
    Browse the repository at this point in the history
  16. test: use fixtures.fileURL when appropriate

    PR-URL: #48990
    Backport-PR-URL: #50669
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d5a1153 View commit details
    Browse the repository at this point in the history
  17. esm: protect ERR_UNSUPPORTED_DIR_IMPORT against prototype pollution

    PR-URL: #49060
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    385f24c View commit details
    Browse the repository at this point in the history
  18. test: reduce flakiness of test-esm-loader-hooks

    PR-URL: #49105
    Backport-PR-URL: #50669
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    26f0166 View commit details
    Browse the repository at this point in the history
  19. esm: import.meta.resolve exact module not found errors should return

    PR-URL: #49038
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    guybedford authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ef43f08 View commit details
    Browse the repository at this point in the history
  20. esm: unflag import.meta.resolve

    PR-URL: #49028
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    guybedford authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c1a8439 View commit details
    Browse the repository at this point in the history
  21. esm: fix globalPreload warning

    PR-URL: #49069
    Backport-PR-URL: #50669
    Fixes: #49026
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    01ca6d2 View commit details
    Browse the repository at this point in the history
  22. doc: fix name of the flag in initialize() docs

    PR-URL: #49158
    Backport-PR-URL: #50669
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2fef28b View commit details
    Browse the repository at this point in the history
  23. test: refactor test-esm-loader-hooks for easier debugging

    - Always check stderr before stdout as the former would contain error
      information.
    - Always match the full stdout to avoid surprises.
    - Use `deepStrictEqual` when appropriate to get more informative test
      failures.
    - Remove leading slashes from relative paths/URLs to not confuse them
      with absolute paths.
    - Remove unnecessary `--no-warnings` flag.
    
    PR-URL: #49131
    Backport-PR-URL: #50669
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e8d475f View commit details
    Browse the repository at this point in the history
  24. doc: caveat unavailability of import.meta.resolve in custom loaders

    PR-URL: #49242
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    JakobJingleheimer authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    58eaf3f View commit details
    Browse the repository at this point in the history
  25. test: reduce flakiness of test-esm-loader-hooks

    PR-URL: #49248
    Backport-PR-URL: #50669
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e1c6f46 View commit details
    Browse the repository at this point in the history
  26. doc: add signature for module.register

    PR-URL: #49251
    Backport-PR-URL: #50669
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    258df0e View commit details
    Browse the repository at this point in the history
  27. esm: refactor mocking test

    PR-URL: #49465
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d1f5514 View commit details
    Browse the repository at this point in the history
  28. doc: move and rename loaders section

    PR-URL: #49261
    Backport-PR-URL: #50669
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ed2d46f View commit details
    Browse the repository at this point in the history
  29. doc: update module hooks docs

    PR-URL: #49265
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1ac389e View commit details
    Browse the repository at this point in the history
  30. doc: edit import.meta.resolve documentation

    PR-URL: #49247
    Backport-PR-URL: #50669
    Refs: #49028
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c20fdb4 View commit details
    Browse the repository at this point in the history
  31. test: add tmpdir.fileURL()

    PR-URL: #49040
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    LiviaMedeiros authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    65058d9 View commit details
    Browse the repository at this point in the history
  32. esm: refactor test-esm-named-exports

    PR-URL: #49493
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9b7c9d9 View commit details
    Browse the repository at this point in the history
  33. esm: refactor test-esm-loader-resolve-type

    PR-URL: #49493
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0875867 View commit details
    Browse the repository at this point in the history
  34. esm: remove return value for Module.register

    The current API shape si not great because it's too limited and
    redundant with the use of `MessagePort`.
    
    PR-URL: #49529
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4be5612 View commit details
    Browse the repository at this point in the history
  35. typings: fix missing property in ExportedHooks

    PR-URL: #49567
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9456094 View commit details
    Browse the repository at this point in the history
  36. test: isolate globalPreload tests

    PR-URL: #49545
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    65201ab View commit details
    Browse the repository at this point in the history
  37. test: increase coverage of Module.register and initialize hook

    PR-URL: #49532
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    866d646 View commit details
    Browse the repository at this point in the history
  38. esm: clarify ERR_REQUIRE_ESM errors

    In #39175, better ESM errors were introduced. This commit tweaks the
    language in the error slightly to make it clear that there are three
    different options to resolve the error.
    
    Refs: #39175
    PR-URL: #49521
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    danielcompton authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    51ced0f View commit details
    Browse the repository at this point in the history
  39. esm: fix support for URL instances in register

    PR-URL: #49655
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    47193a3 View commit details
    Browse the repository at this point in the history
  40. esm: update loaders warning

    PR-URL: #49633
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    12cb700 View commit details
    Browse the repository at this point in the history
  41. esm: fix return type of import.meta.resolve

    PR-URL: #49698
    Backport-PR-URL: #50669
    Fixes: #49695
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    46d730a View commit details
    Browse the repository at this point in the history
  42. doc: add missing history info for import.meta.resolve

    PR-URL: #49700
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    73a7e00 View commit details
    Browse the repository at this point in the history
  43. esm: identify parent importing a url with invalid host

    PR-URL: #49736
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    JakobJingleheimer authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    ed8dd33 View commit details
    Browse the repository at this point in the history
  44. esm: fix cache collision on JSON files using file: URL

    PR-URL: #49887
    Backport-PR-URL: #50669
    Fixes: #49724
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c12685f View commit details
    Browse the repository at this point in the history
  45. lib: merge cjs and esm package json reader caches

    PR-URL: #48477
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    anonrig authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fe26f8a View commit details
    Browse the repository at this point in the history
  46. esm: require braces for modules code

    PR-URL: #49657
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    957725f View commit details
    Browse the repository at this point in the history
  47. module, esm: jsdoc for modules files

    PR-URL: #49523
    Backport-PR-URL: #50669
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9757989 View commit details
    Browse the repository at this point in the history
  48. module: move helpers out of cjs loader

    PR-URL: #49912
    Backport-PR-URL: #50669
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8c55f31 View commit details
    Browse the repository at this point in the history
  49. esm: improve JSDoc annotation of internal functions

    Co-authored-by: Geoffrey Booth <[email protected]>
    PR-URL: #49959
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    2 people authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    72644d6 View commit details
    Browse the repository at this point in the history
  50. esm: --experimental-default-type flag to flip module defaults

    PR-URL: #49869
    Backport-PR-URL: #50669
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    56bd9a8 View commit details
    Browse the repository at this point in the history
  51. esm: unflag extensionless javascript and wasm in module scope

    PR-URL: #49974
    Backport-PR-URL: #50669
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fe69198 View commit details
    Browse the repository at this point in the history
  52. util: add getCwdSafe internal util fn

    This function was first implemented in #46826, but at some point
    of the PR implementation this fn was no longer related to the PR.
    
    Refs: #46826 (comment)
    PR-URL: #48434
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    jlenon7 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a67fa2a View commit details
    Browse the repository at this point in the history
  53. esm: bypass CommonJS loader under --default-type

    PR-URL: #49986
    Backport-PR-URL: #50669
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c3c945e View commit details
    Browse the repository at this point in the history
  54. tools: update eslint to 8.45.0

    PR-URL: #48793
    Backport-PR-URL: #50669
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e963245 View commit details
    Browse the repository at this point in the history
  55. tools: update eslint to 8.46.0

    PR-URL: #48966
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4880a05 View commit details
    Browse the repository at this point in the history
  56. tools: update eslint to 8.47.0

    PR-URL: #49124
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0940de3 View commit details
    Browse the repository at this point in the history
  57. tools: update eslint to 8.48.0

    PR-URL: #49343
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    92d2186 View commit details
    Browse the repository at this point in the history
  58. tools: update eslint to 8.49.0

    PR-URL: #49586
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1c1cbf0 View commit details
    Browse the repository at this point in the history
  59. tools: update eslint to 8.50.0

    PR-URL: #49989
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    b8d2a29 View commit details
    Browse the repository at this point in the history
  60. tools: update eslint to 8.51.0

    PR-URL: #50084
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    6cf8dd9 View commit details
    Browse the repository at this point in the history
  61. esm: use import attributes instead of import assertions

    The old import assertions proposal has been
    renamed to "import attributes" with the follwing major changes:
    
    1. The keyword is now `with` instead of `assert`.
    2. Unknown assertions cause an error rather than being ignored,
    
    This commit updates the documentation to encourage folks to use the new
    syntax, and add aliases for module customization hooks.
    
    PR-URL: #50140
    Backport-PR-URL: #50669
    Fixes: #50134
    Refs: v8/v8@159c82c
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    92734d4 View commit details
    Browse the repository at this point in the history
  62. test: deflake test-esm-loader-resolve-type

    PR-URL: #50273
    Backport-PR-URL: #50669
    Fixes: #50040
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d5cc5d7 View commit details
    Browse the repository at this point in the history
  63. test: deflake test-loaders-workers-spawned

    PR-URL: #50251
    Backport-PR-URL: #50669
    Fixes: #50247
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c1a8ae3 View commit details
    Browse the repository at this point in the history
  64. vm: use import attributes instead of import assertions

    The old import assertions proposal has been
    renamed to "import attributes" with the following major changes:
    
    1. The keyword is now `with` instead of `assert`.
    2. Unknown assertions cause an error rather than being ignored.
    
    This PR updates the documentation to encourage folks to use the new
    syntax, and add aliases to preserve backward compatibility.
    
    PR-URL: #50141
    Backport-PR-URL: #50669
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e96f7ef View commit details
    Browse the repository at this point in the history
  65. test: refactor test-node-output-errors

    The main reason is to not have the test fail if the CWD contains some
    special URL chars.
    
    PR-URL: #48992
    Backport-PR-URL: #50669
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    aduh95 authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    48f6d9a View commit details
    Browse the repository at this point in the history
  66. test: fix edge snapshot stack traces

    PR-URL: #49659
    Backport-PR-URL: #50669
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    GeoffreyBooth authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    00c0853 View commit details
    Browse the repository at this point in the history
  67. tools: skip ruff on tools/node_modules

    PR-URL: #49838
    Backport-PR-URL: #50669
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    MoLow authored and targos committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a98addb View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. deps: V8: cherry-pick 1a782f6543ae

    Original commit message:
    
        [base] add build flag to use MADV_DONTFORK
    
        Embedders like Node.js and Electron expose fork(2)/execve(2) to their
        users. Unfortunately when the V8 heap is very large, these APIs become
        rather slow on Linux, due to the kernel needing to do all the
        bookkeeping for the forked process (in clone's dup_mmap and execve's
        exec_mmap). Of course, this is useless because the forked child thread
        will never actually need to access the V8 heap.
    
        Add a new build flag v8_enable_private_mapping_fork_optimization which
        marks all pages allocated by OS::Allocate as MADV_DONTFORK. This
        improves the performance of Node.js's fork/execve combination by 10x on
        a 600 MB heap.
    
        Fixed: v8:7381
        Change-Id: Ib649f774d4a932b41886313ce89acc369923699d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4602858
        Commit-Queue: Michael Lippautz <[email protected]>
        Reviewed-by: Michael Lippautz <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#88447}
    
    Refs: v8/v8@1a782f6
    PR-URL: #48523
    Backport-PR-URL: #50098
    Fixes: #25382
    Fixes: #14917
    Refs: nodejs/performance#93
    Refs: nodejs/performance#89
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Juan José Arboleda <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    kvakil authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    747fbb4 View commit details
    Browse the repository at this point in the history
  2. child_process: improve spawn performance on Linux

    Speed up child_process.spawn by enabling the new V8 build flag which
    makes fork/exec faster.
    
    Here are the results of running the existing benchmark. Note that this
    optimization helps more for applications with larger heaps, so this is
    somewhat of an underestimate of the real world performance benefits.
    
    ```console
    $ ./node benchmark/compare.js --runs 15 \
            --new ./node \
            --old ~/node-v20/out/Release/node \
            --filter params child_process > cpr
    $ node-benchmark-compare cpr
                                     confidence improvement  (***)
    methodName='exec' n=1000                ***     60.84 % ±5.43%
    methodName='execFile' n=1000            ***     53.72 % ±3.33%
    methodName='execFileSync' n=1000        ***      9.10 % ±0.84%
    methodName='execSync' n=1000            ***     10.44 % ±0.97%
    methodName='spawn' n=1000               ***     53.10 % ±2.90%
    methodName='spawnSync' n=1000           ***      8.64 % ±1.22%
    
      0.01 false positives, when considering a 0.1% risk acceptance (***)
    ```
    
    Fixes: #25382
    Fixes: #14917
    Refs: nodejs/performance#93
    Refs: nodejs/performance#89
    PR-URL: #48523
    Backport-PR-URL: #50098
    Refs: v8/v8@1a782f6
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Juan José Arboleda <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    kvakil authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7f68e14 View commit details
    Browse the repository at this point in the history
  3. test: add Symbol.dispose support to mock timers

    PR-URL: #48549
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Erick Wendel <[email protected]>
    benjamingr authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    67925bb View commit details
    Browse the repository at this point in the history
  4. bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose}

    Followup to #48518; fixes #48699
    
    PR-URL: #48703
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Nitzan Uziely <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    ljharb authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e08fd98 View commit details
    Browse the repository at this point in the history
  5. deps: update googletest to cc36671

    PR-URL: #48789
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e455dd4 View commit details
    Browse the repository at this point in the history
  6. src: remove OnScopeLeaveImpl's move assignment overload

    ... as it's not valid implementation and also has not been used
    
    PR-URL: #48732
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    CGQAQ authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    358273d View commit details
    Browse the repository at this point in the history
  7. doc: nodejs-social over nodejs/tweet

    PR-URL: #48769
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    74d8f96 View commit details
    Browse the repository at this point in the history
  8. url: reduce pathToFileURL cpp calls

    PR-URL: #48709
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    anonrig authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    2441415 View commit details
    Browse the repository at this point in the history
  9. doc: remove the . in the end to reduce confusing

    PR-URL: #48719
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    CGQAQ authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    dfd368a View commit details
    Browse the repository at this point in the history
  10. meta: add mailmap entry for atlowChemi

    PR-URL: #48810
    Refs: #48806
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    atlowChemi authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f62b242 View commit details
    Browse the repository at this point in the history
  11. tools: update lint-md-dependencies to @rollup/[email protected]

    PR-URL: #48791
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f7d6e9b View commit details
    Browse the repository at this point in the history
  12. doc: declare path on example of async_hooks.executionAsyncId()

    Example is not runnable because `path` is used, but it's not
    declared.
    
    PR-URL: #48556
    Reviewed-By: Luigi Pinca <[email protected]>
    deokjinkim authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    629132d View commit details
    Browse the repository at this point in the history
  13. src: fix nullptr access on realm

    Adding the per-realm binding data tracking introduced a call to a realm
    method when realm was potentially null. This is triggered whenever the
    function is called from `ContextifyContext::New` which passes `nullptr`
    as the `realm`.
    
    PR-URL: #48802
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    jkrems authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f5384c3 View commit details
    Browse the repository at this point in the history
  14. doc: refactor node-api support matrix

    - refactor table so that it does not grow for
      every new version of Node.js
    - refer to latest version of table as the canonical
      reference
    - add info for Node-API v9
    
    Refs: #48277
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #48774
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    mhdawson authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    d4fe00d View commit details
    Browse the repository at this point in the history
  15. doc: add new TSC members

    Refs: nodejs/TSC#1411
    Refs: nodejs/TSC#1410
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #48841
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    mhdawson authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e6d8735 View commit details
    Browse the repository at this point in the history
  16. src: remove unnecessary temporary creation

    PR-URL: #48734
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    CGQAQ authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    97d8749 View commit details
    Browse the repository at this point in the history
  17. fs: remove redundant nullCheck

    PR-URL: #48826
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    LiviaMedeiros authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    ae8bb16 View commit details
    Browse the repository at this point in the history
  18. deps: update zlib to 1.2.13.1-motley-61dc0bd

    PR-URL: #48788
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6059b59 View commit details
    Browse the repository at this point in the history
  19. doc: include experimental features assessment

    PR-URL: #48824
    Refs: nodejs-private/node-private#420
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    a8d5c16 View commit details
    Browse the repository at this point in the history
  20. typings: sync JSDoc with the actual implementation

    JSDoc comment did not match the actual implementation of
    `FileHandle#readableWebStream`.
    
    Refs: #46933
    PR-URL: #48853
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    illusi0n7 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    4d70a2c View commit details
    Browse the repository at this point in the history
  21. src: use ARES_SUCCESS instead of 0

    Since error messages are also using defined values, it is more clear
    to use the defined value even when the operation succeeds.
    
    PR-URL: #48834
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    illusi0n7 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    67dba57 View commit details
    Browse the repository at this point in the history
  22. node-api: avoid macro redefinition

    Even though the redefinition complies with the C standard because the
    second definition is "effectively the same" as the first definition,
    it's best to avoid any redefinition.
    
    Refs: #28237
    Refs: #30006
    PR-URL: #48879
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Vladimir Morozov <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    5796631 View commit details
    Browse the repository at this point in the history
  23. test_runner: fix global before not called when no global test exists

    PR-URL: #48877
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    66ea9bd View commit details
    Browse the repository at this point in the history
  24. doc: add ver of 18.x where Node-api 9 is supported

    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #48876
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    mhdawson authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    cb43717 View commit details
    Browse the repository at this point in the history
  25. http: start connections checking interval on listen

    Co-authored-by: Luigi Pinca <[email protected]>
    PR-URL: #48611
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    2 people authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    8874b2e View commit details
    Browse the repository at this point in the history
  26. tools: update lint-md-dependencies to [email protected]

    PR-URL: #48888
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    1cbb186 View commit details
    Browse the repository at this point in the history
  27. doc: run license-builder

    PR-URL: #48898
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    github-actions[bot] authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    833c643 View commit details
    Browse the repository at this point in the history
  28. deps: update googletest to c875c4e

    PR-URL: #48964
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    588bd5e View commit details
    Browse the repository at this point in the history
  29. tools: update lint-md-dependencies to [email protected]

    PR-URL: #48965
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    9cc3b20 View commit details
    Browse the repository at this point in the history
  30. deps: update zlib to 1.2.13.1-motley-526382e

    PR-URL: #49033
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c15dd66 View commit details
    Browse the repository at this point in the history
  31. deps: update googletest to 7e33b6a

    PR-URL: #49034
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    374ec3d View commit details
    Browse the repository at this point in the history
  32. deps: update zlib to 1.2.13.1-motley-f5fd0ad

    PR-URL: #49252
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    5c33857 View commit details
    Browse the repository at this point in the history
  33. deps: update googletest to 8a6feab

    PR-URL: #49463
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    cd99ee1 View commit details
    Browse the repository at this point in the history
  34. deps: update googletest to d1467f5

    PR-URL: #49676
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    736c869 View commit details
    Browse the repository at this point in the history
  35. deps: update googletest to e47544a

    PR-URL: #49982
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    1b103cc View commit details
    Browse the repository at this point in the history
  36. deps: update googletest to 2dd1c13

    PR-URL: #50081
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e0fd52b View commit details
    Browse the repository at this point in the history
  37. deps: update zlib to 1.2.13.1-motley-fef5869

    PR-URL: #50085
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    49c5495 View commit details
    Browse the repository at this point in the history
  38. tools: limit the number of auto start CIs

    PR-URL: #49067
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    aduh95 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    42846a0 View commit details
    Browse the repository at this point in the history
  39. tools: update lint-md-dependencies to [email protected]

    PR-URL: #49035
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    caa7ecc View commit details
    Browse the repository at this point in the history
  40. test: add expectSyncExitWithoutError() and expectSyncExit() utils

    These can be used to check the state and the output of a child
    process launched with `spawnSync()`. They log additional information
    about the child process when the check fails to facilitate debugging
    test failures.
    
    PR-URL: #49020
    Reviewed-By: Luigi Pinca <[email protected]>
    joyeecheung authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    52d5dd8 View commit details
    Browse the repository at this point in the history
  41. build: fix typo libray -> library (configure.py)

    Signed-off-by: Michal Biesek <[email protected]>
    PR-URL: #49106
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    michalbiesek authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    a781d24 View commit details
    Browse the repository at this point in the history
  42. test_runner: add __proto__ null

    PR-URL: #48663
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    3a74316 View commit details
    Browse the repository at this point in the history
  43. benchmark: add benchmarks for the test_runner

    PR-URL: #48931
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    0d0eb47 View commit details
    Browse the repository at this point in the history
  44. test_runner: unwrap error message in TAP reporter

    The TAP reporter unwraps errors that come from user code. It
    was not properly unwrapping the error message when the failure
    originated from a test hook. This lead to difficult to debug
    errors when TAP output was used. This commit updates the TAP
    reporter to properly unwrap the error message.
    
    Fixes: #48941
    PR-URL: #48942
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    cjihrig authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    9f122be View commit details
    Browse the repository at this point in the history
  45. test_runner: fix todo and only in spec reporter

    PR-URL: #48929
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    MoLow authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    d217435 View commit details
    Browse the repository at this point in the history
  46. test_runner: cleanup test timeout abort listener

    fix #48475
    
    PR-URL: #48915
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    67d7fad View commit details
    Browse the repository at this point in the history
  47. test_runner: fix timeout in *Each hook failing further tests

    PR-URL: #48925
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    fb64d41 View commit details
    Browse the repository at this point in the history
  48. meta: bump actions/setup-python from 4.6.1 to 4.7.0

    Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0.
    - [Release notes](https://github.com/actions/setup-python/releases)
    - [Commits](actions/setup-python@bd6b4b6...61a6322)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-python
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #48983
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    dependabot[bot] authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b0d769f View commit details
    Browse the repository at this point in the history
  49. meta: bump actions/setup-node from 3.6.0 to 3.7.0

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0.
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@64ed1c7...e33196f)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-node
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #48984
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    dependabot[bot] authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    42ac5a6 View commit details
    Browse the repository at this point in the history
  50. meta: bump step-security/harden-runner from 2.4.1 to 2.5.0

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.1 to 2.5.0.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@55d479f...cba0d00)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #48985
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    dependabot[bot] authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    5c352ee View commit details
    Browse the repository at this point in the history
  51. meta: bump github/codeql-action from 2.20.1 to 2.21.2

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.1 to 2.21.2.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@f6e388e...0ba4244)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #48986
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    dependabot[bot] authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f6e68a0 View commit details
    Browse the repository at this point in the history
  52. doc: remove v14 mention

    PR-URL: #49005
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    4047947 View commit details
    Browse the repository at this point in the history
  53. doc: clarify use of process.env in worker threads on Windows

    Signed-off-by: Daeyeon Jeong <[email protected]>
    PR-URL: #49008
    Fixes: #48955
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    daeyeon authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    ead654f View commit details
    Browse the repository at this point in the history
  54. typings: update JSDoc for cwd in child_process

    PR-URL: #49029
    Refs: #38862
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    LiviaMedeiros authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    71c386a View commit details
    Browse the repository at this point in the history
  55. doc: detailed description of keystrokes Ctrl-Y and Meta-Y

    PR-URL: #43529
    Reviewed-By: James M Snell <[email protected]>
    rayw000 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    12b83e8 View commit details
    Browse the repository at this point in the history
  56. doc: add ESM examples in http.md

    PR-URL: #47763
    Reviewed-By: Luigi Pinca <[email protected]>
    btea authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6daa9ec View commit details
    Browse the repository at this point in the history
  57. doc: add missing period

    PR-URL: #49094
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Trott authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    633b8cd View commit details
    Browse the repository at this point in the history
  58. doc: add description for --port flag of node inspect

    PR-URL: #48785
    Reviewed-By: Kohei Ueno <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    iloveitaly authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    9ce7396 View commit details
    Browse the repository at this point in the history
  59. doc: update with latest security release

    PR-URL: #49085
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7ee26fb View commit details
    Browse the repository at this point in the history
  60. readline: add paste bracket mode

    The paste bracket mode allows REPL to have auto-indentation
    that is handled differently when the user copy-pastes the code
    from the clipboard and the code already has an indentation.
    
    PR-URL: #47150
    Fixes: #45213
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Kohei Ueno <[email protected]>
    jcubic authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    a625f22 View commit details
    Browse the repository at this point in the history
  61. events: remove weak listener for event target

    Fixes: #48951
    PR-URL: #48952
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    acd9872 View commit details
    Browse the repository at this point in the history
  62. stream: improve WebStreams performance

    PR-URL: #49089
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    rluvaton authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    d585d13 View commit details
    Browse the repository at this point in the history
  63. lib: fix MIME overmatch in data URLs

    This commit adds the delimiters ^ and $ to the regex that matches the
    MIME types for `data:` URLs.
    
    PR-URL: #49104
    Fixes: #48957
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    andremralves authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    981aa78 View commit details
    Browse the repository at this point in the history
  64. doc: make the NODE_VERSION_IS_RELEASE revert clear

    PR-URL: #49114
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    79c0497 View commit details
    Browse the repository at this point in the history
  65. doc: fix Type notation in webstreams

    Replace `type` with `Type: {Promise}`. Plus, fix incorrect
    verb(`creates` -> `returns`) in description.
    
    PR-URL: #49121
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    deokjinkim authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    55171d8 View commit details
    Browse the repository at this point in the history
  66. tools: update lint-md-dependencies

    - @rollup/[email protected]
    - [email protected]
    
    PR-URL: #49122
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    0cb42cc View commit details
    Browse the repository at this point in the history
  67. doc: fix wording in napi_async_init

    Refs: #32930
    PR-URL: #49180
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    3b82e9a View commit details
    Browse the repository at this point in the history
  68. doc: add h1 summary to security release process

    PR-URL: #49112
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    2247e52 View commit details
    Browse the repository at this point in the history
  69. doc: add notable-change label mention to PR template

    PR-URL: #49188
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    72bd527 View commit details
    Browse the repository at this point in the history
  70. meta: mention nodejs/tsc when changing GH templates

    PR-URL: #49189
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    RafaelGSS authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    bd17f0b View commit details
    Browse the repository at this point in the history
  71. test: use gcUntil() in test-v8-serialize-leak

    Previously this can be flaky because the there could be a delay
    of the deallocation after gc() is invoked. Use gcUntil() to run
    the GC multiple times to make the test more robust.
    
    PR-URL: #49168
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    joyeecheung authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e18de80 View commit details
    Browse the repository at this point in the history
  72. test: make test-perf-hooks more robust and work with workers

    Previously the test makes several assumptions about the absolute
    values of the nodeTiming fields, which can make the test flaky
    on slow machines. This patch rewrites the test to check the
    relative values instead. It also updates the test to make it
    work with workers instead of directly skipping in workers.
    
    PR-URL: #49197
    Refs: nodejs/reliability#638
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    joyeecheung authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    0261c5d View commit details
    Browse the repository at this point in the history
  73. doc: use same name in the doc as in the code

    Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy
    PR-URL: #49216
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    illusi0n7 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    bf22a5f View commit details
    Browse the repository at this point in the history
  74. build: expand when we run internet tests

    Refs: #49203
    
    Changes slipped into v18.x regressed
    test/internet/test-dns-ipv6 as I assume the action did
    not run because no test under test/internet was changed.
    Add some of the common paths that include code that might
    introduce failures in the internet tests.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #49218
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    mhdawson authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    9e1c531 View commit details
    Browse the repository at this point in the history
  75. src: add a condition if the argument of DomainToUnicode is empty

    PR-URL: #49097
    Refs: #46410
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Jungku Lee authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    8c33731 View commit details
    Browse the repository at this point in the history
  76. src: use ARES_SUCCESS instead of 0

    PR-URL: #49048
    Refs: #48834
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Jungku Lee authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    158c91a View commit details
    Browse the repository at this point in the history
  77. test,benchmark: use tmpdir.fileURL()

    PR-URL: #49138
    Refs: #49040
    Reviewed-By: Luigi Pinca <[email protected]>
    LiviaMedeiros authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b011a49 View commit details
    Browse the repository at this point in the history
  78. src: remove unused function GetName() in node_perf

    PR-URL: #49244
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Jungku Lee authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    066d9d4 View commit details
    Browse the repository at this point in the history
  79. doc: clarify use of Uint8Array for n-api

    `napi_get_buffer_info` always supported receiving `Uint8Array` as a
    `value` argument because `node::Buffer` is a subclass of `Uint8Array`
    and the underlying V8 APIs don't distinguish between two. With this
    change we mark both types as supported by the API so that the user code
    doesn't have to unknowingly use oficially unsupported type of the
    `value` argument.
    
    PR-URL: #48742
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    indutny authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f9c2a3f View commit details
    Browse the repository at this point in the history
  80. doc: update description for percent_encode sets in WHATWG API

    PR-URL: #49258
    Refs: https://url.spec.whatwg.org/#percent-encoded-bytes
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Jungku Lee authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c70945d View commit details
    Browse the repository at this point in the history
  81. meta: move one or more collaborators to emeritus

    PR-URL: #49264
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Shingo Inoue <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    155a275 View commit details
    Browse the repository at this point in the history
  82. worker: protect against user mutating well-known prototypes

    PR-URL: #49270
    Fixes: #49259
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    aduh95 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    879b958 View commit details
    Browse the repository at this point in the history
  83. doc: fix typo in stream.finished documentation

    PR-URL: #49271
    Refs: https://nodejs.org/api/stream.html#streamfinishedstream-options
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Qingyu Deng <[email protected]>
    aduh95 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f181c37 View commit details
    Browse the repository at this point in the history
  84. doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc

    The code was changed in #48501 but the doc was missed.
    
    PR-URL: #49268
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    zcbenz authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    3f771ca View commit details
    Browse the repository at this point in the history
  85. stream: add highWaterMark for the map operator

    this is done so we don't wait for the first items to
    finish before starting new ones
    
    Fixes: #46132
    
    Co-authored-by: Robert Nagy <[email protected]>
    PR-URL: #49249
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    2 people authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    651e450 View commit details
    Browse the repository at this point in the history
  86. build: add symlink to compile_commands.json file if needed

    Usually lsp servers needs the `compile_commands.json` file in the root
    directory.
    
    Signed-off-by: Juan José Arboleda <[email protected]>
    PR-URL: #49260
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    juanarbol authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    075c57e View commit details
    Browse the repository at this point in the history
  87. doc: modify param description for end(),write() in StringDecoder

    PR-URL: #49285
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Jungku Lee authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    9ca85b5 View commit details
    Browse the repository at this point in the history
  88. test: fix compiler warning in NodeCryptoEnv

    This fixes a warning in line 26: "warning: value computed is not used"
    when calling BIO_seek().
    
    Refs: #47160
    PR-URL: #49206
    Reviewed-By: Michael Dawson <[email protected]>
    tniessen authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    ddebd29 View commit details
    Browse the repository at this point in the history
  89. fs: remove redundant code in readableWebStream()

    Remove redundant code by moving it to outside of `if/else`. Plus,
    make `options` optional in doc.
    
    PR-URL: #49298
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    deokjinkim authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    69b7f91 View commit details
    Browse the repository at this point in the history
  90. doc: avoid "not currently recommended"

    Compromised algorithms will never again be recommended, so remove the
    qualifier "currently".
    
    PR-URL: #49300
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    tniessen authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    4ba11e3 View commit details
    Browse the repository at this point in the history
  91. policy: fix path to URL conversion

    PR-URL: #49133
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    d4f26f4 View commit details
    Browse the repository at this point in the history
  92. doc: update options.filter description for fs.cp

    PR-URL: #49289
    Fixes: #49092
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    shubham9411 authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    0dda724 View commit details
    Browse the repository at this point in the history
  93. tools: update lint-md-dependencies

    - @rollup/[email protected]
    - [email protected]
    - [email protected]
    
    PR-URL: #49253
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Daijiro Wachi <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    01b2588 View commit details
    Browse the repository at this point in the history
  94. stream: use Buffer.from when constructor is a Buffer

    When using BYOB streams, it's possible for the constructor in
    readableByteStreamControllerConvertPullIntoDescriptor to be a node
    Buffer. If it is, use `Buffer.from` over `new ctor`.
    
    Fixes #49245
    
    PR-URL: #49250
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    KhafraDev authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    ee4fc7d View commit details
    Browse the repository at this point in the history
  95. doc: use cjs as block code's type in MockTimers

    Use `cjs` instead of `js` to show toggle button between
    CJS and ESM because corresponding example using `mjs`
    exists.
    
    PR-URL: #49309
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    deokjinkim authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    62f823d View commit details
    Browse the repository at this point in the history
  96. doc: update outdated reference to NIST SP 800-131A

    NIST SP 800-131A Rev. 1 has been withdrawn. Replace the reference with a
    link to NIST SP 800-131A Rev. 2.
    
    PR-URL: #49316
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    tniessen authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    45caad8 View commit details
    Browse the repository at this point in the history
  97. doc: add print results for examples in StringDecoder

    PR-URL: #49326
    Refs: #49143
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Jungku Lee authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    3f1a237 View commit details
    Browse the repository at this point in the history
  98. tools: update lint-md-dependencies

    PR-URL: #49342
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b6522a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. test: migrate message source map tests from Python to JS

    Migrate the remaining source map tests in the `test/message` folder
    from Python to JS.
    
    Fixes: #47707
    
    test: migrate message source map tests from Python to JS
    PR-URL: #49238
    Reviewed-By: Moshe Atlow <[email protected]>
    Yiyun Lei authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    107015b View commit details
    Browse the repository at this point in the history
  2. test: rename test-crypto-modp1-error

    This test is not specific to modp1 at all, it might as well use any of
    the other groups.
    
    Refs: #40451
    PR-URL: #49348
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5f1a1ae View commit details
    Browse the repository at this point in the history
  3. doc: add news issue for Diagnostics WG

    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #49306
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Daijiro Wachi <[email protected]>
    mhdawson authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4c93905 View commit details
    Browse the repository at this point in the history
  4. node-api: fix compiler warning in node_api.h

    Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022,
    compiling C, targeting arch arm64 (on x86_64 host). I build my C
    addon with -Werror and recent changes to node_api.h broke our build.
    
    PR-URL: #49103
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    graebm authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    48a1b93 View commit details
    Browse the repository at this point in the history
  5. test_runner: add support for setImmediate

    PR-URL: #49397
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    ErickWendel authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    11fbd92 View commit details
    Browse the repository at this point in the history
  6. test: split test-crypto-keygen.js

    To avoid timing out on ARM machines in the CI.
    
    PR-URL: #49221
    Refs: #49202
    Refs: #41206
    Reviewed-By: Luigi Pinca <[email protected]>
    joyeecheung authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    344592d View commit details
    Browse the repository at this point in the history
  7. test: split JWK async elliptic curve keygen tests

    PR-URL: #49221
    Refs: #49202
    Refs: #41206
    Reviewed-By: Luigi Pinca <[email protected]>
    joyeecheung authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    958e114 View commit details
    Browse the repository at this point in the history
  8. test: reduce length in crypto keygen tests

    PR-URL: #49221
    Refs: #49202
    Refs: #41206
    Reviewed-By: Luigi Pinca <[email protected]>
    joyeecheung authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    67cb6f9 View commit details
    Browse the repository at this point in the history
  9. url: handle unicode hostname if empty

    PR-URL: #49396
    Fixes: #48759
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f256b16 View commit details
    Browse the repository at this point in the history
  10. net: fix crash due to simultaneous close/shutdown on JS Stream Sockets

    A JS stream socket wraps a stream, exposing it as a socket for something
    on top which needs a socket specifically (e.g. an HTTP server).
    
    If the internal stream is closed in the same tick as the layer on top
    attempts to close this stream, the race between doShutdown and doClose
    results in an uncatchable exception. A similar race can happen with
    doClose and doWrite.
    
    It seems legitimate these can happen in parallel, so this resolves that
    by explicitly detecting and handling that situation: if a close is in
    progress, both doShutdown & doWrite allow doClose to run
    finishShutdown/Write for them, cancelling the operation, without trying
    to use this._handle (which will be null) in the meantime.
    
    PR-URL: #49400
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    pimterry authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    03063bd View commit details
    Browse the repository at this point in the history
  11. net: use asserts in JS Socket Stream to catch races in future

    PR-URL: #49400
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    pimterry authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    daca87b View commit details
    Browse the repository at this point in the history
  12. url: validate pathToFileURL(path) argument as string

    PR-URL: #49161
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    LiviaMedeiros authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ac27431 View commit details
    Browse the repository at this point in the history
  13. doc: fix node-api call example

    The `return` statement should not be enclosed in a nested conditional
    branch.
    
    PR-URL: #49395
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Harshitha K P <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    legendecas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e26b89e View commit details
    Browse the repository at this point in the history
  14. test: avoid copying test source files

    Converting the helper functions to be inlined and making the helper file
    header only.
    
    PR-URL: #49515
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    legendecas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c5857bd View commit details
    Browse the repository at this point in the history
  15. node-api: enable uncaught exceptions policy by default

    This enables the option `--force-node-api-uncaught-exceptions-policy`
    for a specific Node-API addon when it is compiled with
    `NAPI_EXPERIMENTAL` (and this would be the default behavior when
    `NAPI_VERSION` 10 releases). This would not break existing Node-API
    addons.
    
    PR-URL: #49313
    Refs: #36510
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    legendecas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    edef4fa View commit details
    Browse the repository at this point in the history
  16. node-api: run finalizers directly from GC

    PR-URL: #42651
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    vmoroz authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5148f03 View commit details
    Browse the repository at this point in the history
  17. node-api: update headers for better wasm support

    PR-URL: #49037
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    toyobayashi authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f449b22 View commit details
    Browse the repository at this point in the history
  18. tools: update lint-md-dependencies to [email protected] [email protected]

    PR-URL: #49584
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3511b13 View commit details
    Browse the repository at this point in the history
  19. tools: update lint-md-dependencies to [email protected]

    PR-URL: #49679
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ad6e7a6 View commit details
    Browse the repository at this point in the history
  20. tools: update lint-md-dependencies

    - [email protected]
    - [email protected]
    - [email protected]
    - [email protected]
    
    PR-URL: #49983
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    07941a3 View commit details
    Browse the repository at this point in the history
  21. tools: update lint-md-dependencies

    - @rollup/[email protected]
    - @rollup/[email protected]
    - [email protected]
    
    PR-URL: #50083
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3b65c61 View commit details
    Browse the repository at this point in the history
  22. test: reorder test files fixtures for better understanding

    PR-URL: #48787
    Backport-PR-URL: #49225
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0fea550 View commit details
    Browse the repository at this point in the history
  23. test_runner: fix global after not failing the tests

    PR-URL: #48913
    Backport-PR-URL: #49225
    Fixes: #48867
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    71f7ed7 View commit details
    Browse the repository at this point in the history
  24. test: remove --no-warnings flag in test_runner fixtures

    no longer needed after #48915 fix
    
    PR-URL: #48989
    Backport-PR-URL: #49225
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    rluvaton authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7e714e6 View commit details
    Browse the repository at this point in the history
  25. test_runner: dont set exit code on todo tests

    PR-URL: #48929
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    00c70e1 View commit details
    Browse the repository at this point in the history
  26. test_runner: expose location of tests

    This commit adds each test's line and column number to the reporter
    output. This will aid in debugging test suite failures when error
    stacks are not helpful, test suites are large, or tests have the
    same name. This data is also exposed on the spec reporter.
    
    This commit also replaces the filename that was previously being
    reported, with the filename where the test actually exists. These
    are normally correct, but could be wrong if tests were run from
    a file other than the user's entrypoint.
    
    PR-URL: #48975
    Fixes: #48457
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    cjihrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d61a505 View commit details
    Browse the repository at this point in the history
  27. test_runner: reland run global after() hook earlier

    This commit reverts the revert in
    bb52656. It also includes the
    fix for the issue that required the revert
    (#49059 (comment))
    and an additional common.mustCall() in the added test.
    
    Refs: #49059
    Refs: #49110
    PR-URL: #49116
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    cjihrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d839640 View commit details
    Browse the repository at this point in the history
  28. test_runner: expose spec reporter as newable function

    Fixes: #48112
    Ref: #48208
    PR-URL: #49184
    Refs: #48208
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    atlowChemi authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    95cc98e View commit details
    Browse the repository at this point in the history
  29. test_runner: preserve original property descriptor

    PR-URL: #49433
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    ErickWendel authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    760c982 View commit details
    Browse the repository at this point in the history
  30. meta: bump actions/setup-node from 3.7.0 to 3.8.1

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.1.
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@e33196f...5e21ff4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-node
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #49434
    Refs: actions/setup-node@5e21ff4
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dad5785 View commit details
    Browse the repository at this point in the history
  31. meta: bump step-security/harden-runner from 2.5.0 to 2.5.1

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.5.0 to 2.5.1.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@cba0d00...8ca2b8b)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #49435
    Refs: step-security/harden-runner@8ca2b8b
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0fc0b88 View commit details
    Browse the repository at this point in the history
  32. test_runner: fix typescript coverage

    PR-URL: #49406
    Fixes: #49398
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    429846f View commit details
    Browse the repository at this point in the history
  33. test_runner: add jsdocs to MockTimers

    Signed-off-by: Erick Wendel <[email protected]>
    PR-URL: #49476
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    ErickWendel authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5949ae0 View commit details
    Browse the repository at this point in the history
  34. test_runner: fix invalid timer call

    Signed-off-by: Erick Wendel <[email protected]>
    PR-URL: #49477
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    ErickWendel authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ba57c24 View commit details
    Browse the repository at this point in the history
  35. test_runner: add jsdocs to mock.js

    PR-URL: #49555
    Reviewed-By: Erick Wendel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    ocodista authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    76a3563 View commit details
    Browse the repository at this point in the history
  36. test_runner: add junit reporter

    PR-URL: #49614
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    059b194 View commit details
    Browse the repository at this point in the history
  37. test_runner: fix test runner watch mode when no positional arguments

    PR-URL: #49578
    Fixes: #49617
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e459598 View commit details
    Browse the repository at this point in the history
  38. test: mark test-runner-watch-mode as flaky

    PR-URL: #49627
    Refs: #49605
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Daijiro Wachi <[email protected]>
    joyeecheung authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5df2352 View commit details
    Browse the repository at this point in the history
  39. doc: remove @anonrig from performance initiative

    PR-URL: #49641
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Claudio Wunder <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    07c3b88 View commit details
    Browse the repository at this point in the history
  40. test_runner: catch reporter errors

    PR-URL: #49646
    Fixes: #48937
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    103c4a0 View commit details
    Browse the repository at this point in the history
  41. test_runner: accept testOnly in run

    PR-URL: #49753
    Fixes: #49733
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b283ae4 View commit details
    Browse the repository at this point in the history
  42. test_runner: replace spurious if with else

    There is an `if` statement that likely should have been
    an `else` in the original PR.
    
    Refs: #48915
    PR-URL: #49943
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    cjihrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1d9c371 View commit details
    Browse the repository at this point in the history
  43. test_runner: add test location for FileTests

    This commit adds the previously missing test location for
    FileTest tests.
    
    Fixes: #49926
    Fixes: #49927
    PR-URL: #49999
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    cjihrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    54168b7 View commit details
    Browse the repository at this point in the history
  44. test_runner, cli: add --test-concurrency flag

    This commit adds a new --test-concurrency CLI flag that controls
    the parallelism of the test runner CLI.
    
    PR-URL: #49996
    Fixes: #49487
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    cjihrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    428301a View commit details
    Browse the repository at this point in the history
  45. test_runner,test: fix flaky test-runner-cli-concurrency.js

    This test was flaky on Windows when trying to clean up the
    tmp directory, probably because it relied on child processes
    timing out and being killed.
    
    This commit updates the test to check for debug output
    from the test runner. This should be adequate because the
    original change was effectively:
    
    let concurrency = getOptionValue('--test-concurrency') || true;
    
    The test runner now logs the value of the concurrency variable.
    
    Fixes: #50101
    PR-URL: #50108
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    cjihrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4b2e258 View commit details
    Browse the repository at this point in the history
  46. Revert "test: mark test-http-regr-gh-2928 as flaky"

    This reverts commit 48fcb20.
    
    Refs: 18e00a577d74
    PR-URL: #49708
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Franziska Hinkelmann <[email protected]>
    lpinca authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1d75da4 View commit details
    Browse the repository at this point in the history
  47. test: deflake test-runner-output

    PR-URL: #49878
    Fixes: #49853
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    MoLow authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5820d7e View commit details
    Browse the repository at this point in the history
  48. test: set test-runner-watch-mode as flaky

    PR-URL: #50221
    Refs: #49985
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5953a25 View commit details
    Browse the repository at this point in the history
  49. test: set test-worker-nearheaplimit-deadlock flaky

    The test is only flaky on x86 Windows.
    
    Fixes: #50220
    PR-URL: #50238
    Refs: #49962
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    StefanStojanovic authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    54f3d87 View commit details
    Browse the repository at this point in the history
  50. test: set parallel http server test as flaky

    Ref: #43465
    PR-URL: #50227
    Refs: #43465
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cb0bd21 View commit details
    Browse the repository at this point in the history
  51. test: set inspector async hook test as flaky

    Ref: #50222
    PR-URL: #50252
    Refs: #50222
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    866a399 View commit details
    Browse the repository at this point in the history
  52. test: set test-structuredclone-* as flaky

    PR-URL: #50261
    Refs: #50260
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    83e339d View commit details
    Browse the repository at this point in the history
  53. test: set crypto-timing test as flaky

    PR-URL: #50232
    Refs: #38226
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0c05c25 View commit details
    Browse the repository at this point in the history
  54. test: set test-cli-node-options as flaky

    PR-URL: #50296
    Refs: #50295
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e81b066 View commit details
    Browse the repository at this point in the history
  55. test: set test-worker-nearheaplimit-deadlock flaky

    PR-URL: #50277
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    StefanStojanovic authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b41aa7b View commit details
    Browse the repository at this point in the history
  56. test: set inspector async stack test as flaky

    #50243
    PR-URL: #50244
    Refs: #50243
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    91a3b57 View commit details
    Browse the repository at this point in the history
  57. test: set test-emit-after-on-destroyed as flaky

    Ref: #50245
    PR-URL: #50246
    Refs: #50245
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1047d95 View commit details
    Browse the repository at this point in the history
  58. test: set test-watch-mode-inspect as flaky

    PR-URL: #50259
    Refs: #49933
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a0bb30c View commit details
    Browse the repository at this point in the history
  59. stream: use bitmap in readable state

    PR-URL: #49745
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    benjamingr authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fae60c5 View commit details
    Browse the repository at this point in the history
  60. meta: bump actions/checkout from 3.5.3 to 3.6.0

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@c85c95e...f43a0e5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #49436
    Refs: actions/checkout@f43a0e5
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    26c5c3c View commit details
    Browse the repository at this point in the history
  61. meta: bump actions/checkout from 3.6.0 to 4.1.0

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.0.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@f43a0e5...8ade135)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50001
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3a107f8 View commit details
    Browse the repository at this point in the history
  62. meta: bump github/codeql-action from 2.21.2 to 2.21.5

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.2 to 2.21.5.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@0ba4244...00e563e)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #49438
    Refs: github/codeql-action@00e563e
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6591a03 View commit details
    Browse the repository at this point in the history
  63. meta: bump github/codeql-action from 2.21.5 to 2.21.9

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.5 to 2.21.9.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@00e563e...ddccb87)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50002
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7927032 View commit details
    Browse the repository at this point in the history
  64. meta: bump actions/cache from 3.3.1 to 3.3.2

    Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2.
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@88522ab...704facf)
    
    ---
    updated-dependencies:
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50003
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    98294fd View commit details
    Browse the repository at this point in the history
  65. meta: bump actions/upload-artifact from 3.1.2 to 3.1.3

    Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3.
    - [Release notes](https://github.com/actions/upload-artifact/releases)
    - [Commits](actions/upload-artifact@0b7f8ab...a8a3f3a)
    
    ---
    updated-dependencies:
    - dependency-name: actions/upload-artifact
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50000
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dee7dc5 View commit details
    Browse the repository at this point in the history
  66. meta: add test/reporters to codeowners

    PR-URL: #49186
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    atlowChemi authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5d6daf0 View commit details
    Browse the repository at this point in the history
  67. meta: remove modules team from CODEOWNERS

    Currently the modules team is inactive and the
    loaders team functions as the team in charge of
    these files/areas.
    
    cc @nodejs/modules in case anyone wants to join
    the @nodejs/loaders team since the modules may be
    removed.
    
    PR-URL: #49412
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    benjamingr authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2827779 View commit details
    Browse the repository at this point in the history
  68. meta: bump rtCamp/action-slack-notify from 2.2.0 to 2.2.1

    Bumps [rtCamp/action-slack-notify](https://github.com/rtcamp/action-slack-notify) from 2.2.0 to 2.2.1.
    - [Release notes](https://github.com/rtcamp/action-slack-notify/releases)
    - [Commits](rtCamp/action-slack-notify@12e36fc...b24d75f)
    
    ---
    updated-dependencies:
    - dependency-name: rtCamp/action-slack-notify
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #49437
    Refs: rtCamp/action-slack-notify@b24d75f
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    dependabot[bot] authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    213a9f8 View commit details
    Browse the repository at this point in the history
  69. meta: add primordials strategic initiative

    PR-URL: #49706
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Franziska Hinkelmann <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    benjamingr authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dc70c44 View commit details
    Browse the repository at this point in the history
  70. meta: fix linter error

    PR-URL: #49755
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    aduh95 authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    332d2ae View commit details
    Browse the repository at this point in the history
  71. meta: update website team with new name

    Pings for the website team aren't working because the team name
    changed but it did not get updated in CODEOWNERS.
    
    PR-URL: #49883
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Claudio Wunder <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d24c3a0 View commit details
    Browse the repository at this point in the history
  72. meta: ping TSC for offboarding

    Refs: #49264
    PR-URL: #50147
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    tniessen authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5b9575d View commit details
    Browse the repository at this point in the history
  73. meta: move Trott to TSC regular member

    At the current time, I'm not able to give Node.js the time and attention
    it needs and deserves from a voting TSC member. I'm proud of the work
    and efforts I've made as a TSC voting member, and I want to leave before
    I'm less happy with my efforts. Thanks for all the trust and good will
    over the years.
    
    PR-URL: #50297
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Trott authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7778e19 View commit details
    Browse the repository at this point in the history
  74. test: print instruction for creating missing snapshot in assertSnapshot

    PR-URL: #48914
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    rluvaton authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a2ca1a6 View commit details
    Browse the repository at this point in the history
  75. test: replace forEach with for..of in test-http2-client-destroy.js

    PR-URL: #49820
    Reviewed-By: Luigi Pinca <[email protected]>
    niyashiyas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    128ca3e View commit details
    Browse the repository at this point in the history
  76. test: replace forEach with for..of in test-http2-server

    PR-URL: #49819
    Reviewed-By: Luigi Pinca <[email protected]>
    niyashiyas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    bbd302b View commit details
    Browse the repository at this point in the history
  77. test: replace forEach with for..of in test-net-isipv4.js

    PR-URL: #49822
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    niyashiyas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2f0ffde View commit details
    Browse the repository at this point in the history
  78. test: replace forEach with for..of in test-http-perf_hooks.js

    PR-URL: #49818
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    niyashiyas authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7f39f8e View commit details
    Browse the repository at this point in the history
  79. doc: drop github actions check in sec release process

    PR-URL: #48978
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    RafaelGSS authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1096837 View commit details
    Browse the repository at this point in the history
  80. url: improve isURL detection

    PR-URL: #47886
    Backport-PR-URL: #50105
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    anonrig authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    916a63b View commit details
    Browse the repository at this point in the history
  81. url: fix isURL detection by checking path

    Fixes: #48921
    PR-URL: #48928
    Backport-PR-URL: #50105
    Fixes: getsentry/sentry-javascript#8552
    Fixes: request/request#3458
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Zhangdroid authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7fc15b6 View commit details
    Browse the repository at this point in the history
  82. https: fix connection checking interval not clearing on server close

    The connection interval should close when httpsServer.close is called
    similarly to how it gets cleared when httpServer.close is called.
    
    Fixes: #48373
    PR-URL: #48383
    Backport-PR-URL: #50194
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Linkgoron authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2969722 View commit details
    Browse the repository at this point in the history
  83. deps: V8: cherry-pick 70caf337c3f6

    Original commit message:
    
        [riscv64] Fix the StaticStackFrameSize
    
         Update the size to kTierupBudgetOffset.
    
        Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
        Reviewed-by: ji qiu <[email protected]>
        Commit-Queue: Yahan Lu <[email protected]>
        Auto-Submit: Yahan Lu <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#79978}
    
    Refs: v8/v8@70caf33
    PR-URL: #50506
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    kxxt authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7af5427 View commit details
    Browse the repository at this point in the history
  84. tools: fix --v8-non-optimized-debug for v18.x

    Disable SLOW_DCHECKs on v18.x because they don't compile without
    the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887
    if used in constexpr, which can happen in other floated patches.
    
    PR-URL: #50612
    Reviewed-By: Michaël Zasso <[email protected]>
    joyeecheung authored and targos committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a1c9403 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. 2023-11-29, Version 18.19.0 'Hydrogen' (LTS)

    Notable changes:
    
    deps:
      * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
      * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) #50531
    doc:
      * move and rename loaders section (Geoffrey Booth) #49261
    esm:
      * use import attributes instead of import assertions (Antoine du Hamel) #50140
      * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
      * unflag import.meta.resolve (Guy Bedford) #49028
      * move hook execution to separate thread (Jacob Smith) #44710
      * leverage loaders when resolving subsequent loaders (Maël Nison) #43772
    lib:
      * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
      * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) #44943
    src:
      * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629
    stream:
      * use bitmap in readable state (Benjamin Gruenbaum) #49745
    test_runner:
      * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753
      * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614
      * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
      * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639
      * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775
    test_runner, cli:
      * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996
    tls:
      * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190
    vm:
      * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141
    
    PR-URL: #50953
    targos committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9e0c715 View commit details
    Browse the repository at this point in the history