doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc #49268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
bnoordhuis
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Suggestion: reference commit 6ffacbf in the commit log (edit: or the PR URL.)
The code was changed in nodejs#48501 but the doc was missed.
|
@legendecas FYI |
legendecas
approved these changes
Aug 22, 2023
mhdawson
pushed a commit
that referenced
this pull request
Aug 23, 2023
The code was changed in #48501 but the doc was missed. PR-URL: #49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
|
Landed in 996f390 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
The code was changed in #48501 but the doc was missed. PR-URL: #49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
The code was changed in nodejs#48501 but the doc was missed. PR-URL: nodejs#49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
The code was changed in #48501 but the doc was missed. PR-URL: #49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
27 tasks
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The code was changed in #48501 but the doc was missed. PR-URL: nodejs/node#49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The code was changed in #48501 but the doc was missed. PR-URL: nodejs/node#49268 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the doc for the changes in #48501.