Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix typo libray -> library (configure.py) #49106

Merged
merged 1 commit into from
Aug 15, 2023
Merged

build: fix typo libray -> library (configure.py) #49106

merged 1 commit into from
Aug 15, 2023

Conversation

michalbiesek
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 11, 2023
@deokjinkim deokjinkim changed the title build: Fix typo libray -> library (configure.py) build: fix typo libray -> library (configure.py) Aug 11, 2023
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53194/

@richardlau
Copy link
Member

Test failure is #49059 (comment), being fixed (🤞) by a revert #49110.

@github-actions github-actions bot mentioned this pull request Aug 13, 2023
Open
29 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53299/

@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53337/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53338/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit b3eb05b into nodejs:main Aug 15, 2023
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b3eb05b

@michalbiesek michalbiesek deleted the build-fix-typo branch August 15, 2023 21:01
This was referenced Aug 16, 2023
Open
Open
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@michalbiesek @UlisesGascon
build: fix typo libray -> library (configure.py)
f637fd4 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: #49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@michalbiesek @targos
build: fix typo libray -> library (configure.py)
a781d24 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: #49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
build: fix typo libray -> library (configure.py)
482aee9 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: nodejs/node#49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
build: fix typo libray -> library (configure.py)
fc5b695 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: nodejs/node#49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deokjinkim deokjinkim deokjinkim approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michalbiesek @nodejs-github-bot @richardlau @benjamingr @lpinca @deokjinkim