Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky: test-esm-loader-resolve-type #50040

Closed
mhdawson opened this issue Oct 4, 2023 · 0 comments · Fixed by #50273
Closed

flaky: test-esm-loader-resolve-type #50040

mhdawson opened this issue Oct 4, 2023 · 0 comments · Fixed by #50273
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. loaders Issues and PRs related to ES module loaders macos Issues and PRs related to the macOS platform / OSX.

Comments

@mhdawson
Copy link
Member

mhdawson commented Oct 4, 2023

Test

es-module/test-esm-loader-resolve-type

Platform

macOS ARM64

Console output

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  {
    code: 0,
    signal: null,
    stderr: '',
+   stdout: '{"before":{"importedESM":0,"importedCJS":0},"after":{"importedESM":0,"importedCJS":0}}\n'
-   stdout: '{"before":{"importedESM":0,"importedCJS":0},"after":{"importedESM":1,"importedCJS":0}}\n'
  }
    at file:///Users/runner/work/node/node/test/es-module/test-esm-loader-resolve-type.mjs:34:3 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: {
    code: 0,
    signal: null,
    stderr: '',
    stdout: '{"before":{"importedESM":0,"importedCJS":0},"after":{"importedESM":0,"importedCJS":0}}\n'
  },
  expected: {
    code: 0,
    signal: null,
    stderr: '',
    stdout: '{"before":{"importedESM":0,"importedCJS":0},"after":{"importedESM":1,"importedCJS":0}}\n'
  },
  operator: 'deepStrictEqual'
}

Node.js v21.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/es-module/test-esm-loader-resolve-type.mjs

===
=== 1 tests failed
===

Failed tests:
out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/es-module/test-esm-loader-resolve-type.mjs
make[1]: *** [test-ci] Error 1
make: *** [run-ci] Error 2
Error: Process completed with exit code 2.

Build links

Additional information

No response

@mhdawson mhdawson added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 4, 2023
@github-actions github-actions bot added the macos Issues and PRs related to the macOS platform / OSX. label Oct 4, 2023
@aduh95 aduh95 added the loaders Issues and PRs related to ES module loaders label Oct 8, 2023
anonrig added a commit to anonrig/node that referenced this issue Oct 18, 2023
anonrig added a commit to anonrig/node that referenced this issue Oct 18, 2023
nodejs-github-bot pushed a commit that referenced this issue Oct 19, 2023
Ref: #50040
PR-URL: #50226
Refs: #50040
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
nodejs-github-bot pushed a commit that referenced this issue Oct 21, 2023
PR-URL: #50273
Fixes: #50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Oct 23, 2023
Ref: #50040
PR-URL: #50226
Refs: #50040
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
targos pushed a commit that referenced this issue Oct 23, 2023
PR-URL: #50273
Fixes: #50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
Ref: nodejs#50040
PR-URL: nodejs#50226
Refs: nodejs#50040
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
PR-URL: nodejs#50273
Fixes: nodejs#50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
PR-URL: nodejs#50273
Fixes: nodejs#50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
PR-URL: nodejs#50273
Fixes: nodejs#50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Nov 11, 2023
Ref: #50040
PR-URL: #50226
Refs: #50040
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
targos pushed a commit that referenced this issue Nov 11, 2023
PR-URL: #50273
Fixes: #50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
PR-URL: nodejs#50273
Fixes: nodejs#50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Nov 23, 2023
PR-URL: #50273
Backport-PR-URL: #50669
Fixes: #50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
PR-URL: nodejs/node#50273
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
PR-URL: nodejs/node#50273
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. loaders Issues and PRs related to ES module loaders macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants