Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix typo parentUrl -> parentURL #48999

Merged
merged 1 commit into from
Aug 2, 2023
Merged

esm: fix typo parentUrl -> parentURL #48999

merged 1 commit into from
Aug 2, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 2, 2023

No description provided.

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Aug 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53048/

GeoffreyBooth
GeoffreyBooth reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all of them? I feel like there were more in the other PR, maybe there are just more times it’s added over there.

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 2, 2023

I'd need another fast-track approval in order to land this.

@GeoffreyBooth GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. loaders Issues and PRs related to ES module loaders and removed needs-ci PRs that need a full CI run. labels Aug 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5c65565 into nodejs:main Aug 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 5c65565

@aduh95 aduh95 deleted the Url-to-URL branch August 2, 2023 20:29
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@aduh95
esm: fix typo parentUrl -> parentURL
8c28f35 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@aduh95
esm: fix typo parentUrl -> parentURL
31cf50b 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
esm: fix typo parentUrl -> parentURL
971b5cc 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
esm: fix typo parentUrl -> parentURL
87ae0de 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@aduh95 @UlisesGascon
esm: fix typo parentUrl -> parentURL
1156a73 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
esm: fix typo parentUrl -> parentURL
623f95f 
PR-URL: #48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
esm: fix typo parentUrl -> parentURL
9cbbd47 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@aduh95 @rluvaton
esm: fix typo parentUrl -> parentURL
2c80473 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@aduh95 @RafaelGSS
esm: fix typo parentUrl -> parentURL
74a2e1e 
PR-URL: #48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Sep 7, 2023
@MoLow @aduh95
esm: fix typo parentUrl -> parentURL
9f410bd 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
esm: fix typo parentUrl -> parentURL
f5661b0 
PR-URL: nodejs#48999
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
esm: fix typo parentUrl -> parentURL
f96b610 
PR-URL: #48999
Backport-PR-URL: #50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: fix typo parentUrl -> parentURL
185bf28 
PR-URL: nodejs/node#48999
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: fix typo parentUrl -> parentURL
0383e08 
PR-URL: nodejs/node#48999
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. loaders Issues and PRs related to ES module loaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @atlowChemi @targos