Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify use of process.env in worker threads on Windows #49008

Merged
merged 1 commit into from
Aug 5, 2023
Merged

doc: clarify use of process.env in worker threads on Windows #49008

merged 1 commit into from
Aug 5, 2023

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Aug 3, 2023 •
edited
Loading

A worker thread uses a copy of parent thread's process.env by default. The current document explains differences caused by the copy, but it doesn't cover the case sensitivity difference on Windows.

This patch updates the document in this regard.

Fixes: #48955
Alternative to #48976

Signed-off-by: Daeyeon Jeong [email protected]

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2023
@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit d150316 into nodejs:main Aug 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d150316

@daeyeon daeyeon deleted the main.doc-worker-env-230803.Thu.38c0 branch August 6, 2023 02:06
@daeyeon daeyeon mentioned this pull request Aug 6, 2023
Closed
@leumasme leumasme mentioned this pull request Aug 7, 2023
Closed
@daeyeon daeyeon mentioned this pull request Aug 8, 2023
Closed
martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@daeyeon @martenrichter
doc: clarify use of process.env in worker threads on Windows
2e54504 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@daeyeon @Ceres6
doc: clarify use of process.env in worker threads on Windows
d873a2c 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@daeyeon @Ceres6
doc: clarify use of process.env in worker threads on Windows
ffe7ba3 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@daeyeon @UlisesGascon
doc: clarify use of process.env in worker threads on Windows
fbf5383 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@daeyeon @RafaelGSS
doc: clarify use of process.env in worker threads on Windows
e5e5fd5 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #49008
Fixes: #48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@daeyeon @RafaelGSS
doc: clarify use of process.env in worker threads on Windows
530ae44 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@daeyeon @rluvaton
doc: clarify use of process.env in worker threads on Windows
10a6dcb 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#49008
Fixes: nodejs#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@daeyeon @RafaelGSS
doc: clarify use of process.env in worker threads on Windows
9c26c0f 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #49008
Fixes: #48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@daeyeon @targos
doc: clarify use of process.env in worker threads on Windows
ead654f 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #49008
Fixes: #48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: clarify use of process.env in worker threads on Windows
0f160a2 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs/node#49008
Fixes: nodejs/node#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: clarify use of process.env in worker threads on Windows
8ea60a1 
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs/node#49008
Fixes: nodejs/node#48955
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@aymen94 aymen94 aymen94 approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In worker threads, process.env is case-sensitive on windows
10 participants
@daeyeon @nodejs-github-bot @bnoordhuis @lpinca @anonrig @tniessen @deokjinkim @aymen94 @RaisinTen @atlowChemi