test_runner: expose spec reporter as newable function #49184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
atlowChemi
force-pushed
the
spec-reporter-as-function
branch
2 times, most recently
from
7a2f61e
to
f217312
Compare
atlowChemi
added
test_runner
|
Review requested:
|
benjamingr
approved these changes
Aug 15, 2023
MoLow
approved these changes
Aug 15, 2023
|
@atlowChemi can you amend the commit message changing from |
Oh, of course. That was what I meant, oopsy 🙂 |
atlowChemi
force-pushed
the
spec-reporter-as-function
branch
from
f217312
to
193c63a
Compare
|
@MoLow fixed commit message, care to re-approve latest commit? 🙂 |
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Aug 16, 2023
MoLow
changed the title
MoLow
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in a5567c2 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Fixes: #48112 Ref: #48208 PR-URL: #49184 Refs: #48208 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Fixes: #48112 Ref: #48208 PR-URL: #49184 Refs: #48208 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
atlowChemi
added a commit
to atlowChemi/node
that referenced
this pull request
Apr 7, 2024
atlowChemi
added a commit
to atlowChemi/node
that referenced
this pull request
Apr 14, 2024
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: nodejs#52385 Ref: nodejs#49184
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: #52385 Ref: #49184 PR-URL: #52403 Refs: #49184 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Fixes: nodejs/node#48112 Ref: nodejs/node#48208 PR-URL: nodejs/node#49184 Refs: nodejs/node#48208 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Fixes: nodejs/node#48112 Ref: nodejs/node#48208 PR-URL: nodejs/node#49184 Refs: nodejs/node#48208 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Apr 30, 2024
This commit exposes the lcov reporter as a newable function, so that it can be used in the same way as the other reporters. This will allow passing in the options to the reporter as well. This breaks the current behavior of the lcov reporter, which exposes an instance of the reporter. Fixes: #52385 Ref: #49184 PR-URL: #52403 Refs: #49184 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48112
Ref: #48208