multi: create v0.14.2-beta-rc1 branch #6201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a GitHub Action for sending the coverage to coveralls.io and don't need the goveralls binary anymore.
Instead of hard coding a commit to use for a binary tool that we use during the build process, we now only use "go install" to install the binaries and the golang builtin versioning system to pin the exact version/commit we want to use in go.mod.
The `GO111MODULE` variable is not required from go 1.16 https://go.dev/blog/go116-module-changes
when payment_hash or final_cltv_delta and payment_request was set, the error message showed that the parameters shouldn't be set with dest instead of payment_request [skip ci]
Since bbolt returns references to internally stored data when storing locally it's best to copy the byte slices returned or alternatively convert them to string (which also makes a copy) to avoid crashes casued by memory corruption.
This commit exposes the ChanStatusFlags inside waitingCloseResp such that the channel close type is exposed.
This change avoids enforcing new reserved value when PSBT funding is not finished yet as new inputs and outputs may still be added that could change the outcome of the check. This originally failed in the scenario when funding a channel from external wallet *and depositing to on-chain wallet* was done simultaneously in a single transaction. If such transaction confirms then reserved UTXO is guaranteed to be available but the check didn't take it into account. The enforcement still occurs in the final step of PSBT funding flow, so it is safe. It also occurs in case of non-PSBT funding.
This adds an integration test that makes sure channel can be funded from empty wallet using PSBT if the funding transaction contains an output belonging to the wallet, satisfying the reserve.
The minimum relay fee is always ensured to be above our fee floor except in the very first min relay fee query to bitcoind. This commit ensures that the fee floor is respected in this first query.
In this commit, we switch to always sending a channel type when we're in explicit mode. This is compatible with prior versions of lnd as they won't send a channel type, and we'll just arrive at the same type via the existing implicit funding. Fixes lightningnetwork#6067
Preparation for efficient graph cache loading where we don't iterate over the channels of each node in the network individually.
Allows for pure deserialization without depending on a database connection.
In this commit, we modify the implementation of ForEachChannel to utilize the new kvdb method ForAll. This greatly reduces the number of round-trips to the database needed to iterate over all channels in the graph.
Allows cacheableNode to be used outside of the callback. This is a preparation for optimization of the graph cache population.
Use the optimized ForEachChannel method to reduce the graph cache loading time.
This adds a `GetCustomCaveatCondition` function that returns the custom caveat condition for a given macaroon and caveat name. Previously there was no function for getting the custom caveat condition from a macaroon, only for setting one.
This sets the `CustomCaveatCondition` value on rpc middleware requests if one exists. Previously, this value was always blank even if the macaroon had a value set for its custom caveat condition.
…iter Introduces a breachResolver that subscribes to the breacharbiter to determine if the final justice transaction has confirmed and can clean itself up.
Also transitions to the proper state based on if this is a legacy breach in the channel arbitrator or a modern breach with a resolver.
This also changes the chain_watcher and breacharbiter handoff. The new logic ensures that the channel is only marked as pending closed when the channel arbitrator has persisted the resolutions and commit set.
When updating the channel routing policy, we encounter an inaccurate precision error when calculating the routing fee. The issue stems from the way the IEEE 754 standard works. The solution here is to add a uint64 parameter (as mentioned in the issue) and keep the float64 fee_rate parameter but rounding the product of the base and fee rate.
Roasbeef
force-pushed
the
v0.14.2-branch-rc1
branch
from
51a6728 to
09b1ae9
Compare
|
Some of our newer linters are failing, we haven't done a minor release like this since they were added. |
Roasbeef
force-pushed
the
v0.14.2-branch-rc1
branch
from
129cd3b to
9448ca9
Compare
guggero
approved these changes
Jan 26, 2022
Yeah I had a small bug in my script that led to these, I was wondering why I had to always do the rebase conflicts twice, but then realized it was against the wrong branch. Anything else from here out will be more uniform. |
Yeah this wasn't clear, but we can always sneak it into the final RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR packages up the set of PRs part of the v0.14.2 milestone into a new branch that will serve as the first release candidate for v0.14.2.