Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routerrpc: fix wrong error messages #6071

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

sputn1ck
Copy link
Collaborator

@sputn1ck sputn1ck commented Dec 8, 2021

This PR fixes two error messages in the router_backend.

When payment_hash or final_cltv_delta and payment_request was set, the error message showed that the parameters shouldn't be set with dest instead of payment_request

@Roasbeef Roasbeef added this to the v0.14.2 milestone Dec 8, 2021
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Changes look good. Could you append a [skip ci] in your commit message to bypass the CI check?

when payment_hash or final_cltv_delta and payment_request was set, the error message showed that the parameters shouldn't be set with dest instead of payment_request

[skip ci]
@sputn1ck
Copy link
Collaborator Author

sputn1ck commented Dec 9, 2021

Thanks for the PR! Changes look good. Could you append a [skip ci] in your commit message to bypass the CI check?

Added [skip ci] and force pushed!

@guggero guggero merged commit 94bbad3 into lightningnetwork:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants