lnrpc: fix the existing routing fee inaccuracy #6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating the channel routing policy, we encounter an inaccurate precision error when calculating the routing fee. The issue stems from the way the IEEE 754 standard works. The solution here is to add a uint64 parameter (as mentioned in the issue) and keep the float64 fee_rate parameter but rounding the product of the base and fee rate.
Roasbeef
force-pushed
the
routing-fee-fix
branch
from
f983068 to
40dd146
Compare
|
Only change here is not adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes over #6198
Fixes #4515
Fixes #6189