chainfee: return floor fee rate when a given target is not found #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
force-pushed
the
6056-fix-webapi
branch
3 times, most recently
from
50fdcb2 to
6256322
Compare
yyforyongyu
requested review from
guggero,
Roasbeef and
bhandras
and removed request for
Roasbeef
yyforyongyu
force-pushed
the
6056-fix-webapi
branch
from
6256322 to
7834b65
Compare
guggero
reviewed
Dec 6, 2021
yyforyongyu
force-pushed
the
6056-fix-webapi
branch
from
7834b65 to
7f3a146
Compare
|
A fee estimate of 1 is not included in the fee estimates on purpose, it doesn't make sense given the way that Bitcoin core estimates fees |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning an error, we now log the error and return a default fee rate when a given conf target cannot be found from the web fee estimator.
Fixes #6056.