Adds helper function lnrpc.RPCTransaction to create a single lnrpc.Transaction and refactors lnrpc.RPCTransactionDetails #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarnemagnussen
changed the title
guggero
approved these changes
Oct 13, 2021
bjarnemagnussen
force-pushed
the
upstream/RPCTransaction
branch
from
b894eab to
4ff2b07
Compare
|
Thanks @guggero for your quick review! I have addresses your points! |
carlaKC
approved these changes
Nov 30, 2021
|
Can you please add this to the 0.14.2 release notes, so we can get this merged? Thanks. |
bjarnemagnussen
force-pushed
the
upstream/RPCTransaction
branch
from
4ff2b07 to
d8b8182
Compare
|
Thanks! I have rebased and added release notes to 0.14.2 |
|
@bjarnemagnussen can you rebase again? The UI shows there's a merge conflict, but then doesn't actually say what it is.... |
bjarnemagnussen
force-pushed
the
upstream/RPCTransaction
branch
from
d8b8182 to
46c268e
Compare
Done! Let me know if is still causing some issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently inside
SubscribeTransactionsthe streamedlnrpc.Transactionstructure does not get itsLabelfield populated, which seems to be an oversight.This PR adds a helper function
lnrpc.RPCTransactionto return a singlelnrpc.Transactionand refactors the helper functionlnrpc.RPCTransactionDetails. This is alos used insideSubscribeTransactionsto make sure theLabelfield is correctly populated and have the creation of a RPC Transaction in one place.Fixes #5853