-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnwallet+docs: minrelayfee always above fee floor #6076
lnwallet+docs: minrelayfee always above fee floor #6076
Conversation
408d5b4
to
c48b28f
Compare
Thank you! I tested this branch to open a channel on my node that was previously stuck on 250 sat/kw which was insufficient for channel broadcasts on testnet. The channel funding tx broadcast worked, but interestingly I got a higher fee rate than expected of 3 sat/byte, see below
https://blockstream.info/testnet/tx/8d21ecf648fd99a7781f16ef99e90d52d120f42b7c53dcc49c38f5a00f7cc64f This was during a flurry of blocks on testnet (multiple within a minute) and near empty mempools and 1 sat/byte recommended by mempool.space. So I found this a bit odd, but I'll try a channel open again when testnet is under more normal conditions with blocks spaced a few minutes apart. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ☄️
The minimum relay fee is always ensured to be above our fee floor except in the very first min relay fee query to bitcoind. This commit ensures that the fee floor is respected in this first query.
c48b28f
to
2449e66
Compare
The minimum relay fee is always ensured to be above our fee floor except
in the very first min relay fee query to bitcoind. This commit ensures
that the fee floor is respected in this first query.
Fixes #6072