Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnwallet+docs: minrelayfee always above fee floor #6076

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

ellemouton
Copy link
Collaborator

The minimum relay fee is always ensured to be above our fee floor except
in the very first min relay fee query to bitcoind. This commit ensures
that the fee floor is respected in this first query.

Fixes #6072

@sangaman
Copy link
Contributor

Thank you! I tested this branch to open a channel on my node that was previously stuck on 250 sat/kw which was insufficient for channel broadcasts on testnet.

The channel funding tx broadcast worked, but interestingly I got a higher fee rate than expected of 3 sat/byte, see below

[INF] CHFD: Performing funding tx coin selection using 747 sat/kw as fee rate

https://blockstream.info/testnet/tx/8d21ecf648fd99a7781f16ef99e90d52d120f42b7c53dcc49c38f5a00f7cc64f

This was during a flurry of blocks on testnet (multiple within a minute) and near empty mempools and 1 sat/byte recommended by mempool.space. So I found this a bit odd, but I'll try a channel open again when testnet is under more normal conditions with blocks spaced a few minutes apart.

@Crypt-iQ
Copy link
Collaborator

Crypt-iQ commented Dec 10, 2021

Thank you! I tested this branch to open a channel on my node that was previously stuck on 250 sat/kw which was insufficient for channel broadcasts on testnet.

The channel funding tx broadcast worked, but interestingly I got a higher fee rate than expected of 3 sat/byte, see below

[INF] CHFD: Performing funding tx coin selection using 747 sat/kw as fee rate

https://blockstream.info/testnet/tx/8d21ecf648fd99a7781f16ef99e90d52d120f42b7c53dcc49c38f5a00f7cc64f

This was during a flurry of blocks on testnet (multiple within a minute) and near empty mempools and 1 sat/byte recommended by mempool.space. So I found this a bit odd, but I'll try a channel open again when testnet is under more normal conditions with blocks spaced a few minutes apart.

747 sat/kw is roughly 3 sat/byte
oops misread comment my bad

@Crypt-iQ Crypt-iQ added fees Related to the fees paid for transactions (both LN and funding/commitment transactions) wallet The wallet (lnwallet) which LND uses labels Dec 10, 2021
@Roasbeef
Copy link
Member

This was during a flurry of blocks on testnet (multiple within a minute) and near empty mempools and 1 sat/byte recommended by mempool.space.

lnd will just use w/e is returned by the fee estimator. Testnet is weird at times, and you'll see transactions over paying routinely as there're no economic constraints, so I wouldn't take too much stock in estimate returned on testnet.

@Roasbeef Roasbeef added this to the v0.14.2 milestone Dec 10, 2021
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☄️

The minimum relay fee is always ensured to be above our fee floor except
in the very first min relay fee query to bitcoind. This commit ensures
that the fee floor is respected in this first query.
@Roasbeef Roasbeef merged commit e58a979 into lightningnetwork:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fees Related to the fees paid for transactions (both LN and funding/commitment transactions) wallet The wallet (lnwallet) which LND uses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lnd is using 250 sat/kw instead of 253 sat/kw for estimation
4 participants