Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: add closing txid in PendingChannels' WaitingCloseChannel #6146

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

yyforyongyu
Copy link
Member

This PR adds a new field ClosingTxid in the section WaitingCloseChannel in PendingChannels, which is helpful for other services to easily perform CPFP based on the closing tx. Also a slight refactor is done in the method PendingChannels.

This commit refactors the method PendingChannels for maintenance
purpose.
@Roasbeef Roasbeef added this to the v0.14.2 milestone Jan 7, 2022
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌲

@yyforyongyu yyforyongyu requested a review from ellemouton January 8, 2022 10:07
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck 🚀

@guggero guggero merged commit ed511bb into lightningnetwork:master Jan 12, 2022
@yyforyongyu yyforyongyu deleted the add-closing-txid branch January 12, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants