Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement pending state for airdrop purposes #14276

Merged
merged 17 commits into from
Jul 22, 2024
Merged

feat: Implement pending state for airdrop purposes #14276

merged 17 commits into from
Jul 22, 2024

Conversation

vtronkov
Copy link
Contributor

@vtronkov vtronkov commented Jul 17, 2024 •
edited
Loading

Description:
Defining Readable and Writable stores for accessing and manipulating the pending airdrops state

Related issue(s):

Fixes #13938
Fixes #13939
Fixes #13940

Notes for reviewer:

When merging this PR we should merge hashgraph/hedera-protobufs#395 as well.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@vtronkov vtronkov changed the title feat: Implement pending state for airdrop purposes (#13566) feat: Implement pending state for airdrop purposes Jul 17, 2024
@vtronkov vtronkov mentioned this pull request Jul 17, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 57s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 49s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 58s ⏱️
280 tests 280 ✅ 0 💤 0 ❌
359 runs  359 ✅ 0 💤 0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@vtronkov vtronkov added this to the v0.53 milestone Jul 17, 2024
ibankov and others added 6 commits July 17, 2024 17:03
@ibankov @vtronkov
feat: Implement pending state for airdrop purposes (#13566)
e008f26 
Signed-off-by: ibankov <[email protected]>
Co-authored-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@vtronkov @ibankov
fix: compile errors
f330cd6 
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@vtronkov @ibankov
fix: change store to map of AccountAirdrop instead of PendingAirdropV…
290620e 
…alue

Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@vtronkov @ibankov
fix: compile error
954687a 
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@vtronkov @ibankov
feat: move the schema definition from 50 to 53
2121300 
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@vtronkov @ibankov
fix: register the new schema
0ced88c 
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@ibankov ibankov force-pushed the 13938-read-write-airdrop-store branch from a56d05f to 0ced88c Compare July 17, 2024 14:04
@vtronkov vtronkov marked this pull request as ready for review July 17, 2024 14:19
@vtronkov vtronkov requested a review from a team as a code owner July 17, 2024 14:19
@vtronkov vtronkov requested a review from a team July 17, 2024 14:19
@vtronkov vtronkov requested review from a team as code owners July 17, 2024 14:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

 24 files   24 suites   15m 7s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

 59 files   59 suites   15m 33s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs  398 ✅ 0 💤 0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  23m 10s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

 82 files   82 suites   23m 44s ⏱️
650 tests 650 ✅ 0 💤 0 ❌
758 runs  758 ✅ 0 💤 0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Node: Unit Test Results

  1 543 files    1 543 suites   3h 36m 24s ⏱️
117 470 tests 117 412 ✅ 58 💤 0 ❌
125 698 runs  125 640 ✅ 58 💤 0 ❌

Results for commit 8e92c6e.

♻️ This comment has been updated with latest results.

Neeharika-Sompalli
Neeharika-Sompalli previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments. But otherwise LGTM! Thanks @vtronkov

povolev15
povolev15 previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the question I had and @Neeharika-Sompalli comments all look good

@vtronkov
Merge branch 'refs/heads/develop' into 13938-read-write-airdrop-store
1564b92 
# Conflicts:
#	hedera-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/CommonPbjConverters.java
@vtronkov vtronkov dismissed stale reviews from povolev15 and Neeharika-Sompalli via 1564b92 July 19, 2024 03:21
vtronkov and others added 2 commits July 19, 2024 06:27
@vtronkov @Neeharika-Sompalli
Update hedera-node/hedera-token-service-impl/src/main/java/com/hedera…
8185b96 
…/node/app/service/token/impl/ReadableAirdropStoreImpl.java

Co-authored-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
@vtronkov
nit: remove unused import
2b1e601 
Signed-off-by: Valentin Tronkov <[email protected]>
Neeharika-Sompalli
Neeharika-Sompalli previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vtronkov

JeffreyDallas
JeffreyDallas previously approved these changes Jul 22, 2024
View reviewed changes
@ibankov
change proto branch
b03967b 
Signed-off-by: ibankov <[email protected]>
@ibankov ibankov dismissed stale reviews from JeffreyDallas and Neeharika-Sompalli via b03967b July 22, 2024 15:53
rbarkerSL
rbarkerSL approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neeharika-Sompalli Neeharika-Sompalli merged commit bbf1254 into develop Jul 22, 2024
39 of 40 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 13938-read-write-airdrop-store branch July 22, 2024 19:01
mxtartaglia-sl pushed a commit that referenced this pull request Jul 23, 2024
@vtronkov @ibankov
@Neeharika-Sompalli @mxtartaglia-sl
feat: Implement pending state for airdrop purposes (#14276)
64f9f1e 
Signed-off-by: ibankov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
Co-authored-by: Ivan Bankov <[email protected]>
Co-authored-by: Neeharika Sompalli <[email protected]>
netopyr added a commit that referenced this pull request Jul 23, 2024
@netopyr
Merge branch 'develop' into 14166-add-storeRegistry-serviceApiRegistry
61fe9ce 
* develop:
  feat: add new event hashing algorithm (#14340)
  fix: fixed a few issues on Dynamic Address Book (#14316)
  fix(gossip): wait outside of lock (#14336)
  feat: Implement pending state for airdrop purposes (#14276)
  chore: fix Javadoc warnings in 'platform' modules (#14338)
  chore: fix Javadoc warnings in 'test-clients' (#14337)
  chore: fix Javadoc warnings in 'services' modules (#14339)
  fix: 14230 platform state deserialization fix (#14334)
  fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support (#14323)
  feat: log socket exception stack trace periodically (#14318)
  fix: 14230 Fixed incorrect deserialization of `PlatformState` (#14332)
  feat: Add feature flag cookbook item (#14324)
  build: remove unused plugins (block-node) (#14254)
  build: Remove 'org.owasp:dependency-check-gradle' plugin (#14246)
  fix: remove hard dependency on 'commons.compress' (#14240)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ReadableStoreFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ServiceApiFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/WritableStoreFactory.java
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
@vtronkov vtronkov mentioned this pull request Jul 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibankov ibankov ibankov left review comments

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@JeffreyDallas JeffreyDallas JeffreyDallas left review comments

@povolev15 povolev15 povolev15 left review comments

@jasperpotts jasperpotts Awaiting requested review from jasperpotts

Assignees

@ibankov ibankov

Labels
None yet
Projects
None yet
Milestone
v0.53
6 participants
@vtronkov @povolev15 @ibankov @JeffreyDallas @Neeharika-Sompalli @rbarkerSL