Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Javadoc warnings in 'test-clients' #14337

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Jul 22, 2024

Description:
Fixes warnings given by the javadoc tool.

Related issue(s):

In preparation for #13645

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes jjohannes requested a review from a team July 22, 2024 06:49
@jjohannes jjohannes requested review from a team as code owners July 22, 2024 06:49
@jjohannes jjohannes self-assigned this Jul 22, 2024
@jjohannes jjohannes added this to the v0.53 milestone Jul 22, 2024
Copy link

github-actions bot commented Jul 22, 2024

Node: Unit Test Results

  1 533 files    1 533 suites   2h 36m 56s ⏱️
115 830 tests 115 772 ✅ 58 💤 0 ❌
124 038 runs  123 980 ✅ 58 💤 0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 46s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 43s ⏱️
280 tests 280 ✅ 0 💤 0 ❌
359 runs  359 ✅ 0 💤 0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 24s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Crypto) Results

 24 files   24 suites   15m 37s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Misc) Results

 59 files   59 suites   15m 59s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs  398 ✅ 0 💤 0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  23m 22s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 22, 2024

Node: HAPI Test (Smart Contract) Results

 81 files   81 suites   21m 56s ⏱️
650 tests 650 ✅ 0 💤 0 ❌
758 runs  758 ✅ 0 💤 0 ❌

Results for commit dccb06e.

♻️ This comment has been updated with latest results.

@jjohannes jjohannes force-pushed the 11569-fix-javadoc-warnings-tc branch from 4c5b6da to dccb06e Compare July 22, 2024 14:43
Copy link
Contributor

@derektriley derektriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jjohannes jjohannes merged commit addf2e8 into develop Jul 22, 2024
39 of 40 checks passed
@jjohannes jjohannes deleted the 11569-fix-javadoc-warnings-tc branch July 22, 2024 15:54
mxtartaglia-sl pushed a commit that referenced this pull request Jul 23, 2024
netopyr added a commit that referenced this pull request Jul 23, 2024
* develop:
  feat: add new event hashing algorithm (#14340)
  fix: fixed a few issues on Dynamic Address Book (#14316)
  fix(gossip): wait outside of lock (#14336)
  feat: Implement pending state for airdrop purposes (#14276)
  chore: fix Javadoc warnings in 'platform' modules (#14338)
  chore: fix Javadoc warnings in 'test-clients' (#14337)
  chore: fix Javadoc warnings in 'services' modules (#14339)
  fix: 14230 platform state deserialization fix (#14334)
  fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support (#14323)
  feat: log socket exception stack trace periodically (#14318)
  fix: 14230 Fixed incorrect deserialization of `PlatformState` (#14332)
  feat: Add feature flag cookbook item (#14324)
  build: remove unused plugins (block-node) (#14254)
  build: Remove 'org.owasp:dependency-check-gradle' plugin (#14246)
  fix: remove hard dependency on 'commons.compress' (#14240)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ReadableStoreFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ServiceApiFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/WritableStoreFactory.java
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants