Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support #14323

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support #14323

merged 2 commits into from
Jul 19, 2024

Conversation

artemananiev
Copy link
Member

@artemananiev artemananiev commented Jul 19, 2024 •
edited
Loading

Fix summary:

  • Removed KeyIndexType enum and all related code. All keys are handled as generic now
  • Removed getIndexType() method from KeySerializer
  • Removed all code related to long keys from MerkleDbDataSource
  • Removed all metrics related to long keys
  • Removed VirtualLongKey interface
  • No migration code is needed: existing apps (Hedera and MTT) don't use long keys

Fixes: #14309
Signed-off-by: Artem Ananev [email protected]

@artemananiev artemananiev added Tech Debt Reduced Issues which reduce technical debt. Platform Virtual Map Platform Data Structures Platform Tickets pertaining to the platform labels Jul 19, 2024
@artemananiev artemananiev added this to the v0.53 milestone Jul 19, 2024
@artemananiev artemananiev self-assigned this Jul 19, 2024
@artemananiev artemananiev requested review from a team as code owners July 19, 2024 03:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 50s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 49s ⏱️
280 tests 280 ✅ 0 💤 0 ❌
359 runs  359 ✅ 0 💤 0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 42s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

 24 files   24 suites   15m 20s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

 59 files   59 suites   16m 18s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs  398 ✅ 0 💤 0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

 82 files   82 suites   23m 35s ⏱️
650 tests 650 ✅ 0 💤 0 ❌
758 runs  758 ✅ 0 💤 0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  23m 2s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Node: Unit Test Results

  1 533 files    1 533 suites   2h 37m 25s ⏱️
115 830 tests 115 772 ✅ 58 💤 0 ❌
124 038 runs  123 980 ✅ 58 💤 0 ❌

Results for commit 6f760cc.

♻️ This comment has been updated with latest results.

imalygin
imalygin previously approved these changes Jul 19, 2024
View reviewed changes
@artemananiev
fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support
6f760cc 
Removed VirtualLongKey interface

Signed-off-by: Artem Ananev <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.62%. Comparing base (9973fae) to head (6f760cc).
Report is 163 commits behind head on develop.

Files Patch % Lines
.../java/com/swirlds/merkledb/MerkleDbDataSource.java 93.93% 1 Missing and 1 partial ⚠️
...om/swirlds/merkledb/MerkleDbStatisticsUpdater.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop   #14323      +/-   ##
=============================================
- Coverage      67.58%   57.62%   -9.97%     
+ Complexity     36486    21848   -14638     
=============================================
  Files           3732     2853     -879     
  Lines         149767   109756   -40011     
  Branches       15571    11248    -4323     
=============================================
- Hits          101223    63242   -37981     
+ Misses         44179    42937    -1242     
+ Partials        4365     3577     -788

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OlegMazurov
OlegMazurov approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@OlegMazurov OlegMazurov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for benchmarking code

@artemananiev artemananiev merged commit e747306 into develop Jul 19, 2024
44 of 46 checks passed
@artemananiev artemananiev deleted the 14309-D-drop-long-key-mode-merkledb branch July 19, 2024 23:11
mxtartaglia-sl pushed a commit that referenced this pull request Jul 23, 2024
@artemananiev @mxtartaglia-sl
fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support (#…
2578661 
…14323)

Fixes: #14309
Reviewed-by: Anthony Petrov <[email protected]>, Austin Littley <[email protected]>, Ivan Malygin <[email protected]>, Oleg Mazurov <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>
netopyr added a commit that referenced this pull request Jul 23, 2024
@netopyr
Merge branch 'develop' into 14166-add-storeRegistry-serviceApiRegistry
61fe9ce 
* develop:
  feat: add new event hashing algorithm (#14340)
  fix: fixed a few issues on Dynamic Address Book (#14316)
  fix(gossip): wait outside of lock (#14336)
  feat: Implement pending state for airdrop purposes (#14276)
  chore: fix Javadoc warnings in 'platform' modules (#14338)
  chore: fix Javadoc warnings in 'test-clients' (#14337)
  chore: fix Javadoc warnings in 'services' modules (#14339)
  fix: 14230 platform state deserialization fix (#14334)
  fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support (#14323)
  feat: log socket exception stack trace periodically (#14318)
  fix: 14230 Fixed incorrect deserialization of `PlatformState` (#14332)
  feat: Add feature flag cookbook item (#14324)
  build: remove unused plugins (block-node) (#14254)
  build: Remove 'org.owasp:dependency-check-gradle' plugin (#14246)
  fix: remove hard dependency on 'commons.compress' (#14240)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ReadableStoreFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ServiceApiFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/WritableStoreFactory.java
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
@imalygin imalygin mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs approved these changes

@litt3 litt3 litt3 approved these changes

@OlegMazurov OlegMazurov OlegMazurov approved these changes

@imalygin imalygin imalygin approved these changes

@jasperpotts jasperpotts Awaiting requested review from jasperpotts

Assignees

@artemananiev artemananiev

Labels
Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Milestone
v0.53
Development

Successfully merging this pull request may close these issues.

Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support
5 participants
@artemananiev @imalygin @OlegMazurov @litt3 @anthony-swirldslabs