Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log socket exception stack trace periodically #14318

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

anthony-swirldslabs
Copy link
Contributor

Description:
Add a RateLimiter and log the stack trace of socket exceptions once a minute.

Related issue(s):

Fixes #14304

Notes for reviewer:
Trivial changes to improve logging and diagnostics.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@anthony-swirldslabs anthony-swirldslabs added this to the v0.53 milestone Jul 18, 2024
@anthony-swirldslabs anthony-swirldslabs self-assigned this Jul 18, 2024
@anthony-swirldslabs anthony-swirldslabs requested review from a team as code owners July 18, 2024 22:21
Copy link

Node: HAPI Test (Token) Results

 22 files   22 suites   5m 53s ⏱️
280 tests 280 ✅ 0 💤 0 ❌
359 runs  359 ✅ 0 💤 0 ❌

Results for commit 06a8983.

Copy link

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 51s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 06a8983.

Copy link

Node: HAPI Test (Restart) Results

7 files  7 suites   9m 10s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 06a8983.

Copy link

Node: HAPI Test (Crypto) Results

 24 files   24 suites   14m 51s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 06a8983.

Copy link

Node: HAPI Test (Misc) Results

 59 files   59 suites   15m 54s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs  398 ✅ 0 💤 0 ❌

Results for commit 06a8983.

Copy link

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 50s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 06a8983.

Copy link

Node: HAPI Test (Smart Contract) Results

 81 files   81 suites   24m 17s ⏱️
650 tests 650 ✅ 0 💤 0 ❌
758 runs  758 ✅ 0 💤 0 ❌

Results for commit 06a8983.

Copy link

Node: Unit Test Results

  1 533 files    1 533 suites   3h 5m 1s ⏱️
115 831 tests 115 773 ✅ 58 💤 0 ❌
124 039 runs  123 981 ✅ 58 💤 0 ❌

Results for commit 06a8983.

@anthony-swirldslabs anthony-swirldslabs merged commit 962b4ba into develop Jul 19, 2024
57 of 59 checks passed
@anthony-swirldslabs anthony-swirldslabs deleted the 14304-logSocketExceptionStackTrace branch July 19, 2024 19:39
mxtartaglia-sl pushed a commit that referenced this pull request Jul 23, 2024
netopyr added a commit that referenced this pull request Jul 23, 2024
* develop:
  feat: add new event hashing algorithm (#14340)
  fix: fixed a few issues on Dynamic Address Book (#14316)
  fix(gossip): wait outside of lock (#14336)
  feat: Implement pending state for airdrop purposes (#14276)
  chore: fix Javadoc warnings in 'platform' modules (#14338)
  chore: fix Javadoc warnings in 'test-clients' (#14337)
  chore: fix Javadoc warnings in 'services' modules (#14339)
  fix: 14230 platform state deserialization fix (#14334)
  fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support (#14323)
  feat: log socket exception stack trace periodically (#14318)
  fix: 14230 Fixed incorrect deserialization of `PlatformState` (#14332)
  feat: Add feature flag cookbook item (#14324)
  build: remove unused plugins (block-node) (#14254)
  build: Remove 'org.owasp:dependency-check-gradle' plugin (#14246)
  fix: remove hard dependency on 'commons.compress' (#14240)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ReadableStoreFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ServiceApiFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/WritableStoreFactory.java
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add periodic stack trace printing for socket exception
2 participants