feat: Implement pending state for airdrop purposes #13566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibankov
force-pushed
the
13113-read-write-airdrop-store
branch
from
0955fc8 to
2de6a7f
Compare
vtronkov
reviewed
May 31, 2024
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/TokensConfig.java
Outdated
Show resolved
Hide resolved
vtronkov
reviewed
May 31, 2024
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAirdropStore.java
Outdated
Show resolved
Hide resolved
vtronkov
reviewed
May 31, 2024
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAirdropStore.java
Outdated
Show resolved
Hide resolved
vtronkov
reviewed
Jun 3, 2024
| @@ -39,6 +43,8 @@ | |||
| public class V0500TokenSchema extends Schema { | |||
| private static final Logger log = LogManager.getLogger(V0500TokenSchema.class); | |||
| private static final String SHARED_VALUES_KEY = "V0500_FIRST_STORAGE_KEYS"; | |||
| private static final long MAX_PENDING_AIRDROPS = 1_000_000_000L; | |||
There was a problem hiding this comment.
A question for the PR reviewer: do you think this is accurate?
vtronkov
reviewed
Jun 3, 2024
Comment on lines
+50
to
+51
| @ConfigProperty(value = "maxAllowedAirdrops", defaultValue = "1000000") @NetworkProperty | ||
| long maxAllowedAirdorps, |
There was a problem hiding this comment.
Waiting for @netopyr to give us the exact value here.
vtronkov
reviewed
Jun 3, 2024
.../src/test/java/com/hedera/node/app/service/token/impl/test/ReadableAirdropStoreImplTest.java
Show resolved
Hide resolved
vtronkov
reviewed
Jun 3, 2024
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAirdropStore.java
Show resolved
Hide resolved
vtronkov
reviewed
Jun 3, 2024
...impl/src/test/java/com/hedera/node/app/service/token/impl/test/WritableAirdropStoreTest.java
Show resolved
Hide resolved
vtronkov
changed the title
...vice-impl/src/main/java/com/hedera/node/app/service/token/impl/ReadableAirdropStoreImpl.java
Outdated
Show resolved
Hide resolved
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAirdropStore.java
Show resolved
Hide resolved
...dera-token-service/src/main/java/com/hedera/node/app/service/token/ReadableAirdropStore.java
Outdated
Show resolved
Hide resolved
...vice-impl/src/main/java/com/hedera/node/app/service/token/impl/ReadableAirdropStoreImpl.java
Show resolved
Hide resolved
Signed-off-by: ibankov <[email protected]>
…rdrop-store' into 13113-read-write-airdrop-store
ibankov
commented
Jun 18, 2024
gradle/plugins/src/main/kotlin/com/hedera/gradle/tasks/GitClone.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## airdrop-store-and-tokenAirdropTransaction-implementation #13566 +/- ##
===========================================================================================
Coverage ? 58.32%
Complexity ? 22112
===========================================================================================
Files ? 2890
Lines ? 109789
Branches ? 11169
===========================================================================================
Hits ? 64034
Misses ? 42214
Partials ? 3541 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Jun 19, 2024
…plementation' into 13113-read-write-airdrop-store # Conflicts: # hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/pbj/PbjConverter.java
vtronkov
approved these changes
Jun 25, 2024
Signed-off-by: ibankov <[email protected]>
…plementation' into 13113-read-write-airdrop-store # Conflicts: # hapi/build.gradle.kts # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java
Signed-off-by: ibankov <[email protected]>
ibankov
merged commit 8204322
into
airdrop-store-and-tokenAirdropTransaction-implementation
40 of 41 checks passed
This was referenced Jul 2, 2024
JivkoKelchev
pushed a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: ibankov <[email protected]> Co-authored-by: Valentin Tronkov <[email protected]>
ibankov
added a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: ibankov <[email protected]> Co-authored-by: Valentin Tronkov <[email protected]> Signed-off-by: ibankov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Defining Readable and Writable stores for accessing and manipulating the pending airdrops state
Related issue(s):
Fixes #13938
Fixes #13939
Fixes #13940
Notes for reviewer:
Merge after hashgraph/hedera-protobufs#371 is merged and protobuf updated.
Note: Currently, the schema is added to V0500TokenSchema file but when it's time to merge the story we will move it to the correct version
Checklist