Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Protobuf changes for registering airdrop #371

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Jun 10, 2024

Description:

This PR modifies the protobufs in order to support creating Airdrops

Related issue(s):

hashgraph/hedera-services#13698

Fixes #

Notes for reviewer:

Merge this PR after #367 is merged in main and this branch is synced with main, otherwise the build in Services develop branch will fail.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov requested review from a team as code owners June 10, 2024 06:40
@ibankov ibankov requested review from povolev15 and edwin-greene and removed request for a team June 10, 2024 06:40
@ibankov ibankov force-pushed the hip-904-register-airdrop-proto branch from ec8a6e1 to e754cc7 Compare June 10, 2024 06:44
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small wording updates, and possible corrections for what fees are charged at the time of the airdrop transaction versus the time of the claim transaction.

services/basic_types.proto Outdated Show resolved Hide resolved
services/token_airdrop.proto Outdated Show resolved Hide resolved
services/token_airdrop.proto Show resolved Hide resolved
services/token_airdrop.proto Show resolved Hide resolved
services/token_airdrop.proto Show resolved Hide resolved
@ibankov ibankov requested a review from jsync-swirlds June 17, 2024 14:07
@ibankov ibankov requested a review from a team as a code owner June 18, 2024 08:24
@ibankov ibankov requested a review from tomzhenghedera June 18, 2024 08:24
@ibankov ibankov changed the base branch from hip-904-proto-updates-52 to hip-904-proto-updates June 19, 2024 08:19
@jsync-swirlds jsync-swirlds force-pushed the hip-904-proto-updates branch 2 times, most recently from 4aceaa4 to b8a0a26 Compare June 24, 2024 15:39
@ibankov ibankov self-assigned this Jun 26, 2024
@ibankov ibankov force-pushed the hip-904-register-airdrop-proto branch from 5c00254 to 00e5e66 Compare June 28, 2024 08:23
@ibankov ibankov force-pushed the hip-904-register-airdrop-proto branch from 00e5e66 to 786cf14 Compare June 28, 2024 12:45
@ibankov ibankov merged commit 58939ce into hashgraph:hip-904-proto-updates Jul 1, 2024
1 check passed
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
Token Airdrop Proto changes

Signed-off-by: ibankov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
vtronkov pushed a commit that referenced this pull request Jul 23, 2024
Token Airdrop Proto changes

Signed-off-by: ibankov <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants