-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Protobuf changes for registering airdrop #371
Merged
ibankov
merged 1 commit into
hashgraph:hip-904-proto-updates
from
LimeChain:hip-904-register-airdrop-proto
Jul 1, 2024
Merged
feat: Protobuf changes for registering airdrop #371
ibankov
merged 1 commit into
hashgraph:hip-904-proto-updates
from
LimeChain:hip-904-register-airdrop-proto
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibankov
requested review from
povolev15 and
edwin-greene
and removed request for
a team
June 10, 2024 06:40
ibankov
force-pushed
the
hip-904-register-airdrop-proto
branch
from
June 10, 2024 06:44
ec8a6e1
to
e754cc7
Compare
vtronkov
approved these changes
Jun 10, 2024
This was referenced Jun 10, 2024
Nana-EC
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small wording updates, and possible corrections for what fees are charged at the time of the airdrop transaction versus the time of the claim transaction.
2 tasks
ibankov
changed the base branch from
hip-904-proto-updates-52
to
hip-904-proto-updates
June 19, 2024 08:19
jsync-swirlds
force-pushed
the
hip-904-proto-updates
branch
2 times, most recently
from
June 24, 2024 15:39
4aceaa4
to
b8a0a26
Compare
ibankov
force-pushed
the
hip-904-register-airdrop-proto
branch
from
June 28, 2024 08:23
5c00254
to
00e5e66
Compare
Signed-off-by: ibankov <[email protected]>
ibankov
force-pushed
the
hip-904-register-airdrop-proto
branch
from
June 28, 2024 12:45
00e5e66
to
786cf14
Compare
2 tasks
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
Token Airdrop Proto changes Signed-off-by: ibankov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
vtronkov
pushed a commit
that referenced
this pull request
Jul 23, 2024
Token Airdrop Proto changes Signed-off-by: ibankov <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modifies the protobufs in order to support creating Airdrops
Related issue(s):
hashgraph/hedera-services#13698
Fixes #
Notes for reviewer:
Merge this PR after #367 is merged in main and this branch is synced with main, otherwise the build in Services develop branch will fail.
Checklist